From: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "jdelvare@suse.com" <jdelvare@suse.com>,
"robh@kernel.org" <robh@kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"ukleinek@kernel.org" <ukleinek@kernel.org>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>
Subject: Re: [PATCH v7 3/3] hwmon: (adt7475) Add support for configuring initial PWM state
Date: Thu, 25 Jul 2024 21:02:28 +0000 [thread overview]
Message-ID: <ee3b9800-4649-4e8a-af67-80713e76b79d@alliedtelesis.co.nz> (raw)
In-Reply-To: <aaa8217b-031d-40e7-96a7-b9ed8482748a@roeck-us.net>
On 26/07/24 02:09, Guenter Roeck wrote:
> On Tue, Jul 23, 2024 at 10:17:37AM +1200, Chris Packham wrote:
>> By default the PWM duty cycle in hardware is 100%. On some systems this
>> can cause unwanted fan noise. Add the ability to specify the fan
>> connections and initial state of the PWMs via device properties.
>>
>> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> CHECK: Blank lines aren't necessary before a close brace '}'
> #207: FILE: drivers/hwmon/adt7475.c:1734:
> +
> +}
>
> Never mind, applied after fixing the above.
Hmm, odd checkpatch.pl doesn't complain for me
$ ./scripts/checkpatch.pl
patches/adt-init-duty/v7/v7-0003-hwmon-adt7475-Add-support-for-configuring-initial.patch
total: 0 errors, 0 warnings, 149 lines checked
patches/adt-init-duty/v7/v7-0003-hwmon-adt7475-Add-support-for-configuring-initial.patch
has no obvious style problems and is ready for submission.
>
> Thanks,
> Guenter
next prev parent reply other threads:[~2024-07-25 21:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-22 22:17 [PATCH v7 0/3] hwmon: (adt7475) duty cycle configuration Chris Packham
2024-07-22 22:17 ` [PATCH v7 1/3] dt-bindings: hwmon: Add adt7475 fan/pwm properties Chris Packham
2024-07-25 14:06 ` Guenter Roeck
2025-05-27 16:12 ` Uwe Kleine-König
2025-05-27 20:24 ` Chris Packham
2025-05-28 6:10 ` Uwe Kleine-König
2025-05-28 21:18 ` Chris Packham
2025-05-30 9:38 ` Uwe Kleine-König
2025-06-02 20:52 ` Chris Packham
2025-06-03 8:20 ` Uwe Kleine-König
2025-06-02 15:00 ` Guenter Roeck
2024-07-22 22:17 ` [PATCH v7 2/3] dt-bindings: hwmon: adt7475: Deprecate adi,pwm-active-state Chris Packham
2024-07-25 14:06 ` Guenter Roeck
2024-07-22 22:17 ` [PATCH v7 3/3] hwmon: (adt7475) Add support for configuring initial PWM state Chris Packham
2024-07-25 14:09 ` Guenter Roeck
2024-07-25 21:02 ` Chris Packham [this message]
2024-07-25 22:01 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee3b9800-4649-4e8a-af67-80713e76b79d@alliedtelesis.co.nz \
--to=chris.packham@alliedtelesis.co.nz \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzk+dt@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
--cc=ukleinek@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®