From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 734762EC571; Fri, 25 Sep 2026 12:56:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790340999; cv=none; b=PTfsADnFf2S/FHo8EECVY3y+db1GzxvyOUmXPOzwxKtswBmD8DReVb5H9tKnFFy4idBFsWP4Mw6n5TU8PRdhjNWAf+SWn5x85dOS/BkZ9DAAhyCcCnC/abDzdaHsDo4dy+o0oVAHHq38nNFiSeNPKFCBVTt04CIU0gMAF5WnHoU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790340999; c=relaxed/simple; bh=xm+mooZ0XkAGq6GKU7h4yi+KjgP6Je8ezgCLqOb4z6c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=t1FpMAQfpd+65/EFyKmwOu2YrxbIfyEnicCsXJktiTVQor49SHaL13wNHhafgDsXhzlPpx2Lnz1ZDstAGterts9xroJ/wWlvOoO/MwbNLNaxBS4YRMUdlji+2wuLbI3LbNIcpzAWJh0vcE4B0ToFF+HDG6LkFo5Rcb2j44mAv2M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=JQPp/4Pa; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="JQPp/4Pa" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 26934169C; Fri, 25 Sep 2026 05:56:33 -0700 (PDT) Received: from [10.164.19.84] (a081061.arm.com [10.164.19.84]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1A27B3F86C; Fri, 25 Sep 2026 05:56:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1790340996; bh=xm+mooZ0XkAGq6GKU7h4yi+KjgP6Je8ezgCLqOb4z6c=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=JQPp/4PadiQm3gluMM0otFqo8NCqzpexmW4TOx/2YJgBOhy9iBaZzg/USMbgG6i8G 464Kwohpyq8Tb2u/dH+SbWe/zxdNlQkRc5bi07RReOMNdr0pxxsl2JAu2PC8Yl/rZY 4d8OEjgeYrfLLTzrBon7MlH/RNJHRL4V6f2LIdAU= Message-ID: Date: Fri, 25 Sep 2026 18:26:28 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 4/4] kselftest: mm: remove check_huge_shmem() To: Yeoreum Yun , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Zi Yan , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Usama Arif , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Shuah Khan , Kevin Brodsky Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260924-fix_split-v8-0-cba7359d882a@arm.com> <20260924-fix_split-v8-4-cba7359d882a@arm.com> Content-Language: en-US From: Sarthak Sharma In-Reply-To: <20260924-fix_split-v8-4-cba7359d882a@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 9/25/26 12:41 AM, Yeoreum Yun wrote: > check_huge_shmem() was required to distinguish shmem huge pages because > /proc/self/smaps reports them using a dedicated “ShmemPmdMapped” entry, > as opposed to “FilePmdMapped” for file-backed huge pages. > > Now that /proc/self/smaps is no longer used to detect huge pages and > /proc/kpageflags is used instead, it is sufficient to distinguish > between file-backed and anonymous pages since the ShmemPmdMapped is also > kind of file-backed. > > Therefore, remove check_huge_shmem() and use check_huge_file() instead > and cleanup khugepaged's check_huge operation in mem_ops. > > Suggested-by: David Hildenbrand (Arm) > Reviewed-by: Baolin Wang > Acked-by: Zi Yan > Acked-by: Lorenzo Stoakes (ARM) > Acked-by: David Hildenbrand (Arm) > Signed-off-by: Yeoreum Yun > --- Looks good to me, so: Reviewed-by: Sarthak Sharma