From: Krzysztof Kozlowski <krzk@kernel.org>
To: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>
Cc: Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Lorenzo Bianconi <lorenzo.bianconi@oss.qualcomm.com>,
Shawn Guo <shengchao.guo@oss.qualcomm.com>,
Zhangfei Gao <zhangfei.gao@oss.qualcomm.com>
Subject: Re: [PATCH 1/3] dt-bindings: phy: qcom,sa8775p-dwmac-sgmii-phy: add Nord compatible
Date: Mon, 28 Sep 2026 13:02:04 +0200 [thread overview]
Message-ID: <ee480f01-fd84-4eda-85fb-9d5cad5f3d86@kernel.org> (raw)
In-Reply-To: <arpH+9ytWKFntjiz@oss.qualcomm.com>
On 28/09/2026 12:56, Mohd Ayaan Anwar wrote:
> On Mon, Sep 28, 2026 at 12:16:45PM +0200, Krzysztof Kozlowski wrote:
>> On Wed, Sep 23, 2026 at 05:34:17AM +0530, Mohd Ayaan Anwar wrote:
>>> Add the qcom,nord-dwmac-sgmii-phy compatible to the Qualcomm DWMAC
>>> SGMII PHY binding.
>>
>> Why random order? Why not enum with existing part?
>
> You are right. I will group the stanalone compatibles into a single enum
> and sort them alphabetically in v2.
>
>> Why not even compatible with existing device?
>
> Nord uses the QMP v7 SerDes register layout, whereas sa8775p uses the
> v5 layout. The offsets differ, so Nord cannot use
> qcom,sa8775p-dwmac-sgmii-phy as a fallback compatible.
This is useful to be mentioned in the commit msg. Commit msg does not
have to be long. It also does not have to repeat the obvious parts.
Usually it is enough "Add foo bar, not compatible with existing baz baz
because of different register offsets".
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-09-28 11:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 0:04 [PATCH 0/3] phy: qcom: sgmii-eth: add Nord USXGMII support Mohd Ayaan Anwar
2026-09-23 0:04 ` [PATCH 1/3] dt-bindings: phy: qcom,sa8775p-dwmac-sgmii-phy: add Nord compatible Mohd Ayaan Anwar
2026-09-25 13:35 ` Lorenzo Bianconi
2026-09-25 13:59 ` Bartosz Golaszewski
2026-09-28 10:16 ` Krzysztof Kozlowski
2026-09-28 10:26 ` Krzysztof Kozlowski
2026-09-28 10:56 ` Mohd Ayaan Anwar
2026-09-28 11:02 ` Krzysztof Kozlowski [this message]
2026-09-23 0:04 ` [PATCH 2/3] phy: qcom: sgmii-eth: prepare for additional PHY modes Mohd Ayaan Anwar
2026-09-25 13:49 ` Lorenzo Bianconi
2026-09-23 0:04 ` [PATCH 3/3] phy: qcom: sgmii-eth: add Nord USXGMII support Mohd Ayaan Anwar
2026-09-25 13:59 ` Lorenzo Bianconi
2026-09-23 8:58 ` [PATCH 0/3] " Zhangfei Gao
2026-09-28 10:19 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee480f01-fd84-4eda-85fb-9d5cad5f3d86@kernel.org \
--to=krzk@kernel.org \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lorenzo.bianconi@oss.qualcomm.com \
--cc=mani@kernel.org \
--cc=mohd.anwar@oss.qualcomm.com \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=shengchao.guo@oss.qualcomm.com \
--cc=vkoul@kernel.org \
--cc=zhangfei.gao@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®