From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751000AbdLGIPR (ORCPT ); Thu, 7 Dec 2017 03:15:17 -0500 Received: from mout.kundenserver.de ([212.227.126.131]:52653 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750781AbdLGIPQ (ORCPT ); Thu, 7 Dec 2017 03:15:16 -0500 Subject: Re: [PATCH 1/1] codestyle issue fixed drivers/staging/vc04_services To: Mikhail Shvetsov Cc: eric@anholt.net, gregkh@linuxfoundation.org, goudapatilk@gmail.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, lameli67@yandex.ru References: <40d794a2bd0dd9dbb3add85c79b9b314ccbb480a.1512631936.git.lameli67@gmail.com> From: Stefan Wahren Message-ID: Date: Thu, 7 Dec 2017 09:14:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <40d794a2bd0dd9dbb3add85c79b9b314ccbb480a.1512631936.git.lameli67@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: de-DE X-Provags-ID: V03:K0:ERwWTilgcfRWtdjGNvUmWZ/JH0lafPVwjJb5ytXF1Lm9QvAUwdE YsoJ2UClQ3wmlao5SNoltFtWVAxV+fG8Yo6L4WQauAOHc0MD90pVI3u5eNeMjiMA49q6Ih+ 7MOC0R1CYN6pY11RKgBDDkGsoR1XhlC+BEKjxkpwRFNAh91RMZ1XL7kv9a4eYBt33DIe1jg valSUvmFi7bckX3bdk0Rw== X-UI-Out-Filterresults: notjunk:1;V01:K0:ikqkrrgGwZk=:81nGyKnR6fnXG+NG8lb8p7 rB0aK02oato7Nm9VQ0i9/IxmcBR+CknWsnUVf8l9sCMBHif+ZYB9x6y3zqgmqnN4rfRdsvLEZ dCvltVJZ1ruceSiOPeLSv/d785jxDTMYDEjl+Snm5cQiF4v5p8juLp+xI/L9Nz81QNaadh5YL GPNbLyL1CzxSghrgYhm9Kaskw7hOXPqdH69lVYnw0lsUf0kXoJd9NbH8IkzGtlTtVgf7SYoAf 2z9ILQIY2BhyiruMMWeDJ98/kELbreY33PiCVdcfzyE036n68oK36QrJDlTV3Ei7zOnxLp5wW 1fsE59pPzt3tPZjFc6+zojHob5MAFXWYMY3yWHmIH8/GnT9CkNzXn1as2b8HTwnbvAhIqi7YT uGZ9vrDURQjahI6yBIMj2eo9e6V1vaobltoK34hL4ytuxCFnuvoIo3rpoEZmjGto1t0jDCgqm jVtsTP6Tj2be4Qu01xKbw3zTiYCvJjh0gmPKDoPGPkH+6IArBucl18r9b++8zsy/0QlufJbl5 nkY/YLcmllxNobwP0EZu2uZr0Z2QIFSQIqA4rDzxLqI3gOKYo9uSG4OaqVBjS9rNityDScKqr cZ94z1cfzZBzhN4IhPMSvXFyJ0BR4qcEn53M+GDPts2okFbhXA/9mcRVOyRT9p6LdpWyUsWs2 73AfBn4Sn8HpsDY03m13BHAuYQkTskTjEoaGfZ3Uv+RC3Omfv89gPMuJD2P6jIPe9ncO+q4MW wLcC6raNrMvAlG6pTBbu61rt1lVa+sFBAJtn80tijKfTIWjfEoNiDyQid4WIjrtkqfOYbN8Qg 8X4RD5FJ6D08nLGLShKuHokVGztcQ3KhvOWpRe+1qvtSJC9QUwDQ5sG/qzGnH/ng2dmNIN6Ke jR4Sm6Abqe4tAC0h0Wg/RkJqrb38EP+360rDMH1VJqX7QA9kDhKQLrwy8ZpgKZ1WEOyk9xI5o AiCctxL4CuqbLzJGfA41DXFxXsrJdRFg= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Mikhail, Am 07.12.2017 um 08:47 schrieb Mikhail Shvetsov: > From: Mike please provide your full name and a changelog. Also the subject should start with something like "staging: vchiq_arm:". > > Signed-off-by: Mike > --- > .../interface/vchiq_arm/vchiq_kern_lib.c | 64 ++++++++++++---------- > 1 file changed, 35 insertions(+), 29 deletions(-) > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_kern_lib.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_kern_lib.c > index 34f746db19cd..d21bb154f78c 100644 > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_kern_lib.c > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_kern_lib.c > @@ -65,10 +65,10 @@ vchiq_blocking_bulk_transfer(VCHIQ_SERVICE_HANDLE_T handle, void *data, > unsigned int size, VCHIQ_BULK_DIR_T dir); > > /**************************************************************************** > -* > -* vchiq_initialise > -* > -***************************************************************************/ > + * > + * vchiq_initialise > + * > + ***************************************************************************/ Instead of fixing the comment style, i prefer to drop this kind of useless comments in a separate patch. > #define VCHIQ_INIT_RETRIES 10 > VCHIQ_STATUS_T vchiq_initialise(VCHIQ_INSTANCE_T *instance_out) > { > @@ -80,7 +80,9 @@ VCHIQ_STATUS_T vchiq_initialise(VCHIQ_INSTANCE_T *instance_out) > vchiq_log_trace(vchiq_core_log_level, "%s called", __func__); > > /* VideoCore may not be ready due to boot up timing. > - It may never be ready if kernel and firmware are mismatched, so don't block forever. */ > + * It may never be ready if kernel and firmware are mismatched, so don't > + * block forever. > + */ > for (i = 0; i < VCHIQ_INIT_RETRIES; i++) { > state = vchiq_get_state(); > if (state) > @@ -93,7 +95,8 @@ VCHIQ_STATUS_T vchiq_initialise(VCHIQ_INSTANCE_T *instance_out) > goto failed; > } else if (i > 0) { > vchiq_log_warning(vchiq_core_log_level, > - "%s: videocore initialized after %d retries\n", __func__, i); > + "%s: videocore initialized after %d retries\n", > + __func__, i); This isn't a comment, so it should be a separate patch. > } > > instance = kzalloc(sizeof(*instance), GFP_KERNEL); > @@ -121,10 +124,10 @@ VCHIQ_STATUS_T vchiq_initialise(VCHIQ_INSTANCE_T *instance_out) > EXPORT_SYMBOL(vchiq_initialise); > > /**************************************************************************** > -* > -* vchiq_shutdown > -* > -***************************************************************************/ > + * > + * vchiq_shutdown > + * > + ***************************************************************************/ > > VCHIQ_STATUS_T vchiq_shutdown(VCHIQ_INSTANCE_T instance) > { > @@ -169,10 +172,10 @@ VCHIQ_STATUS_T vchiq_shutdown(VCHIQ_INSTANCE_T instance) > EXPORT_SYMBOL(vchiq_shutdown); > > /**************************************************************************** > -* > -* vchiq_is_connected > -* > -***************************************************************************/ > + * > + * vchiq_is_connected > + * > + ***************************************************************************/ > > static int vchiq_is_connected(VCHIQ_INSTANCE_T instance) > { > @@ -180,10 +183,10 @@ static int vchiq_is_connected(VCHIQ_INSTANCE_T instance) > } > > /**************************************************************************** > -* > -* vchiq_connect > -* > -***************************************************************************/ > + * > + * vchiq_connect > + * > + ***************************************************************************/ > > VCHIQ_STATUS_T vchiq_connect(VCHIQ_INSTANCE_T instance) > { > @@ -215,10 +218,10 @@ VCHIQ_STATUS_T vchiq_connect(VCHIQ_INSTANCE_T instance) > EXPORT_SYMBOL(vchiq_connect); > > /**************************************************************************** > -* > -* vchiq_add_service > -* > -***************************************************************************/ > + * > + * vchiq_add_service > + * > + ***************************************************************************/ > > VCHIQ_STATUS_T vchiq_add_service( > VCHIQ_INSTANCE_T instance, > @@ -260,10 +263,10 @@ VCHIQ_STATUS_T vchiq_add_service( > EXPORT_SYMBOL(vchiq_add_service); > > /**************************************************************************** > -* > -* vchiq_open_service > -* > -***************************************************************************/ > + * > + * vchiq_open_service > + * > + ***************************************************************************/ > > VCHIQ_STATUS_T vchiq_open_service( > VCHIQ_INSTANCE_T instance, > @@ -414,8 +417,9 @@ vchiq_blocking_bulk_transfer(VCHIQ_SERVICE_HANDLE_T handle, void *data, > if ((bulk->data != data) || > (bulk->size != size)) { > /* This is not a retry of the previous one. > - ** Cancel the signal when the transfer > - ** completes. */ > + * Cancel the signal when the transfer > + * completes. > + */ > spin_lock(&bulk_waiter_spinlock); > bulk->userdata = NULL; > spin_unlock(&bulk_waiter_spinlock); > @@ -441,7 +445,9 @@ vchiq_blocking_bulk_transfer(VCHIQ_SERVICE_HANDLE_T handle, void *data, > > if (bulk) { > /* Cancel the signal when the transfer > - ** completes. */ > + * Please avoid this empty line. Thanks > + * completes. > + */ > spin_lock(&bulk_waiter_spinlock); > bulk->userdata = NULL; > spin_unlock(&bulk_waiter_spinlock);