From: Jayesh Choudhary <j-choudhary@ti.com>
To: Nishanth Menon <nm@ti.com>, Siddharth Vadapalli <s-vadapalli@ti.com>
Cc: <vigneshr@ti.com>, <kristo@kernel.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski@linaro.org>,
<krzysztof.kozlowski+dt@linaro.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <srk@ti.com>
Subject: Re: [PATCH 1/2] arm64: dts: ti: k3-j784s4-mcu-wakeup: Add device id property for mcu_navss
Date: Tue, 14 Mar 2023 20:05:12 +0530 [thread overview]
Message-ID: <ee4dbb15-30c3-259b-3ae7-4f7ad4898d33@ti.com> (raw)
In-Reply-To: <20230314132922.ejbutfxt7z7xhqgm@danger>
On 14/03/23 18:59, Nishanth Menon wrote:
> On 16:10-20230314, Siddharth Vadapalli wrote:
>> The "ti,sci-dev-id" property used to indicate the Device ID is missing
>> for mcu_navss device-tree node. Add it.
>>
>> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
>> ---
>> arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi
>> index 93952af618f6..52311da15579 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi
>> @@ -212,6 +212,8 @@ mcu_navss: bus@28380000{
>> dma-coherent;
>> dma-ranges;
>>
>> + ti,sci-dev-id = <323>;
>> +
>> mcu_ringacc: ringacc@2b800000 {
>> compatible = "ti,am654-navss-ringacc";
>> reg = <0x00 0x2b800000 0x00 0x400000>,
>> --
>> 2.25.1
>>
>
> Looks like
> https://lore.kernel.org/all/20230313104721.407071-2-j-choudhary@ti.com/
> is another part of the Fixup?
>
> Why not squash the two as a missing ti,sci-dev-id for j784s4?
Okay I will add this to my series and re-roll v2.
-Jayesh
>
>
next prev parent reply other threads:[~2023-03-14 14:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 10:40 [PATCH 0/2] Enable MCU CPSW2G on J7AHP Siddharth Vadapalli
2023-03-14 10:40 ` [PATCH 1/2] arm64: dts: ti: k3-j784s4-mcu-wakeup: Add device id property for mcu_navss Siddharth Vadapalli
2023-03-14 13:26 ` Nishanth Menon
2023-03-14 13:29 ` Nishanth Menon
2023-03-14 14:35 ` Jayesh Choudhary [this message]
2023-03-14 10:40 ` [PATCH 2/2] arm64: dts: ti: k3-j784s4-evm: Enable MCU CPSW2G Siddharth Vadapalli
2023-03-14 22:10 ` Andrew Davis
2023-03-15 4:02 ` Siddharth Vadapalli
2023-03-14 12:04 ` [PATCH 0/2] Enable MCU CPSW2G on J7AHP Siddharth Vadapalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee4dbb15-30c3-259b-3ae7-4f7ad4898d33@ti.com \
--to=j-choudhary@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=srk@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®