From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 720E8C35254 for ; Mon, 17 Feb 2020 10:01:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4C98C206F4 for ; Mon, 17 Feb 2020 10:01:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729044AbgBQKBG (ORCPT ); Mon, 17 Feb 2020 05:01:06 -0500 Received: from foss.arm.com ([217.140.110.172]:33120 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726397AbgBQKBF (ORCPT ); Mon, 17 Feb 2020 05:01:05 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 578C730E; Mon, 17 Feb 2020 02:01:05 -0800 (PST) Received: from [10.1.195.32] (e112269-lin.cambridge.arm.com [10.1.195.32]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 473883F6CF; Mon, 17 Feb 2020 02:01:02 -0800 (PST) Subject: Re: [PATCH v17 21/23] arm64: mm: Convert mm/dump.c to use walk_page_range() To: Ard Biesheuvel Cc: Andrew Morton , Linux-MM , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Catalin Marinas , Dave Hansen , Ingo Molnar , James Morse , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Peter Zijlstra , Thomas Gleixner , Will Deacon , the arch/x86 maintainers , "H. Peter Anvin" , linux-arm-kernel , Linux Kernel Mailing List , Mark Rutland , "Liang, Kan" References: <20191218162402.45610-1-steven.price@arm.com> <20191218162402.45610-22-steven.price@arm.com> From: Steven Price Message-ID: Date: Mon, 17 Feb 2020 10:01:00 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/02/2020 16:25, Ard Biesheuvel wrote: > On Wed, 18 Dec 2019 at 17:25, Steven Price wrote: >> >> Now walk_page_range() can walk kernel page tables, we can switch the >> arm64 ptdump code over to using it, simplifying the code. >> >> Reviewed-by: Catalin Marinas >> Signed-off-by: Steven Price > > I did not realize this at the time, but this patch removes the ability > to dump the EFI page tables on 32-bit ARM. Was that intentional? No that wasn't intentional, but I can't instantly see how this change affects 32-bit ARM. >> diff --git a/drivers/firmware/efi/arm-runtime.c b/drivers/firmware/efi/arm-runtime.c >> index 899b803842bb..9dda2602c862 100644 >> --- a/drivers/firmware/efi/arm-runtime.c >> +++ b/drivers/firmware/efi/arm-runtime.c >> @@ -27,7 +27,7 @@ >> >> extern u64 efi_system_table; >> >> -#ifdef CONFIG_ARM64_PTDUMP_DEBUGFS >> +#if defined(CONFIG_PTDUMP_DEBUGFS) && defined(CONFIG_ARM64) The previous define was *ARM64* so should never have been true when building for arm. The new condition should be equivalent (arm64 && ptdump enabled). Am I missing something? Steve