From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752636AbeE0WmS (ORCPT ); Sun, 27 May 2018 18:42:18 -0400 Received: from smtp-proxy002.phy.lolipop.jp ([157.7.104.43]:58561 "EHLO smtp-proxy002.phy.lolipop.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751420AbeE0WmR (ORCPT ); Sun, 27 May 2018 18:42:17 -0400 Subject: Re: [PATCH][next] ALSA: xen-front: remove redundant error check on ret To: Colin King , Oleksandr Andrushchenko , Jaroslav Kysela , Takashi Iwai , xen-devel@lists.xenproject.org, alsa-devel@alsa-project.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180527212312.23997-1-colin.king@canonical.com> From: Takashi Sakamoto Message-ID: Date: Mon, 28 May 2018 07:42:12 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180527212312.23997-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On May 28 2018 06:23, Colin King wrote: > From: Colin Ian King > > The error for a -ve value in ret is redundant as all previous > assignments to ret have an associated -ve check and hence it > is impossible for ret to be less that zero at the point of the > check. Remove this redundant error check. > > Detected by CoveritScan, CID#1469407 ("Logically Dead code") > > Signed-off-by: Colin Ian King > --- > sound/xen/xen_snd_front_evtchnl.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/sound/xen/xen_snd_front_evtchnl.c b/sound/xen/xen_snd_front_evtchnl.c > index d70a62e7f910..102d6e096cc8 100644 > --- a/sound/xen/xen_snd_front_evtchnl.c > +++ b/sound/xen/xen_snd_front_evtchnl.c > @@ -351,8 +351,6 @@ int xen_snd_front_evtchnl_create_all(struct xen_snd_front_info *front_info, > } > } > } > - if (ret < 0) > - goto fail; > > front_info->num_evt_pairs = num_streams; > return 0; Yep. All branches for error path on the nested for loop have goto statement, thus no need to check error outer the loop. Reviewed-by: Takashi Sakamoto Takashi Sakamoto