From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EB4938D69C for ; Tue, 10 Mar 2026 14:09:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773151757; cv=none; b=PiU06zsx305zrxkz5EDKDD5/Qu8u+2e1WaMgA4hRJZkTR31BDYQg77TYFeSseJ1dGHv2vBRVEpqSt6x3Hs1tBkAHNttEt+kfyHRLhCKsB06q9527dnNJJ8p1DV5GFUiGzKThm5we5jiwDBpt0RuWs8SNojsKKGYoC7Xw2BuLUpw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773151757; c=relaxed/simple; bh=W2xN/mCb9NR3m8rj+NKaCGBJXePsMRnw221cQuOXCnU=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=pPG4YCjH+AR6Zqodq0mNkDGrY19TK3LzGBbME3A1QBf6Z1nUjzRmiVhjxSwWvtP0jJjT9tUtW3sJIOW4zRpxUX8hYabTCKFL/H3c8GdWkvCSzWWVHYg+yCUo3WskjK8YaSfSudyYODfuELFxkSl33KAzBLux2tnWY25u8+8r3HQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=d1G9KnS0; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="d1G9KnS0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773151755; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UGaoul3yuJqynOQk2erX7A5QGgPE1g4T37mrg0FVrlk=; b=d1G9KnS0kYQUE87AIHQ9+36+9Vf4JVWOou3/BKjg2ipFoCaNpZxLlrYwGI841LyR1+155A DTW1B1OdN1EvypIjJFMaMe/SdzNpq3TdlN2xU1z892PmTjVD5WcuCO0ZJGC/Tf+ZIFdLP/ 29A2wnv7MiNMswCttTobSC9vxV1Mves= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-345-m5o7F6riMXeKGzQ5SQSztg-1; Tue, 10 Mar 2026 10:09:13 -0400 X-MC-Unique: m5o7F6riMXeKGzQ5SQSztg-1 X-Mimecast-MFC-AGG-ID: m5o7F6riMXeKGzQ5SQSztg_1773151747 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4D3F51956095; Tue, 10 Mar 2026 14:09:07 +0000 (UTC) Received: from [10.22.89.94] (unknown [10.22.89.94]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id CD8D61800576; Tue, 10 Mar 2026 14:09:04 +0000 (UTC) Message-ID: Date: Tue, 10 Mar 2026 10:09:04 -0400 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftest: memcg: Skp memcg_sock test if address family not supported From: Waiman Long To: =?UTF-8?Q?Michal_Koutn=C3=BD?= Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Tejun Heo , Shuah Khan , Mike Rapoport , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org References: <20260309160205.651754-1-longman@redhat.com> <4ddd3jascnb6nt7quhyjfmsgsmtfmjofwmnrgjktz57cfbfymj@6ejbdgbg4lz2> <38c7a9a2-a8f1-4ae2-9070-73d0ebb42f53@redhat.com> Content-Language: en-US In-Reply-To: <38c7a9a2-a8f1-4ae2-9070-73d0ebb42f53@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 On 3/9/26 8:04 PM, Waiman Long wrote: > On 3/9/26 2:07 PM, Michal Koutný wrote: >> On Mon, Mar 09, 2026 at 12:02:05PM -0400, Waiman Long >> wrote: >>> On systems where IPv6 isn't enabled or not configured to support >>> SOCK_STREAM, the test_memcg_sock test always fails. >> I think IPv6 is not substantial for the check... > I mentioned it because the current code is using AF_INET6 family. >> >>> The purpose of the test_memcg_sock test is to verify that >>> memory.stat.sock and memory.current values are close. >> ... so this should work with IPv4 too. > Probably, I will try that out. On my test system, creating a socket with IPv4 does work. However, with IPv4, the memcg_sock test becomes unstable and it fails half of the times as the memory values aren't close enough. It is possible that the assumption that memory values should be close aren't quite true with IPv4. As I am not familiar with the networking code at all, I will let others who have more experience with the networking side to try that out. Cheers, Longman