From: Abel Wu <wuyun.abel@bytedance.com>
To: Martin KaFai Lau <martin.lau@linux.dev>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Eduard Zingerman <eddyz87@gmail.com>, Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>, David Vernet <void@manifault.com>,
"open list:BPF [STORAGE & CGROUPS]" <bpf@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: Re: [PATCH bpf v2] bpf: Fix deadlock when freeing cgroup storage
Date: Wed, 29 Jan 2025 14:23:42 +0800 [thread overview]
Message-ID: <ee5da323-0ad8-4b74-971a-ffbd3eb2b61b@bytedance.com> (raw)
In-Reply-To: <3c153542-079a-4566-9f32-8335bbb0456a@linux.dev>
On 1/28/25 7:05 AM, Martin KaFai Lau Wrote:
> On 1/27/25 2:15 PM, Alexei Starovoitov wrote:
>> On Sun, Jan 26, 2025 at 1:31 AM Abel Wu <wuyun.abel@bytedance.com> wrote:
>>>
>>> On 1/25/25 4:20 AM, Martin KaFai Lau Wrote:
>>>>
>>>> imo, that should be a better option instead of having more unnecessary failures in all other normal use cases which will not be interested in tracing cgroup_storage_ptr().
>>
>> Martin,
>>
>> task_storage_map_free() is doing this busy inc/dec already,
>> in that sense doing the same in cgroup_storage_map_free() fits.
>
> sgtm. Agree to be consistent with the task_storage_map_free.
>
> would be nice if the busy inc/dec usage can be revisited after the rqspinlock work.
Agree, and 1ms interval of deadlock dection seems acceptable
for most workloads.
>
> Acked-by: Martin KaFai Lau <martin.lau@kernel.org>
Thanks Alexei, Martin.
next prev parent reply other threads:[~2025-01-29 6:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-21 6:10 Abel Wu
2025-01-23 18:01 ` Abel Wu
2025-01-24 20:20 ` Martin KaFai Lau
2025-01-26 9:31 ` Abel Wu
2025-01-27 22:15 ` Alexei Starovoitov
2025-01-27 23:05 ` Martin KaFai Lau
2025-01-29 6:23 ` Abel Wu [this message]
2025-01-30 2:40 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee5da323-0ad8-4b74-971a-ffbd3eb2b61b@bytedance.com \
--to=wuyun.abel@bytedance.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=void@manifault.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®