From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Heiko Stuebner <heiko@sntech.de>,
Sebastian Reichel <sebastian.reichel@collabora.com>,
Sugar Zhang <sugar.zhang@rock-chips.com>,
Shreeya Patel <shreeya.patel@collabora.com>,
Kever Yang <kever.yang@rock-chips.com>,
Johan Jonker <jbx6244@gmail.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, kernel@collabora.com
Subject: Re: [PATCH v3 1/3] dt-bindings: timer: rockchip: Drop superfluous rk3288 compatible
Date: Fri, 21 Apr 2023 09:23:53 +0200 [thread overview]
Message-ID: <ee5e2621-36db-864d-bdde-885232381a23@linaro.org> (raw)
In-Reply-To: <20230419181309.338354-2-cristian.ciocaltea@collabora.com>
On 19/04/2023 20:13, Cristian Ciocaltea wrote:
> The compatible string for Rockchip RK3288 is wrongly provided in the
> 'enum' item, in addition to the subsequent 'const', which allows the
> usage of an incorrect specification:
>
> compatible = "rockchip,rk3288-timer", "rockchip,rk3288-timer";
>
> As the rk3288 string is also specified in the top-most 'const' item, the
> binding already allows the usage of the correct variant:
>
> compatible = "rockchip,rk3288-timer";
>
> Drop the unwanted rk3288 entry from the enum.
>
> Fixes: faa186adbd06 ("dt-bindings: timer: convert rockchip,rk-timer.txt to YAML")
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> ---
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-04-21 7:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-19 18:13 [PATCH v3 0/3] Enable rk3588 timer support Cristian Ciocaltea
2023-04-19 18:13 ` [PATCH v3 1/3] dt-bindings: timer: rockchip: Drop superfluous rk3288 compatible Cristian Ciocaltea
2023-04-21 7:23 ` Krzysztof Kozlowski [this message]
2023-04-26 9:12 ` [tip: timers/core] " tip-bot2 for Cristian Ciocaltea
2023-04-19 18:13 ` [PATCH v3 2/3] dt-bindings: timer: rockchip: Add rk3588 compatible Cristian Ciocaltea
2023-04-26 9:12 ` [tip: timers/core] " tip-bot2 for Cristian Ciocaltea
2023-04-19 18:13 ` [PATCH v3 3/3] arm64: dts: rockchip: Add rk3588 timer Cristian Ciocaltea
2023-04-22 13:17 ` [PATCH v3 0/3] Enable rk3588 timer support Vincent Legoll
2023-04-22 15:15 ` Cristian Ciocaltea
2023-04-22 15:42 ` Vincent Legoll
2023-04-26 10:57 ` (subset) " Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee5e2621-36db-864d-bdde-885232381a23@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=cristian.ciocaltea@collabora.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=kernel@collabora.com \
--cc=kever.yang@rock-chips.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=shreeya.patel@collabora.com \
--cc=sugar.zhang@rock-chips.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®