From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751430AbcGNFzn (ORCPT ); Thu, 14 Jul 2016 01:55:43 -0400 Received: from mail.kmu-office.ch ([178.209.48.109]:41497 "EHLO mail.kmu-office.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751239AbcGNFze (ORCPT ); Thu, 14 Jul 2016 01:55:34 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Date: Wed, 13 Jul 2016 22:50:59 -0700 From: Stefan Agner To: Peter Chen Cc: airlied@linux.ie, alison.wang@freescale.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] gpn: drm: fsl_tcon: add missing of_node_put after calling of_parse_phandle In-Reply-To: <1467618040-13799-1-git-send-email-peter.chen@nxp.com> References: <1467618040-13799-1-git-send-email-peter.chen@nxp.com> Message-ID: User-Agent: Roundcube Webmail/1.1.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016-07-04 00:40, Peter Chen wrote: > of_node_put needs to be called when the device node which is got > from of_parse_phandle has finished using, but current code only > calls it at error path, fix it by adding it at correct code path. > > Signed-off-by: Peter Chen > --- > drivers/gpu/drm/fsl-dcu/fsl_tcon.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/fsl-dcu/fsl_tcon.c > b/drivers/gpu/drm/fsl-dcu/fsl_tcon.c > index bbe34f1..bca09ea 100644 > --- a/drivers/gpu/drm/fsl-dcu/fsl_tcon.c > +++ b/drivers/gpu/drm/fsl-dcu/fsl_tcon.c > @@ -92,6 +92,7 @@ struct fsl_tcon *fsl_tcon_init(struct device *dev) > goto err_node_put; > } > > + of_node_put(np); > clk_prepare_enable(tcon->ipg_clk); > > dev_info(dev, "Using TCON in bypass mode\n"); Thanks, applied! Changed subject prefix using the usual drm/fsl-dcu:... -- Stefan