From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D03738A70E for ; Fri, 13 Mar 2026 10:49:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773398948; cv=none; b=FKebPYbVrM/682AsY+gboXpVCJ4rqZi5DpKDi+vkd0rmPV/jQVcYPCV3mK3e1C8hEO32UU71WD9S3PDmavRXGHSEQUDHCU1mdIuJ/2oNoQfrRN11L8sVXuNlXhCLnijFAJliYd+Ls6quONs3g41W18JarKUnmQo9R7iPoY1WmQo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773398948; c=relaxed/simple; bh=Agre3Y8P3IDaF9CWixWn/xANIAYfGnHVHaNptVWalTI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iSlVURUkiOb2JmMYeHVDBpvjVE4/JKTS0i5Dr7Os7VPNMf5qMqGaJvfJhZKCY0XotO8S1vdyc1N6fIUFiPdv/tccRkRLVd1Ii3vWoRnDPzEEG0NbnSmSHZ58eeGQNBsjfMPLUlNe0BkI1rwvt0uKuyXyfEU8vRAkSDch8sv7UcQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=aDwq3eRF; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="aDwq3eRF" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-439b83ed536so217636f8f.0 for ; Fri, 13 Mar 2026 03:49:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1773398945; x=1774003745; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1cPR5UV5gMB4vPUF63r9dMyw5kiO5cbwJmX7MZrCuJo=; b=aDwq3eRFapF+zUKeUqwBmtloyZX6n1cDiI+iCxU4/glEpqQMKzOGD8hOxoaGko+pWE Wreduq+Xi3l7lqmR1GoJmOYdEw2FLNYniMjs8bBcueBon84QdcQB/yxqto832IlOJyew YU5iJ+zHghGxpKQoK9pSWLYFb1hg04SB+IX6xuvFM7f/ZHe1iqjZ7dU0WqFqAcVrK9eI TGfLJSkV24WVRBfyPTzIMpXAsyzSQGmdVgPD9ZNdz/LOPVUaZ3XwJ4C/ejSTP2B2lwa1 +8kzGWxDgpqZHuQFwoBubnNaxKx9vDtvahpDAipveVvzRIcD8aJ/fg9Km247rj2s9umz M8+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773398945; x=1774003745; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1cPR5UV5gMB4vPUF63r9dMyw5kiO5cbwJmX7MZrCuJo=; b=fD3GveTXs5KMmfGzMe/nwwatAgrGrJPZyy3RZQ/v7q/yjrIbBg6ai0GnxdT2Jvuhjn inZUqJ6BjVqanrJuK6MDxyhjaSCjgcotSKx8b/W1/oSfwlT0VUqj0j4u49h7xHOTUmfY D0QpgY/49hdPU0KJS/pMj6lHPvgRXtdltyOSoBRPg2ACxVNueIObtthDjx3n9gX1jLU3 W7R1oKatPhG6BfNWOPON1LtTUR25Z1P57EgNYfzqt9kSe48WSByO90A0B+QOhwiOh55T mp+RC8JYUu+MGM8b4MSv/UL7nVPSWsGtoZ8B4VXmKwWiM/iKRsTbo2p9MaLshbP3Apsk ccfw== X-Forwarded-Encrypted: i=1; AJvYcCVQd3m0J6WcG7QVPqzwH5A84l2Tz2u+AiSMO3lVRIbKvlyTRihqU7RzB7pdagUk9257Kq/nBuPlbAge6Mc=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/qpjWXtVQdsFObzCc/2BJFckFrO58Qb56ZGpshIgk7ROqkHyG KGB6wVUIasVTCn1JmSZptpmVe/zASgctmbIDU8VpyYqrEaNBGYQGWiNOa5W2FHxpNu0= X-Gm-Gg: ATEYQzx/VuPWVra6/wSQVQmTNNCBVElh5m5IjHp1OrYkZCHKsEZ2f8PvptzzfsEiDL8 fiPdU3UIhRucxXuvCJeTezo7jnyfaRQfkkFEcGD9WlHLPwm1/6rpSqZxnFZN8FJgMYuRvax18k6 Li/UfxdaA34M/p9LaDCtxfAU7NUeCnXn+T0QPVD9R05vhtIR+z0R9ra3fmrkYUX+2toeHJy54Z6 2yCPUxAtYRGrCRVCkA0hzRTXkTVBvRHmkhfxEuHXqifVz5t3iyvdYZs6lUDw5P2Mb0hWn9XW+bn k74XEQ2k1smJUKlkDDBakjc6yuZKFiCz+/6kVC04/9e7kcZWnFyMsi+DBsepCMYAMwEuA1NJ47Z 8lUBsX8Mza1/5LF5dq4D0BH2pJdWPnhEuSi9gHUkD9a0QW9sA97Oj7d8/btXHTXziu5XfdUztSb RpyKmKyAsvTPCjHaK7gyTrZS33NgGipaVs76rL4CCBVIhRNLPRZuKTWxwqNw== X-Received: by 2002:a05:6000:250c:b0:439:fbf7:dc7 with SMTP id ffacd0b85a97d-43a04de0c8cmr2651763f8f.5.1773398944720; Fri, 13 Mar 2026 03:49:04 -0700 (PDT) Received: from ?IPV6:2001:1a48:8:903:1ed6:4f73:ce38:f9d4? ([2001:1a48:8:903:1ed6:4f73:ce38:f9d4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439fe20bd9csm16539212f8f.21.2026.03.13.03.49.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Mar 2026 03:49:04 -0700 (PDT) Message-ID: Date: Fri, 13 Mar 2026 11:49:03 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] MAINTAINERS: add Josh Law as reviewer for library code Content-Language: en-US To: "Lorenzo Stoakes (Oracle)" , Josh Law Cc: Andrew Morton , linux-kernel@vger.kernel.org, Josh Law References: <20260307221931.2848601-1-objecting@objecting.org> <3cd25de5-3737-49f4-aa8b-eaaee471af50@lucifer.local> From: Vlastimil Babka In-Reply-To: <3cd25de5-3737-49f4-aa8b-eaaee471af50@lucifer.local> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/13/26 11:17, Lorenzo Stoakes (Oracle) wrote: > On Sat, Mar 07, 2026 at 10:19:31PM +0000, Josh Law wrote: >> Add myself as a designated reviewer for the library code to help review >> incoming patches and improvements. >> >> Signed-off-by: Josh Law > > Sorry but NAK, I appreciate your enthusiasm but this is literally _all_ > library code, and you don't have a long track history in the kernel. Agreed, just a week after first appearance on lists is really quite too soon. Yes, getting Cc'd thanks to R: entry is one thing, but that can be achieved with lei as well. The other aspect of R: is giving weigh in replies to (potentially new) contributors and that's why it's not given out rather that quickly. > Also in [0], [1], etc. you aren't demonstrating a great deal of maturity, > so I don't think it's appropriate for you to be added at this time. > > I really don't think a 'catch all' category should be getting arbitrary > extra reviewers in any case. Agreed. Many of the files under lib/ are listed in other sections with their own maintainers. They were not cc'd on this MAINTAINERS update and yet it would affect all patches to their files too, so they could at least have a say. It's unfortunate that it's how this catch-all works. Maybe X: entries could be used by the specific maintainers in the catch-all section, although it's somewhat tedious. > Please take some time to contribute to the kernel, establish yourself, and > then look to reviewership for a specific category. +1 I hope this doesn't discourage you, it's nothing personal. Thanks, Vlastimil > Thanks, Lorenzo > >> --- >> MAINTAINERS | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 96e97d25e1c2..8fd03ab9c657 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -14613,6 +14613,7 @@ F: tools/testing/nvdimm/ >> >> LIBRARY CODE >> M: Andrew Morton >> +R: Josh Law >> L: linux-kernel@vger.kernel.org >> S: Supported >> T: git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-nonmm-unstable >> -- >> 2.43.0 >> >> > > [0]:https://lore.kernel.org/all/c41dbb9d-b8a5-4b5f-9f71-3fe1bed210b6@gmail.com/ > [1]:https://lore.kernel.org/linux-mm/40767ecf-7e25-48f5-a604-c43b835b6b66@gmail.com/ >