From: Wilfred Mallawa <wilfred.opensource@gmail.com>
To: Gerd Bayer <gbayer@linux.ibm.com>,
Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>
Cc: Niklas Schnelle <schnelle@linux.ibm.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] nvme-pci: Add debug message on fail to read CSTS
Date: Wed, 22 Oct 2025 16:24:45 +1000 [thread overview]
Message-ID: <ee6739203c5dbd7452541a3915636b597b34848f.camel@gmail.com> (raw)
In-Reply-To: <20251020-nvme_probefail-v1-2-a420046d98f0@linux.ibm.com>
On Mon, 2025-10-20 at 17:29 +0200, Gerd Bayer wrote:
> Add a debug log spelling out that reading the CSTS register failed -
> to
> distinguish this from other reasons for ENODEV.
>
> Signed-off-by: Gerd Bayer <gbayer@linux.ibm.com>
> ---
> drivers/nvme/host/pci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index
> 7544c4bac2c4a230d32cf729abb9e94bf93a921f..c3b0a9d56ac1f32f67ce0890bec
> d6425eb80ebad 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -2906,6 +2906,7 @@ static int nvme_pci_enable(struct nvme_dev
> *dev)
> pci_set_master(pdev);
>
> if (readl(dev->bar + NVME_REG_CSTS) == -1) {
> + dev_dbg(dev->ctrl.device, "Read CSTS register
> failed");
> result = -ENODEV;
> goto disable;
> }
Reviewed-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
Wilfred
next prev parent reply other threads:[~2025-10-22 6:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 15:29 [PATCH 0/2] nvme-pci: Log failures to probe Gerd Bayer
2025-10-20 15:29 ` [PATCH 1/2] nvme-pci: Print error message on failure in nvme_probe Gerd Bayer
2025-10-22 6:22 ` Wilfred Mallawa
2025-10-22 6:26 ` Christoph Hellwig
2025-10-22 7:48 ` Greg Kroah-Hartman
2025-10-22 8:20 ` Gerd Bayer
2025-10-20 15:29 ` [PATCH 2/2] nvme-pci: Add debug message on fail to read CSTS Gerd Bayer
2025-10-20 23:34 ` Chaitanya Kulkarni
2025-10-22 6:24 ` Wilfred Mallawa [this message]
2025-10-22 6:27 ` Christoph Hellwig
2025-10-22 8:21 ` Gerd Bayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee6739203c5dbd7452541a3915636b597b34848f.camel@gmail.com \
--to=wilfred.opensource@gmail.com \
--cc=axboe@kernel.dk \
--cc=gbayer@linux.ibm.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=schnelle@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®