From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BA9B331A61 for ; Mon, 13 Jul 2026 16:56:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783961808; cv=none; b=tuo6FfvkwUluQ8uWyZCHbXKPuKmSbMQ0uiz03uN99OT4+SK5HF5eoVD4z/yX4IsvEw1oDXYIROnan62Dq2ZVUgrvZsBu5xxJCJ3KICaojBmUuZ+XveJZVtxRLZmmcUdUbhfAFItDAMUXL0xG2+iYtf46aiewKkhzKBr9oTnYURY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783961808; c=relaxed/simple; bh=f1dENWIJHys20RMrMzjKwGdXIMauPk3ExXn/7QJeIaI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AEZMhmf8d3VVivYawzhkl8KI1YZ+cC+88hywF5oO+39GvoiaFjI91ErOx/gPqPhWyOAzm2QWK0JQM0Bu0JGQnRRbNj+w7K2QJjc279lg11iKEQ9rLbs25+LTvbme4jU87H7hCsh10l9jpTgMN2xXjijONSZyyJqtxA9ZDfnfCCI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CXHyQvkf; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=iq0E6/4b; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CXHyQvkf"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="iq0E6/4b" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66DF8JZF1860706 for ; Mon, 13 Jul 2026 16:56:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= t1BTK6gFt2giEtwJiw2DRM0UmiGtqToj6SdQoef7PZc=; b=CXHyQvkfz6bBl2Pt uw8jCZ2dmva3aRyVyYaavB3xthMwVC+62Hs27bbn16wmR+usqY/AS4Akse1extmb BA+4dlU8aZ2pU7ysSkVBXodzjx3ypvPO+wsHnLvkrAl3atXYovjpzGti0bNLIYhk 5jhnxN/s5vy7hu97jXSw4cxI7JSUw1Rp9XF5ZPd3dN0EdwQwSrjfOfsrn8SD86JN IiXu/gR8G5T0KOsRx0NLI+0oOqmJb9x7ceJRk9y/CN1+TkD5Rh0VfHUJmGnXopsV 4MR/BYUd/q9+FyiuM6pTdooxQ/pHH+njA9+uzprlOJKXi1kKHVys9mTsvQnVrV/m M4Thqg== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fcuj02anu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 13 Jul 2026 16:56:45 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-380b630c505so4113427a91.1 for ; Mon, 13 Jul 2026 09:56:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783961805; x=1784566605; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=t1BTK6gFt2giEtwJiw2DRM0UmiGtqToj6SdQoef7PZc=; b=iq0E6/4bybjNgq3CiQTP75vusHPq0bpT54n4AQVFocFkLj+Znvcuqrsn1FuPLX1sFH 2kVM4MjVhSHFmePdxgJ/pCAHsq3NpCtgTE4fW9u7SE/8L29ev9ttMItN9Z91mwehHPRQ LoPdcFwcA0XEu+PbaMFMOKn1CdPvnexLcOwmnJCUSQF1ukkXIR5MDVv3kEdcXXn6/25F jEVl6tw+2yrnke83XDOHh9A6KjdSvc5T0t5HhfU2w8tJZJ4EvOzywLOEU2k/k3Csx37s k2Yw57sygD77of6VPePQgynFpiK38HKcHacjbY/esTjOkiH1t/VhdAc+P3f1efvVDZu+ oatA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783961805; x=1784566605; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=t1BTK6gFt2giEtwJiw2DRM0UmiGtqToj6SdQoef7PZc=; b=fIH+dVH0T2K+wZy7qQ3cA4f8vhvCgJ8CdE04x1CkGeYJWqsINRpCby+1wvQwSyHurv 8LNy8y14hfwoEG+ihy5Wq0Xo3ZEKR2zLCDUMZAjKEGh9ztNZOnC0AXM/wCzTpUy2BJ97 MmbR+MpmD+Sdpqez2zh33fa0fV0L0OkiUz9JxAkOvzdqnJN2qb1nAouBmnVurdve6gu9 xZYmpOF2LlAfPV1/MjzZNLPayrtsCseypKpgNkBApg0SWd9defScxus3Pvodi7VhcKd6 DLWwHCwAfLmWBbFDW6GoApS+PCIxdClLl1zZdblcVYFLomxTP5Q5KR4wWIZa8ZNh5Eam 08Ng== X-Forwarded-Encrypted: i=1; AHgh+Rrmbw8FxTw0IBZGqOOinrFy0Ls5UikdhZP3vPK1NaQJEGVvwHw7UYX1jKbehfiOwhDvQYJFxpOKUExEhCQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yzl4xUd6CniHyVDoadDC722luco37g7cr5TVIugkLvK5gJk8mrg d4hpsyROvI1pHSYBjpWD6xIIw7xiwks63LZ9ekmvxwwNajQByf1JK0Q2eov+Yw1Hv8tvsxscNbC xbLzhUSNKJZmlmDICPKrUiIyJwZcACo0gVV9kkg2E5TRX7p2gj9rLEoChGYnUUsxpq0U= X-Gm-Gg: AfdE7cnE8p0eCs8UyRbKV6JMeCG3MMaBale3ozaywHpWPjvG9ndVMkLRSC3IDOyzCnn c27+98cfTPGLq8QC12CSqeDIgKw1fVLkiQXW2VgylBSil1sSCmnigsUQcG0rvdrNiyzYZxDFxnc vO1P4picIu1Q7OnN/edKV0liBuVMKwDH/s8Tt/VF0wq86SI+fEKa0RJ2o3XFxS+ehHgTIe2ECer RhHz8xJy+QXL/Ch01333eKbcUVXwgTxmlSK1ti+ubCbJxw8sWPnIDLg9h/NammDV//h7YxEJiVl VJHo7CenbISxtETl67aF2bz2AvftzzAYfozR7ASzESJnH16AG0+wi9/cn99iYm9vC2vbEq24BFT KIKt7n29duAvkfCzeTLSX1bvAPet9QOJhVblXGYaj5Dm/7g== X-Received: by 2002:a17:90b:2802:b0:37f:9ce1:7364 with SMTP id 98e67ed59e1d1-38dc774cf00mr9949889a91.26.1783961804617; Mon, 13 Jul 2026 09:56:44 -0700 (PDT) X-Received: by 2002:a17:90b:2802:b0:37f:9ce1:7364 with SMTP id 98e67ed59e1d1-38dc774cf00mr9949860a91.26.1783961804152; Mon, 13 Jul 2026 09:56:44 -0700 (PDT) Received: from [192.168.1.100] ([157.48.180.168]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31174ac14f2sm76694721eec.27.2026.07.13.09.56.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jul 2026 09:56:43 -0700 (PDT) Message-ID: Date: Mon, 13 Jul 2026 22:26:36 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/3] thermal: qcom: add support for PMIC5 Gen3 ADC thermal monitoring To: Daniel Lezcano , Jonathan Cameron , David Lechner , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Amit Kucheria , Thara Gopinath , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba Cc: linux-arm-msm@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Kamal Wadhwa , David Collins , Anjelique Melendez , Neil Armstrong , Stephan Gerhold References: <20260705-gen3_adc_tm-v3-0-ac62f387dbce@oss.qualcomm.com> <20260705-gen3_adc_tm-v3-3-ac62f387dbce@oss.qualcomm.com> Content-Language: en-US From: Jishnu Prakash In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEzMDE3NSBTYWx0ZWRfX8a1t3qNtddeD 74QxUJQef//JNmYAfrqOH/nvFdNhWXqjxSZSSfKNGvFupVqpNz7WIAjn+4sD0mk21oaxYzwrcB5 bxs8Ku8uW9KPTa4BFY9bsZmipuGqFDA= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEzMDE3NSBTYWx0ZWRfX2SYJsGy/QcXx P3klkbnCHhm3vnQUk0H4kNT9wPftko6I7hicMByA2r6V7o6kYnShW86h9Jur5FdKR+/CDpE3Ejt KiOIDNb38XFwFvKEW3bm64K+IQXlrh8PEini+bH03vw8D8lKkPD+B46cyfq5EA5KTCcbhKCCHHa wxW9ei/tiZO1dtV3A2tGB5X2XqBA9rVoULJS8r3DKmfuXpcfLy4qao/rnPJuwvPUODW2+97eI7g ZeRHPnS1QvUgjM30iPbGrFjApc9xyVtyI0uVIRTjF+6biy7DY7nO3GZWOK5ivsd7RlLCRAgOlGP 004IdR1KlnROHA+faFUtlg+udmDOSgTdJni5kqpG3Ei4h4/6sRvoK72iOsX1hL7FMILAv7EuRpe DwuQdx8lvFqIjam9rmo5lBTZDpa+m4EEPLMf/D9qiQgoQslEgdXVyAtnOWaHeZ2Xxwrh6pjX8+m TGDDVfizR40tsKqTgKw== X-Proofpoint-ORIG-GUID: GKOFe6WSGpI30tfEx30_cLnVkLDhL4kL X-Authority-Analysis: v=2.4 cv=DbcnbPtW c=1 sm=1 tr=0 ts=6a5518cd cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=62VzjLAzdHZQ3L95IMgkXw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=ZJtfdnNEmsHLE5vD43oA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-GUID: GKOFe6WSGpI30tfEx30_cLnVkLDhL4kL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-13_04,2026-07-10_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 malwarescore=0 priorityscore=1501 phishscore=0 suspectscore=0 bulkscore=0 adultscore=0 spamscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607130175 Hi Daniel, On 7/10/2026 12:38 PM, Daniel Lezcano wrote: > > Hi Jishnu, > > On 7/5/26 18:53, Jishnu Prakash wrote: >> Add support for ADC_TM part of PMIC5 Gen3. >> >> This is an auxiliary driver under the Gen3 ADC driver, which implements the >> threshold setting and interrupt generating functionalities of QCOM ADC_TM >> drivers, used to support thermal trip points. >> >> Signed-off-by: Jishnu Prakash > > Overall the driver LGTM but as you are sending a new version to take into account Andy's and Jonathan's comments, please take the opportunity to document a bit more the code and the changelog regarding the hardware (eg. register layout) > Sure, I'll add a paragraph or two in the commit message to give some more details about the driver and how the HW implementation changed from the previous ADC generation. Thanks, Jishnu > Thanks > >   -- Daniel > >> --- >>   drivers/thermal/qcom/Kconfig                  |   9 + >>   drivers/thermal/qcom/Makefile                 |   1 + >>   drivers/thermal/qcom/qcom-spmi-adc-tm5-gen3.c | 425 ++++++++++++++++++++++++++ >>   3 files changed, 435 insertions(+) >> >> diff --git a/drivers/thermal/qcom/Kconfig b/drivers/thermal/qcom/Kconfig >> index a6bb01082ec6..1acb11e4ac80 100644 >> --- a/drivers/thermal/qcom/Kconfig >> +++ b/drivers/thermal/qcom/Kconfig