From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752765AbdBAQgF (ORCPT ); Wed, 1 Feb 2017 11:36:05 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:35862 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751157AbdBAQgE (ORCPT ); Wed, 1 Feb 2017 11:36:04 -0500 Subject: Re: [PATCH v2] staging: rtl8188eu: remove not necessary braces {} (checkpatch fix) To: Joe Perches , gregkh@linuxfoundation.org References: <20170128084910.7975-1-martinowar@gmail.com> <20170131192456.1221-1-martinowar@gmail.com> <1485902368.20550.37.camel@perches.com> Cc: Larry.Finger@lwfinger.net, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: Martin Karamihov Message-ID: Date: Wed, 1 Feb 2017 18:36:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1485902368.20550.37.camel@perches.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/01/2017 12:39 AM, Joe Perches wrote: > On Tue, 2017-01-31 at 21:24 +0200, Martin Karamihov wrote: >> This is checkpatch fix for hal/bb_cfg.c file: >> remove not necessary braces {} >> >> Signed-off-by: Martin Karamihov >> --- >> drivers/staging/rtl8188eu/hal/bb_cfg.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/drivers/staging/rtl8188eu/hal/bb_cfg.c b/drivers/staging/rtl8188eu/hal/bb_cfg.c >> index 134fa6c595a8..26e0ef224299 100644 >> --- a/drivers/staging/rtl8188eu/hal/bb_cfg.c >> +++ b/drivers/staging/rtl8188eu/hal/bb_cfg.c >> @@ -534,9 +534,8 @@ static void store_pwrindex_offset(struct adapter *adapter, >> power_level_offset[11] = data; >> if (regaddr == rTxAGC_B_Mcs11_Mcs08) >> power_level_offset[12] = data; >> - if (regaddr == rTxAGC_B_Mcs15_Mcs12) { >> + if (regaddr == rTxAGC_B_Mcs15_Mcs12) >> power_level_offset[13] = data; >> - } > presumably, this and the regaddr block above it > should be an else if or a switch/case. > > I will prepare the patch if this code modification is needed right now. Is it?