From: Richard Ruigrok <rruigrok@codeaurora.org>
To: ge.song@hxt-semitech.com, ard.biesheuvel@linaro.org,
matt@codeblueprint.co.uk
Cc: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org
Subject: BUG: EFI capsule loader fails as of 4.13, the capsule is not passed in contiguous virtual memory
Date: Thu, 21 Dec 2017 14:42:43 -0700 [thread overview]
Message-ID: <ee80aa6b-ceac-f410-0718-c998f9c66181@codeaurora.org> (raw)
The capsule pointer passed to efi services are expected to be in contiguous virtual memory, as per the EFI 2.6 Spec section 7.5.3, excerpt below.
This issue was previously reported and fixed in 4.9 stable: 6862e6ad95e9 efi/capsule: Allocate whole capsule into virtual memory
The series "First batch of EFI updates for v4.13" includes changes that break the efi loader as it is now passing only the first physical page of the EFI capsule. As a result efi capsule updates are failing on Centriq products.
The series by Ge Song "Make capsules in a contiguous virtual space" was verified to work.
Ref to the spec:
"CapsuleHeaderArrayVirtual pointer to an array of virtual pointers to the capsules being passed into update capsule. Each capsules is assumed to stored in contiguous virtual memory."
--
Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
reply other threads:[~2017-12-21 21:42 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee80aa6b-ceac-f410-0718-c998f9c66181@codeaurora.org \
--to=rruigrok@codeaurora.org \
--cc=ard.biesheuvel@linaro.org \
--cc=ge.song@hxt-semitech.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®