From: Guenter Roeck <linux@roeck-us.net>
To: eajames.ibm@gmail.com
Cc: devicetree@vger.kernel.org, jdelvare@suse.com, corbet@lwn.net,
linux-doc@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
mark.rutland@arm.com, robh+dt@kernel.org, wsa@the-dreams.de,
andrew@aj.id.au, joel@jms.id.au, benh@kernel.crashing.org,
"Edward A. James" <eajames@us.ibm.com>
Subject: Re: [PATCH linux v2 0/6] drivers: hwmon: Add On-Chip Controller driver
Date: Sun, 15 Jan 2017 10:35:10 -0800 [thread overview]
Message-ID: <ee855470-25fd-b29b-b9fc-5e4dae110cd3@roeck-us.net> (raw)
In-Reply-To: <1484158237-10014-1-git-send-email-eajames.ibm@gmail.com>
On 01/11/2017 10:10 AM, eajames.ibm@gmail.com wrote:
> From: "Edward A. James" <eajames@us.ibm.com>
>
> This patchset adds a hwmon driver to support the OCC (On-Chip Controller)
> on the IBM POWER8 and POWER9 processors, from a BMC (Baseboard Management
> Controller). The OCC is an embedded processor that provides real time
> power and thermal monitoring.
>
> The driver provides an interface on a BMC to poll OCC sensor data, set
> user power caps, and perform some basic OCC error handling. It interfaces
> with userspace through hwmon.
>
> The driver is currently functional only for the OCC on POWER8 chips.
> Communicating with the POWER9 OCC requries FSI support.
>
Overall looks pretty good. There is the 0day hiccup (was that solved ?) and
a few comments I made separately. It might make sense to add someone from IBM
as maintainer.
Thanks,
Guenter
> Edward A. James (6):
> hwmon: Add core On-Chip Controller support for POWER CPUs
> hwmon: occ: Add sysfs interface
> hwmon: occ: Add I2C transport implementation for SCOM operations
> hwmon: occ: Add callbacks for parsing P8 OCC datastructures
> hwmon: occ: Add hwmon implementation for the P8 OCC
> hwmon: occ: Add callbacks for parsing P9 OCC datastructures
>
> Documentation/devicetree/bindings/hwmon/occ.txt | 13 +
> Documentation/hwmon/occ | 114 +++++
> drivers/hwmon/Kconfig | 2 +
> drivers/hwmon/Makefile | 1 +
> drivers/hwmon/occ/Kconfig | 29 ++
> drivers/hwmon/occ/Makefile | 2 +
> drivers/hwmon/occ/occ.c | 533 ++++++++++++++++++++++++
> drivers/hwmon/occ/occ.h | 83 ++++
> drivers/hwmon/occ/occ_p8.c | 254 +++++++++++
> drivers/hwmon/occ/occ_p8.h | 31 ++
> drivers/hwmon/occ/occ_p9.c | 314 ++++++++++++++
> drivers/hwmon/occ/occ_p9.h | 31 ++
> drivers/hwmon/occ/occ_scom_i2c.c | 73 ++++
> drivers/hwmon/occ/occ_scom_i2c.h | 26 ++
> drivers/hwmon/occ/occ_sysfs.c | 274 ++++++++++++
> drivers/hwmon/occ/occ_sysfs.h | 44 ++
> drivers/hwmon/occ/p8_occ_i2c.c | 123 ++++++
> drivers/hwmon/occ/scom.h | 47 +++
> 18 files changed, 1994 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/occ.txt
> create mode 100644 Documentation/hwmon/occ
> create mode 100644 drivers/hwmon/occ/Kconfig
> create mode 100644 drivers/hwmon/occ/Makefile
> create mode 100644 drivers/hwmon/occ/occ.c
> create mode 100644 drivers/hwmon/occ/occ.h
> create mode 100644 drivers/hwmon/occ/occ_p8.c
> create mode 100644 drivers/hwmon/occ/occ_p8.h
> create mode 100644 drivers/hwmon/occ/occ_p9.c
> create mode 100644 drivers/hwmon/occ/occ_p9.h
> create mode 100644 drivers/hwmon/occ/occ_scom_i2c.c
> create mode 100644 drivers/hwmon/occ/occ_scom_i2c.h
> create mode 100644 drivers/hwmon/occ/occ_sysfs.c
> create mode 100644 drivers/hwmon/occ/occ_sysfs.h
> create mode 100644 drivers/hwmon/occ/p8_occ_i2c.c
> create mode 100644 drivers/hwmon/occ/scom.h
>
prev parent reply other threads:[~2017-01-15 18:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-11 18:10 eajames.ibm
2017-01-11 18:10 ` [PATCH linux v2 1/6] hwmon: Add core On-Chip Controller support for POWER CPUs eajames.ibm
2017-01-11 18:10 ` [PATCH linux v2 2/6] hwmon: occ: Add sysfs interface eajames.ibm
2017-01-12 7:39 ` [PATCH] hwmon: occ: fix err_cast.cocci warnings kbuild test robot
2017-01-12 7:39 ` [PATCH linux v2 2/6] hwmon: occ: Add sysfs interface kbuild test robot
2017-01-15 18:18 ` Guenter Roeck
2017-01-11 18:10 ` [PATCH linux v2 3/6] hwmon: occ: Add I2C transport implementation for SCOM operations eajames.ibm
2017-01-11 18:10 ` [PATCH linux v2 4/6] hwmon: occ: Add callbacks for parsing P8 OCC datastructures eajames.ibm
2017-01-11 18:10 ` [PATCH linux v2 5/6] hwmon: occ: Add hwmon implementation for the P8 OCC eajames.ibm
2017-01-15 18:15 ` Guenter Roeck
2017-01-15 18:34 ` Guenter Roeck
2017-01-11 18:10 ` [PATCH linux v2 6/6] hwmon: occ: Add callbacks for parsing P9 OCC datastructures eajames.ibm
2017-01-12 9:56 ` [PATCH linux v2 0/6] drivers: hwmon: Add On-Chip Controller driver Wolfram Sang
2017-01-15 18:35 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee855470-25fd-b29b-b9fc-5e4dae110cd3@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andrew@aj.id.au \
--cc=benh@kernel.crashing.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=eajames.ibm@gmail.com \
--cc=eajames@us.ibm.com \
--cc=jdelvare@suse.com \
--cc=joel@jms.id.au \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®