From: Jon Hunter <jonathanh@nvidia.com>
To: Manikanta Maddireddy <mmaddireddy@nvidia.com>,
bhelgaas@google.com, lpieralisi@kernel.org,
kwilczynski@kernel.org, mani@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
thierry.reding@gmail.com, jingoohan1@gmail.com,
vidyas@nvidia.com, cassel@kernel.org, 18255117159@163.com
Cc: linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [V5,03/13] PCI: tegra194: Don't force the device into the D0 state before L2
Date: Tue, 10 Feb 2026 17:10:56 +0000 [thread overview]
Message-ID: <ee886a80-0093-4c35-9701-427c2e166ca8@nvidia.com> (raw)
In-Reply-To: <20260208180746.2024338-4-mmaddireddy@nvidia.com>
On 08/02/2026 18:07, Manikanta Maddireddy wrote:
> From: Vidya Sagar <vidyas@nvidia.com>
>
> As per PCIe CEM spec rev 4.0 ver 1.0 sec 2.3, the PCIe endpoint device
> should be in D3 state to assert wake# pin. This takes precedence over PCI
> Express Base r4.0 v1.0 September 27-2017, 5.2 Link State Power Management
> which states that the device can be put into D0 state before taking the
> link to L2 state. So, to enable the wake functionality for endpoints, do
> not force the devices to D0 state before taking the link to L2 state.
> There is no functional issue with the endpoints where the link doesn't go
> into L2 state (the reason why the earlier change was made in the first
> place) as the root port proceeds with the usual flow post PME timeout.
>
> Fixes: 56e15a238d92 ("PCI: tegra: Add Tegra194 PCIe support")
> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
> Signed-off-by: Manikanta Maddireddy <mmaddireddy@nvidia.com>
> ---
> V5:
> * None
>
> V4:
> * None
>
> V3:
> * None
>
> V2:
> * None
For future reference, you can always just say ...
Changes V1 -> V5: None
Jon
next prev parent reply other threads:[~2026-02-10 17:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-08 18:07 [V5,00/13] Fixes to pcie-tegra194 driver Manikanta Maddireddy
2026-02-08 18:07 ` [V5,01/13] PCI: tegra194: Fix polling delay for L2 state Manikanta Maddireddy
2026-02-08 18:07 ` [V5,02/13] PCI: tegra194: Refactor LTSSM state polling on surprise down Manikanta Maddireddy
2026-02-10 17:08 ` Jon Hunter
2026-02-08 18:07 ` [V5,03/13] PCI: tegra194: Don't force the device into the D0 state before L2 Manikanta Maddireddy
2026-02-10 17:10 ` Jon Hunter [this message]
2026-02-08 18:07 ` [V5,04/13] PCI: tegra194: Free up EP resources during remove() Manikanta Maddireddy
2026-02-08 18:07 ` [V5,05/13] PCI: tegra194: Use HW version number Manikanta Maddireddy
2026-02-08 18:07 ` [V5,06/13] PCI: tegra194: Fix CBB timeout caused by DBI access before core power-on Manikanta Maddireddy
2026-02-08 18:07 ` [V5,07/13] PCI: tegra194: Disable PERST IRQ only in Endpoint mode Manikanta Maddireddy
2026-02-08 18:07 ` [V5,08/13] PCI: tegra194: Disable direct speed change for EP Manikanta Maddireddy
2026-02-08 18:07 ` [V5,09/13] PCI: tegra194: Use devm_gpiod_get_optional() to parse "nvidia,refclk-select" Manikanta Maddireddy
2026-02-08 18:07 ` [V5,10/13] PCI: tegra194: Apply pinctrl settings for both PCIe RP and EP Manikanta Maddireddy
2026-02-08 18:07 ` [V5,11/13] PCI: tegra194: Free resources during controller deinitialization Manikanta Maddireddy
2026-02-08 18:07 ` [V5,12/13] PCI: tegra194: Allow system suspend when the Endpoint link is not up Manikanta Maddireddy
2026-02-08 18:07 ` [V5,13/13] PCI: tegra194: Set LTR message request before PCIe link up Manikanta Maddireddy
2026-02-09 7:46 ` [V5,00/13] Fixes to pcie-tegra194 driver Krzysztof Kozlowski
2026-02-09 8:58 ` Manikanta Maddireddy
2026-02-10 17:18 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee886a80-0093-4c35-9701-427c2e166ca8@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=18255117159@163.com \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jingoohan1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=mmaddireddy@nvidia.com \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®