mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dinh Nguyen <dinguyen@kernel.org>
To: Adrian Ng Ho Yin <adrian.ho.yin.ng@altera.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] firmware: stratix10-svc: fix kaddr dangling pointers and populate kaddr1
Date: Wed, 2 Sep 2026 11:31:07 -0500	[thread overview]
Message-ID: <ee89861d-b0f6-46bf-a7cc-310da1f1acda@kernel.org> (raw)
In-Reply-To: <cover.1779780223.git.adrian.ho.yin.ng@altera.com>



On 5/26/26 15:35, Adrian Ng Ho Yin wrote:
> kaddr1/2/3 in the stratix10 service layer are set to addresses of local
> arm_smccc_res fields that go out of scope when the setting function returns,
> leaving dangling pointers in the callback data.
> 
> Patch 1 fixes this by adding a1/a2/a3 scratch fields to struct
> stratix10_svc_cb_data, which lives for the SVC thread lifetime, and
> pointing kaddrN to those fields instead of the stack.
> 
> Patch 2 uses the same mechanism to populate the previously unset kaddr1 in
> svc_thread_cmd_config_status(), exposing firmware status details to callers.
> 
> Adrian Ng Ho Yin (2):
>    firmware: stratix10-svc: fix dangling kaddr pointers in callback data
>    firmware: stratix10-svc: populate kaddr1 from config status response
> 
>   drivers/firmware/stratix10-svc.c              | 45 ++++++++++++-------
>   .../firmware/intel/stratix10-svc-client.h     | 17 +++++++
>   2 files changed, 47 insertions(+), 15 deletions(-)
> 

Do these patches need to get backport into a stable release? If so, 
please add the appropriated Fixes tag.

Thanks,
Dinh

      parent reply	other threads:[~2026-09-02 16:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-26  7:35 Adrian Ng Ho Yin
2026-05-26  7:35 ` [PATCH 1/2] firmware: stratix10-svc: fix dangling kaddr pointers in callback data Adrian Ng Ho Yin
2026-05-26  7:35 ` [PATCH 2/2] firmware: stratix10-svc: populate kaddr1 from config status response Adrian Ng Ho Yin
2026-09-02 16:31 ` Dinh Nguyen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ee89861d-b0f6-46bf-a7cc-310da1f1acda@kernel.org \
    --to=dinguyen@kernel.org \
    --cc=adrian.ho.yin.ng@altera.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®