From: James Clark <james.clark@linaro.org>
To: Yoshihiro Furudera <fj5100bi@fujitsu.com>
Cc: John Garry <john.g.garry@oracle.com>,
Will Deacon <will@kernel.org>, Mike Leach <mike.leach@linaro.org>,
Leo Yan <leo.yan@linux.dev>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
"Liang, Kan" <kan.liang@linux.intel.com>,
Ilkka Koskinen <ilkka@os.amperecomputing.com>,
Xu Yang <xu.yang_2@nxp.com>,
Jing Zhang <renyu.zj@linux.alibaba.com>,
Lucas Stach <l.stach@pengutronix.de>,
linux-arm-kernel@lists.infradead.org,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Akio Kakuno <fj3333bs@aa.jp.fujitsu.com>,
nick.forrington@arm.com
Subject: Re: [PATCH v2] perf vendor events arm64: Add FUJITSU-MONAKA pmu event
Date: Mon, 9 Dec 2024 10:01:45 +0000 [thread overview]
Message-ID: <ee89c235-a126-4874-994d-b2489eb1c00f@linaro.org> (raw)
In-Reply-To: <20241111064843.3003093-1-fj5100bi@fujitsu.com>
On 11/11/2024 6:48 am, Yoshihiro Furudera wrote:
> Add pmu events for FUJITSU-MONAKA.
> And, also updated common-and-microarch.json and recommended.json.
>
> FUJITSU-MONAKA Specification URL:
> https://github.com/fujitsu/FUJITSU-MONAKA
>
> Signed-off-by: Akio Kakuno <fj3333bs@aa.jp.fujitsu.com>
> Signed-off-by: Yoshihiro Furudera <fj5100bi@fujitsu.com>
> ---
> Changes in v2:
> - Change "SVE_INT64_DIV_SPEC" to "SVE_INT_DIV64_SPEC" in tools/perf/pmu-events/arch/arm64/fujitsu/monaka/sve.json.
> - Link to v1: https://lore.kernel.org/all/20241111024529.2985894-1-fj5100bi@fujitsu.com/
>
> .../arch/arm64/common-and-microarch.json | 858 ++++++++++++++++++
> .../fujitsu/monaka/cycle_accounting.json | 146 +++
> .../arch/arm64/fujitsu/monaka/energy.json | 20 +
> .../arch/arm64/fujitsu/monaka/exception.json | 32 +
> .../arm64/fujitsu/monaka/fp_operation.json | 194 ++++
> .../arch/arm64/fujitsu/monaka/gcycle.json | 116 +++
> .../arch/arm64/fujitsu/monaka/general.json | 8 +
> .../arch/arm64/fujitsu/monaka/hwpf.json | 62 ++
> .../arch/arm64/fujitsu/monaka/l1d_cache.json | 101 +++
> .../arch/arm64/fujitsu/monaka/l1i_cache.json | 47 +
> .../arch/arm64/fujitsu/monaka/l2_cache.json | 146 +++
> .../arch/arm64/fujitsu/monaka/l3_cache.json | 185 ++++
> .../arch/arm64/fujitsu/monaka/ll_cache.json | 8 +
> .../arch/arm64/fujitsu/monaka/memory.json | 8 +
> .../arch/arm64/fujitsu/monaka/pipeline.json | 230 +++++
> .../arch/arm64/fujitsu/monaka/retired.json | 29 +
> .../arm64/fujitsu/monaka/spec_operation.json | 158 ++++
> .../arch/arm64/fujitsu/monaka/stall.json | 83 ++
> .../arch/arm64/fujitsu/monaka/sve.json | 146 +++
> .../arch/arm64/fujitsu/monaka/tlb.json | 404 +++++++++
> .../arch/arm64/fujitsu/monaka/trace.json | 20 +
> tools/perf/pmu-events/arch/arm64/mapfile.csv | 1 +
> .../pmu-events/arch/arm64/recommended.json | 6 +
> 23 files changed, 3008 insertions(+)
> create mode 100644 tools/perf/pmu-events/arch/arm64/fujitsu/monaka/cycle_accounting.json
> create mode 100644 tools/perf/pmu-events/arch/arm64/fujitsu/monaka/energy.json
> create mode 100644 tools/perf/pmu-events/arch/arm64/fujitsu/monaka/exception.json
> create mode 100644 tools/perf/pmu-events/arch/arm64/fujitsu/monaka/fp_operation.json
> create mode 100644 tools/perf/pmu-events/arch/arm64/fujitsu/monaka/gcycle.json
> create mode 100644 tools/perf/pmu-events/arch/arm64/fujitsu/monaka/general.json
> create mode 100644 tools/perf/pmu-events/arch/arm64/fujitsu/monaka/hwpf.json
> create mode 100644 tools/perf/pmu-events/arch/arm64/fujitsu/monaka/l1d_cache.json
> create mode 100644 tools/perf/pmu-events/arch/arm64/fujitsu/monaka/l1i_cache.json
> create mode 100644 tools/perf/pmu-events/arch/arm64/fujitsu/monaka/l2_cache.json
> create mode 100644 tools/perf/pmu-events/arch/arm64/fujitsu/monaka/l3_cache.json
> create mode 100644 tools/perf/pmu-events/arch/arm64/fujitsu/monaka/ll_cache.json
> create mode 100644 tools/perf/pmu-events/arch/arm64/fujitsu/monaka/memory.json
> create mode 100644 tools/perf/pmu-events/arch/arm64/fujitsu/monaka/pipeline.json
> create mode 100644 tools/perf/pmu-events/arch/arm64/fujitsu/monaka/retired.json
> create mode 100644 tools/perf/pmu-events/arch/arm64/fujitsu/monaka/spec_operation.json
> create mode 100644 tools/perf/pmu-events/arch/arm64/fujitsu/monaka/stall.json
> create mode 100644 tools/perf/pmu-events/arch/arm64/fujitsu/monaka/sve.json
> create mode 100644 tools/perf/pmu-events/arch/arm64/fujitsu/monaka/tlb.json
> create mode 100644 tools/perf/pmu-events/arch/arm64/fujitsu/monaka/trace.json
>
> diff --git a/tools/perf/pmu-events/arch/arm64/common-and-microarch.json b/tools/perf/pmu-events/arch/arm64/common-and-microarch.json
> index 492083b99256..50fc4b2df361 100644
> --- a/tools/perf/pmu-events/arch/arm64/common-and-microarch.json
> +++ b/tools/perf/pmu-events/arch/arm64/common-and-microarch.json
> @@ -533,6 +533,12 @@
> "EventName": "SVE_INST_SPEC",
> "BriefDescription": "SVE operations speculatively executed"
> },
> + {
> + "PublicDescription": "This event counts architecturally executed Advanced SIMD and SVE operations.",
> + "EventCode": "0x8007",
> + "EventName": "ASE_SVE_INST_SPEC",
> + "BriefDescription": "This event counts architecturally executed Advanced SIMD and SVE operations."
> + },
Hi Yoshihiro,
You don't need to duplicate the descriptions if they are the same. Just
BriefDescription is enough and it will show for both normal and verbose
mode.
Also in the common files, we're using the description strings from the
Arm ARM. I noticed that the ones from your spec are slightly different.
This is ok for now, but if we add any new Arm cores that use the same
events this description may get overwritten. For example
ASE_SVE_INST_SPEC in the Arm ARM is currently "Operation speculatively
executed, Advanced SIMD or SVE".
If you have any actual relevant details that are different from the
common string, you should put them in .../arch/arm64/fujitsu/monaka. But
if you are ok with the potential overwrite (which looks like it should
be ok) then you can leave them as is.
[...]
> diff --git a/tools/perf/pmu-events/arch/arm64/fujitsu/monaka/general.json b/tools/perf/pmu-events/arch/arm64/fujitsu/monaka/general.json
> new file mode 100644
> index 000000000000..80bf17fb8f4c
> --- /dev/null
> +++ b/tools/perf/pmu-events/arch/arm64/fujitsu/monaka/general.json
> @@ -0,0 +1,8 @@
> +[
> + {
> + "ArchStdEvent": "CPU_CYCLES"
> + },
Other cores put CPU_CYCLES in bus.json. For user friendlyness I would
put the common ones into the same existing groups. The same issue
applies for some other common events.
Thanks
James
next prev parent reply other threads:[~2024-12-09 10:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-11 6:48 Yoshihiro Furudera
2024-12-06 1:53 ` Yoshihiro Furudera (Fujitsu)
2024-12-09 10:01 ` James Clark [this message]
2024-12-10 7:05 ` Yoshihiro Furudera (Fujitsu)
2024-12-17 6:35 ` Yoshihiro Furudera (Fujitsu)
2024-12-17 9:58 ` James Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee89c235-a126-4874-994d-b2489eb1c00f@linaro.org \
--to=james.clark@linaro.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=fj3333bs@aa.jp.fujitsu.com \
--cc=fj5100bi@fujitsu.com \
--cc=ilkka@os.amperecomputing.com \
--cc=irogers@google.com \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=l.stach@pengutronix.de \
--cc=leo.yan@linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=nick.forrington@arm.com \
--cc=peterz@infradead.org \
--cc=renyu.zj@linux.alibaba.com \
--cc=will@kernel.org \
--cc=xu.yang_2@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®