From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965353AbdAKMPz (ORCPT ); Wed, 11 Jan 2017 07:15:55 -0500 Received: from mail-dm3nam03on0064.outbound.protection.outlook.com ([104.47.41.64]:18683 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758711AbdAKMPl (ORCPT ); Wed, 11 Jan 2017 07:15:41 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=igor.mitsyanko.os@quantenna.com; Subject: Re: [PATCH net-next] bridge: multicast to unicast To: Felix Fietkau , Johannes Berg , =?UTF-8?Q?Linus_L=c3=bcssing?= , Stephen Hemminger References: <20170102193214.31723-1-linus.luessing@c0d3.blue> <1483706872.4089.8.camel@sipsolutions.net> <8836daaa-9638-4502-d079-fd428595f822@nbd.name> <1483710841.12677.1.camel@sipsolutions.net> <22fad045-57c6-7789-d19f-f47bd0faf441@fami-braun.de> <20170107145516.GE3134@otheros> <1483949336.17582.3.camel@sipsolutions.net> <6f5ec9f1-800a-2bc4-2f41-9d803343bb22@fami-braun.de> <20170109212345.GA5513@otheros> <20170109133032.221f8669@xeon-e3> <20170110041816.GJ5513@otheros> <1484045763.1014.0.camel@sipsolutions.net> <73f29777-cf95-de99-f7a9-9d82e94c298d@nbd.name> <058f2afd-2502-e2e5-6427-1536fcd5851f@quantenna.com> <015bf651-7584-13c0-16b9-d4e29e23c96b@nbd.name> CC: , , , , "David S . Miller" , "M. Braun" From: IgorMitsyanko Message-ID: Date: Wed, 11 Jan 2017 15:15:30 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <015bf651-7584-13c0-16b9-d4e29e23c96b@nbd.name> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [195.182.157.76] X-ClientProxiedBy: DM3PR13CA0026.namprd13.prod.outlook.com (10.164.193.36) To BLUPR0501MB2033.namprd05.prod.outlook.com (10.164.23.15) X-MS-Office365-Filtering-Correlation-Id: d0ca3979-b751-4d47-2f4a-08d43a1b8dd6 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BLUPR0501MB2033; X-Microsoft-Exchange-Diagnostics: 1;BLUPR0501MB2033;3:No6FVS604k2E438cPFhMOMpXWl9sLVgvgZDHJWLBWGwJfHHxdzVfgoUuTa/NO1dlpDGpIDbAiyKj0X+3vsYsuyOzpRmxwG67WkG0ZXAoee2uJuJbyXMetBVmadSZsQ0f02Du2E/ytxMF/BjnflZwutfoOmpifVrbqUlzBB1mcbcrPl8k0E5gtXRG/BX6RnuHrpsWy0x8t7GYD/IxSNR+fKnJso3DPYLKLr4jpb3RrVo9jhaEacjn6NrzMnOTm7o/kesumY/vwvnAqrnJ6NnvPQ==;25:GaEjKuioq1cNdel9U+rnB0L+B0B8mF+xhHVoN9vDhoNoIgQSihp0Ybz8PCpVDXqENpro3RF3+WdV35ZaRTj85+Ga/UT+N4G3uDWgehOdkkavtIV3pl1Mcaz1m7XtEKAP4mhh/M7yzX9N9D2EP57Uu+HW/Tuza50QU2zdGbbUQcSD9ehgKheyXZRYNEBNBKt8g7JkKPbBdc6BHf86rcCDk6nBBa3NYdEY2uB096VYWFYLvM02YJ/cQtaT9CJ8ZgGFtOEYGMCFFlHQiFpC+HmrPS8ufc+0oXaxjmKZmoMidtU1ntAKTwt8bL3d+BjCUb7YvaF8iEN6emvLpRZWz+VywLjZxgUmxjA0RCUrDFSXyD1TvPCeIZpSTMKTtOn/k25VgPbYPUorfVCAZWukHfEUfULBY8ScE+MMvrdkZohi5kIiZLFD/5UM0cA5oTqYsrcYKBpT1KoB7A0HbMLhUuYbNg== X-Microsoft-Exchange-Diagnostics: 1;BLUPR0501MB2033;31:Aahs8oKvamr8DTCGmbYVRrnluCOSBoPp4GrA2QOMoPyRqnPTHZtfXT9HTIHtx2dqegY06ljC8Ls4sxx2Yqsi+Sb3U0tP2r2HugSwW6CxaSrupFXlDK/9HSa8K2gAE1vLaOIT6kzlLm9S3ko39NeKNFx80e6Tp8SrlaZOY5cntYqhlCxzlavq078K/Jl6eb0nQ5tQRKsNZG1o+riFDrJmV6W7wI/SJKY8+N7YlnR2LVBzI104xthlTtLilSSwtgU8kYYC2H7WpyOmAtNVqu+Z/hE7pQxJPMN00S7KdRc4yPU=;20:5Hg6xtIBrihNe04vVNCylczr2+GIVsLVOc07M1UHUkvW0RHDc+EkTrgaW+RYcvrCKhmCpUVgcJlU3Iuu7k8Ox6Y1t3SpDcx+h8dFhWWcWuQmsOTDb9Qr4Ig0BoSiwUYWD9O6Ck9OZUT7lMEgcH8uxzRg8jrTOmAw6cEevlaVeMS6+oRDWr3UGMFNbnUx6YxUsiscOZD6lbw12/rxW+CgqLF94ofR5YP1kyj6rag14ak2278AEdnMiK/kah3lCXwQ6hUybJQMZlv+FYZoECpuIO7wE6QAmFnHtgWtj2yLHOhLsW0KpWoGC0L2k3jYKT4SsqgiCFaHzHmfhpClCscXi18vg4VY4USaNLNKHNhCMfy+CBaW6oa+zVs3zGneb2w59IVRSOzy30La8me3a/MIJ8gO4V+snB17G6vI8exMnWp2PJS3cyHC+K7ZAZXveA2MVaoZoQsQgEhCVz2G9BqMpn/SFgQJNFjQU3iEYcWRtHp3xpmr+hpuv/JWxgw3nhKp X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(158342451672863); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(20161123562025)(20161123555025)(20161123564025)(20161123560025)(6072148);SRVR:BLUPR0501MB2033;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0501MB2033; X-Microsoft-Exchange-Diagnostics: 1;BLUPR0501MB2033;4:Y2NxTC8ZvKtBF3oCCTRqPAxhBg2d3sAed5XZZzyyYEn+xrZUZovc6iDls1cTXsCXXrVrWxpNPd84W1kuMW8MK++OGkqZLxxQRKc7U27/CP0X2GhttqKzAoyjhJmfXVRvfOaUImEQld6SieF4erkYJua8hB7tYzu66TD1WyjBgjzfyL6eTuAEDE09SDIoZI4ViE775C0sfXFYCydHbyZk4y+sCmJX6A8HeJQvdl3glgNC4ibSpULUnIuAE3gDDkLgyo+UYL0VENX1CVZ+QwRatCkCje7wKLRVoMEbHrqvwRvhgonCa/nRP4E7BhX3pcCo2hJiniFAl0kkaVX2JtO6nkq4FJKenskARxAbfvrow4ybN2//9dQ6MTpYOrNiquACDr8fNoz/v+S1oy5LAsvOsN4e3nfzRvM6Be54a/mh1dqb0Sx954DJArACwPfe0Oo1K9T22Ahq24BSA3jfcq75Zoe1hLhLxDdz2Ws0phoTUYvcVNJekk17BoN5dh/w+r5T9MtV/ABcBHj4OyvmdakI2967EzpVS72/xJMvcQ7Ap5Fj/q1ME4aJRoksoR1aIXmc9sosa+DblhbPatx4Y4TAPCx8raubvBpPnjNcBENYttxgIg6V1LZpQbdboJXHpQOJ X-Forefront-PRVS: 01842C458A X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(7916002)(39450400003)(377454003)(189002)(199003)(54094003)(377424004)(24454002)(31686004)(86362001)(3846002)(6116002)(31696002)(23676002)(2870700001)(50986999)(101416001)(54356999)(76176999)(81156014)(8676002)(81166006)(7416002)(93886004)(305945005)(7736002)(68736007)(33646002)(2906002)(4326007)(4001350100001)(189998001)(97736004)(5001770100001)(5660300001)(38730400001)(92566002)(50466002)(64126003)(65826007)(36756003)(105586002)(42186005)(6666003)(2950100002)(65806001)(65956001)(66066001)(47776003)(106356001)(25786008)(229853002)(83506001)(90366009)(77096006)(6486002)(54906002);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR0501MB2033;H:[10.80.0.184];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTFVQUjA1MDFNQjIwMzM7MjM6aWJScTRNRVpLZkdxdEtFem1FMFZudzls?= =?utf-8?B?Wk5CeExBS0phVWg5TWZlL0tSaHFvTk5FRWU4RVpCdTk1eUFobFgyZ0pBcWRU?= =?utf-8?B?REkvbnJyRXdFSmZpVDMzTUpiVy9wRmtZNHFrWllob1JkQzJLYWEvaXhWSmxa?= =?utf-8?B?cG5iTnE2TWFRUFpMN3E2akFuTks4cVQ2UmN5VE5NdmxQejQyb0Rzb00vWEZi?= =?utf-8?B?NGtCNUtOQXR1a3JDR2ZvbW5vRUtkQ3pSYXhiN0pETVg3VkNzM1hHQjI0U3NZ?= =?utf-8?B?NExsNCtTQjY5T1dMODEwdDVGaVNZeTFISXNPbS9SMXVkM2J3WDhlZnU0WDZo?= =?utf-8?B?OFBqOGZTQlE4RWtsbDBZOFJESTMvVFgvNTFjbHo4eEVMUm9Fek52S2dmS0VZ?= =?utf-8?B?TEU5cE44M2RTbFVrT0JEY0hKRVhodERVRDJzYnNoK2Q5dWw0a3dGOXRxWUoy?= =?utf-8?B?R0RxVXgrQkhaNXZVVVZwYXN1ZkZLYlRoYTNtVjIwbUNlWTE1bzhHSjJNd0kx?= =?utf-8?B?LzhlQU11VEx0akYxRU5qcGpjNEpFTml3SlRyYVZhY21obE1WL0RIWkNFVXEv?= =?utf-8?B?cmtFd1VBNTlpWGpaSE1XL0ZyY2I3K0s5TUp5MTBuN1dQbmlwS2xCVzF0VCt5?= =?utf-8?B?RlNRRFowOEF5Zld5d3daR0lVTGw4ZjYvbjZhc3AxaEN5TGFIcThEMitLbHlL?= =?utf-8?B?RElaTURkN3dkNnd2WGRyZ0JzNkV2ZXNTdHhYdVcxZ2VwemIzdSsxaXlGUUlH?= =?utf-8?B?V1RiaUxUU2JtVm5OWDdVZlMrLzZsOExFSzBjK3hIS2F0T3UyeE5MeWYwcHdo?= =?utf-8?B?Y1ZqT1M3WUxxSU5CaGFEdjZ1azRZQ2VCN2hkSnVCN3RyRVluT1Z0cGt1Q21E?= =?utf-8?B?NFNIbjg3TUtmMVp0cnkvTEZxbmpLcy9SVzh5bUREQ29kZXd1L00xN2YrWmpJ?= =?utf-8?B?TUJpOEVqRS8vSmVNcDVvWFE4WXM5VHE0L1ZNU1VyWWhuZGxCaFNUODAzVWxy?= =?utf-8?B?a3Yxc0dZVmM5QXVnMHk5azlhb3BwNGFuK0N4Q2h4NXl2VlUrSllJV2FIbW5u?= =?utf-8?B?VnFVLys5eXN5Qkt5Z1pUMnVkMTllYmJWU2VIVnZNZnhFRnkzYkhlRHNraXZw?= =?utf-8?B?UmVJQTJ0bTdNbWlEbTl6L3NIMFRnY3VlZ1NHTkRMNEg0M2xmMnZldGJSNHBj?= =?utf-8?B?N0NYelZ5QkFaeTc5TkJLUEJEdkpjTTFMOWpzZ0tUQkpYS0JZUk4rV2lYYmM5?= =?utf-8?B?SVNwbGMyK2ZwUmRGdithelE4RXB6aWVwOGxQMGg2Wlc0UE5FUk5Cc3VKaFZW?= =?utf-8?B?NGhIWktIWU45VFdsVXlJa3NjTmI4ZVVOR2VJeHNtQjN1a29mY1l6VHZIVHBw?= =?utf-8?B?QzVzNkFrWXc1T2lDakNGeDVtelpWeHg5WFpmWkhHNGRZZGJCZ3ZCZVJTZmNj?= =?utf-8?B?aGJZL24xMWV3M0pzRUcraWVXK1VtenVsZ3FQVktMTFBOVlc2dDMyaE5lTmtV?= =?utf-8?B?MkRmTFhuRFIxeUtwR1dPQkkrRDYrQWRUTDFUTHRMSkVydGpudFM0MFc5VlRq?= =?utf-8?B?dDdmVnZwR3pWSlUzM01tMGFqajhuM25SUFRoMlhrL21Hd2hMRXJTVjVDVG5x?= =?utf-8?B?a0pWMjFMWU5xckhabFpIdlZuYisydWlOTitKcGo5eTRIYk9lTWw2QUVuN0NB?= =?utf-8?B?cmJJRVg4R1Z0NU01YXFFSVJTTVRydnErSVMrbnI0M3dnVEhEaElhM0ZTN3hN?= =?utf-8?B?Um5GK3pnVHlBTTFkS0tnaG1OcTJ4K0ppRlJZaXQxUitnc0lPVEZOUVZScnhp?= =?utf-8?B?ZmZZZUNIM0pSdTFVLzZIbGZlUTB5cjVMZzNLamttcjJqQ1EwZXdxOHZmY0ZR?= =?utf-8?B?WnkwajBibmUxN0M0cWhZdmE0RDl1U3B3QkhEZW1JS1NmaUMzcmtkdkJjWU1m?= =?utf-8?Q?RdUpFEmn/6UILC+T/GckX4RXeNsIWy9A=3D?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR0501MB2033;6:qzdbyR/3TwtW62xDYzAdSXemHAhsvAoGlswanaGZH10A3SfYcVAqMMwseCA6Agt5WEf/X/kT+SEsdm9nIcpFEjfkRsgcjd116m6Kbv4b60ZM/RpvQrrY274J1eixOfNFfK9uZ52iGSMiq49zEnpBXxNaQ+Mk00AhgVQeM2a97JeoSM/eXdlgOQqGXw2H72y/p8zS+42d85ZhDkqYHX3Xk2nGggMaVwJU3WBpUlXiyqjsQL6pTFJzOOgNq06cvq8BTOnzHjzzE6fBRNdgk0wGDlLgg/DYKibH2DcWWaOcuQQ4m62mDqg+sBvq5IxWDkWKmrDBueZLJzqHEp8DKmicFmCxvqeXLaVTFrJ1CSBlDoyDbSFg2Wc6maOzBbxPUik1XGebdFttvV6b1Vq7CL7G6H4kqNM2cGDBy7UKBmwkCPg=;5:wixaYRnE1Pf2DejUSOEfBw73rk92RA2I/B1OmqfvBpjq/hZZuJIS0nFSzvzkQEl8RFoZQtqS//UwtQ7o+BQdFdVddMVNtCNXYKZ/zAXS4QbE7Mb8Hy1UAhTmzZiVC4Luzl+gn8NAJgxUEaRRYwNxdA==;24:s2K4V05aT1ysnKOr7JLY1MvZzNDRgF2lz6FY+eLI+pJZST1QSF83k+RJczvmJAr7Upou0GBtxiXDk6WBrXNs0zQyaxZYgywmRGk1HYkiGeY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BLUPR0501MB2033;7:P5TJwqbw0SCt+E2ZzD0U4EZL7J4cfaOi1I1pDCDo8jxeVCUTQ1s6FuCQsB1bshb3A9UKmrEN55pQ069TyfM9xQq2sjghV/zzf/isz69WJtWnMymTZITcxmWmvN39PHmLHdQAgC2ECwceocXaX30kUPR2lNfZgfoqdC9w0jkiS5TbwoIKRLo8+/55rZODoBTiLDf17SDNxv5Kv+AHVYv3reiWkeo+0CcgEiMJtAci0T3FzdqqEP9tXhOzqidJN19xTRxHTk0d4njIxoFEc1b3UjqxqW3l4x/IT85yZzxdEDaplDA8Ux34MYQt3EA97wlsUxp8KjgPPCkIDz5yKTuJdPqcV4WhSaLHcab55ss2giWdNy/uVWyw7HhgbaGu3Z5sisDUfMp+J/vgGvYvwFSTnmzqsxu0CM8sOhzwg+2oq/RBKJnVhOSn+u+ur6BGXsz7zcDccUOXNi116S6XIhAW/A== X-OriginatorOrg: quantenna.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2017 12:15:36.0865 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0501MB2033 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/11/2017 02:30 PM, Felix Fietkau wrote: > On 2017-01-11 12:26, IgorMitsyanko wrote: >> On 01/11/2017 12:27 AM, Felix Fietkau wrote: >>> On 2017-01-10 11:56, Johannes Berg wrote: >>>> On Tue, 2017-01-10 at 05:18 +0100, Linus Lüssing wrote: >>>>> On Mon, Jan 09, 2017 at 01:30:32PM -0800, Stephen Hemminger wrote: >>>>>> I wonder if MAC80211 should be doing IGMP snooping and not bridge >>>>>> in this environment. >>>>> In the long term, yes. For now, not quite sure. >>>> There's no "for now" in the kernel. Code added now will have to be >>>> maintained essentially forever. >>> I'm not sure that putting the IGMP snooping code in mac80211 is a good >>> idea, that would be quite a bit of code duplication. >>> This implementation works, it's very simple, and it's quite flexible for >>> a number of use cases. >>> >>> Is there any remaining objection to merging this in principle (aside >>> from potential issues with the code)? >>> >>> - Felix >>> >> >> Hi Felix, can we consider two examples configurations with multicast >> traffic: >> >> 1. AP is a source of multicast traffic itself, no bridge on AP. For >> example, wireless video server streaming to several clients. >> In this situation, we can not make use of possible advantages given by >> mc-to-uc conversion? > You could simply put the AP interface in a bridge, no need to have any > other bridge members present. > >> 2. A configuration with AP + STA + 3 client devices behind STA. >> ----|client 1| >> | >> | mc |----|AP|----|STA|---|---|client 2| >> |server| | >> ----|client 3| >> >> Multicast server behind AP streams MC video traffic. All 3 clients >> behind the STA have joined the multicast group. >> I'm not sure if this case will be handled correctly with mc-to-uc >> conversion in bridge on AP? > What do you mean by "3 client devices behind STA"? Are you using a > 4-addr STA, multicast routing, or some kind of vendor specific "client > bridge" hackery? 3 client devices connected by backbone Ethernet network. Generic case is probably STA/AP operating in 4-addr mode (more or less standard solution as far as I know). "Client bridge" approach should not concern us here I think, it will seem to AP and AP's bridge as a single client. > > - Felix