From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751402AbdAQScA (ORCPT ); Tue, 17 Jan 2017 13:32:00 -0500 Received: from vern.gendns.com ([206.190.152.46]:55472 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750741AbdAQSb5 (ORCPT ); Tue, 17 Jan 2017 13:31:57 -0500 Subject: davinci common clock framework (was Re: [PATCH 03/10] devicetree: bindings: add bindings for ahci-da850) To: Sekhar Nori , Bartosz Golaszewski References: <1484311084-31547-1-git-send-email-bgolaszewski@baylibre.com> <1484311084-31547-4-git-send-email-bgolaszewski@baylibre.com> <35ff358d-9b17-b2be-38d8-6a51cdddc1a1@lechnology.com> <37c826cc-9804-291e-a7b2-a512b59524fd@ti.com> Cc: Kevin Hilman , Patrick Titiano , Michael Turquette , Tejun Heo , Rob Herring , Mark Rutland , Russell King , linux-ide@vger.kernel.org, linux-devicetree , LKML , arm-soc From: David Lechner Message-ID: Date: Tue, 17 Jan 2017 12:31:56 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <37c826cc-9804-291e-a7b2-a512b59524fd@ti.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/17/2017 06:00 AM, Sekhar Nori wrote: > On Tuesday 17 January 2017 12:17 AM, David Lechner wrote: >> On 01/16/2017 08:30 AM, Bartosz Golaszewski wrote: >>> 2017-01-16 13:45 GMT+01:00 Sekhar Nori : >>>> On Monday 16 January 2017 03:43 PM, Bartosz Golaszewski wrote: >>> >>> It's true that once davinci gets ported (is this planned?) to using >>> the common clock framework, we could just create a fixed-clock node in >>> da850-lcdk for the SATA oscillator, so the new property is redundant. >>> >> >> I have some commits[1] where I started on converting da850 to use the >> common clock framework. But, I don't know anything about other davinci >> family devices, so I don't think I could really take that to completion >> without lots of help. > > I can help with testing, reviewing and filling in any missing > information. But I wont have time to write the code itself. > >> >> [1]: https://github.com/dlech/ev3dev-kernel/commits/wip-20160509 > > I see that you have made a copy of the keystone PSC driver. I think you > will need pretty strong reasons to not use the same driver with some > customization for DaVinci. > It has been a while since I looked at this, but as I recall, the device tree bindings for keystone are horrible and make no sense. So, I made new bindings that make more sense. But since we can't break backwards compatibility in device tree, I made a new driver rather than having the mess of supporting two very different bindings in one driver. I don't know if that is a strong enough reason, but that is why I did it. :-)