From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: Alina Yu <alina_yu@richtek.com>,
lgirdwood@gmail.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
cy_huang@richtek.com
Subject: Re: [PATCH 2/2] regulator: dt-bindings: rtq2208: Add specified fixed LDO VOUT property
Date: Wed, 22 May 2024 15:29:23 +0200 [thread overview]
Message-ID: <eeaaf991-0441-409f-b8d2-dcd704d21fd3@linaro.org> (raw)
In-Reply-To: <05843386-92f4-4246-a633-315c3178d86f@sirena.org.uk>
On 22/05/2024 13:35, Mark Brown wrote:
> On Wed, May 22, 2024 at 11:27:06AM +0200, Krzysztof Kozlowski wrote:
>> On 22/05/2024 11:03, Alina Yu wrote:
>
>>> Due to the fixed LDO VOUT being outside the range of the adjustable one,
>>> a special-use property has been added to avoid overusing the constraints.
>
>> Hm, why exactly this is not a bool property? What are the benefits?
>
> It avoids confusion between invalid constraints specified on the
> variable voltage regulator and allows us to validate any constraints
> that happen to be specified (though it'd be pointless to specify
> constraints). The fact that the regulator could also be variable
> voltage is asking for confusion if we use boolean.
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
prev parent reply other threads:[~2024-05-22 13:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-16 9:20 [PATCH 0/2] Add specified fixed LDO VOUT propery Alina Yu
2024-05-16 9:20 ` [PATCH 1/2] regulator: rtq2208: Add fixed LDO VOUT property and check that matches the constraints Alina Yu
2024-05-27 13:00 ` Mark Brown
2024-05-28 6:07 ` Alina Yu
2024-05-29 6:41 ` Alina Yu
2024-05-16 9:20 ` [PATCH 2/2] regulator: dt-bindings: rtq2208: Add specified fixed LDO VOUT property Alina Yu
2024-05-16 12:34 ` Krzysztof Kozlowski
2024-05-22 9:03 ` Alina Yu
2024-05-22 9:27 ` Krzysztof Kozlowski
2024-05-22 9:45 ` Alina Yu
2024-05-22 11:35 ` Mark Brown
2024-05-22 13:29 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eeaaf991-0441-409f-b8d2-dcd704d21fd3@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alina_yu@richtek.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®