From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.45 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794582403; b=1J6BMOZJNshNjHmvesVL1/TWttncLkMh2v9fOtzd9H67SousWdZfw/A/T+CUEfHRR6aW dOylOA1MP6OI+N188NqoNPYzod1iFqnefh8DDC8TQso5hI+W+QDfIoiOXrmd0Jpksd5Vr y+26+ge93eLSNojFLd6jnPU7QDQ96B+bKwDSGU9S0IFfq/o/+0I8jS+vfUkKK8HfUEA/v cFkOgUvDuZpJ4I+sWKl50m9ToxRo097yWsNpiS6m+ppPZqCX3XBoCxFklt0h2iWe0X6/g dd/CijWwXCL5jLxMq7WvNoV9cA5s4waQ8LrpQ1Q1kQaMWC8Do/Aw1DOQ7QYWVz/GNSw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794582403; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From: Content-Language:Autocrypt:In-Reply-To:Content-Type: Content-Transfer-Encoding; bh=WRbE/ClC4DCa25YOZgoiuOw+fWtwtLO81F/+SZ+7Q48=; b=X/lRNPJP9W+IqLIvCJ2/Rg3+45dxmag8Nezxo6Q39pofKs11vU5vgHCcr8aWrwM8PSfx JUjGBkhm/pOSI89gi62DUi0txTZ7+CdrFZlGBoHo2mHCtIXEh5m11kSDDuwITrGXtWlwO UlUTVFWmtiYBt5T5PsIyyAOsXskRQg98RA1JVlqiQ8q1zB4Oc+dErBfEVGZRD2aOWOPI1 XP9QJhEqOOCntfbg/w++w7Uy6rXctYmj7VvTIyznxa+9etrcaunPRz14J1pMlt3Btd9z9 Oxw4LcDPn+CsZbSWDrmTdlyXrZwOSGjm4QF+HhDNoNUbned4UnD9PhOL6vC6CYc+00Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass header.d=suse.com header.i=@suse.com header.a=rsa-sha256 header.s=google header.b=Axb7NsCI; arc=none smtp.remote-ip=209.85.128.45 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65196606A33B for ; Fri, 13 Nov 2026 15:06:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 65196606A33B Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.a=rsa-sha256 header.s=google header.b=Axb7NsCI Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4a3517554f7so16272455e9.2 for ; Fri, 13 Nov 2026 07:06:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1794582402; x=1795187202; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=WRbE/ClC4DCa25YOZgoiuOw+fWtwtLO81F/+SZ+7Q48=; b=Axb7NsCIAB7p9iSXQm7dWzwN7Y1rvsP17vZUVDrpPSvEN4LN4/Uz1YNMkJhTJXkop/ mtjC+vJZh2hDO1GwJfXedJxIsLNUs4OAzzMUIrxi1vTsqFN91WtuWK5pkptktbtjEHg1 lOyxSXhRobIl0FYGW1xZ5+8xsFCacs/qeo/99ib3InqnljMABeegRVOE0YRLRBrSFKaX iPaK3DHdAvZSAQRN+uxoHRRKIid5Qb/zza/dIwKwIVi5R39d0VC5dgOCyAQW94FZCaZg IN51677Udf6NOyNoeYOmxzyCEFFrBOsrPBLd0Jyn0pMXc/Wu28ArSQOoD2r00FPXH8v5 ER2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794582402; x=1795187202; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=WRbE/ClC4DCa25YOZgoiuOw+fWtwtLO81F/+SZ+7Q48=; b=VRMcIwLFdn1HHuGAfPHU9LsensKJdmtpSN4WQK4QcycU7Oy44s+ZA/ctxFrrkBJ5E1 YIBLhHpMaM7YjKl6ceHL1/9Xnlhi7yE2OndOgyVNoNNC6BkPvGYi1ty54rVsOu3PGQfS T8g9oI30gv03ITfzX3yJqSqxr5JwrpcbaThXSDfkGUagqBeCSvTZNBMatYtd9CNYeaT6 HnvXAUcct2z0ryNiE5oKlwRoj8g2ejbPxhSsj+NFoYkmBJM+MSnu207jSUrydefarO4o 4vCFhG/RYn1b9ih1c8JrDG849S+P0NHctSM4hF5dZUrS04d+cYQz59QrjSqwIjEg/ofx gy0Q== X-Forwarded-Encrypted: i=1; AL+hErGXSfs/MCOhQQxzJf3uPKuoQIyQZCFl4qB719wp+lvg9hPkDlNiqZqvDDHomRNXPDblI8j/5XPLFAWoZ0U=@vger.kernel.org X-Gm-Message-State: APuU4Z+ZoXL3tudU0yLCvK1+rMnexHF79cA0gnUHvPu74d1c51U3vwKs o6RujFkPieDxw+JofzCFMM4EUtevwzo7GtK3DvbSnAtA4UpqO7kI/JHSiTodTOamdlQ= X-Gm-Gg: AYBFou3JMp6xgrQbTY76Bcxqc/8VtZ7y0mJQDnR3fvNuQiW6HfWgDyOEaVrOs5B+FUG ukivAROcrv/MnyzDOpHjM1YC7rMeCQyQeHbOuFJkNw1JLDVp771OfdcCwHTN5W1cQOK8p30SNI2 vqBo8GE5niwaBljSRwEB4Drx5FNOV0JVxYlTeGk3G9wjflIapcuJ9cQd5VBFGMjniCAtuAfG+mr wz2kV9NLvC5ifBu13V42Suqi7dMOPBuRYmI0dGKSxwdot8sslLmHRMKArvhwtoJKblS63h2CmOm rz08GYMmI+xDuaUR4at65z+jnFvnuL3+TUpIllcoGNp973GOB+h7uPK9Abdg+x8ggAIpH87KxJT 4MEw3PS4rbaRvc/26WTHBIQXt7sfmfbJzFNjMSqeUhmVPKHEubSNsKdECYLlUWxJ6q7O4QOUKO1 6++cm1gOPUpAGTx4OPYS8/GeNO6x7QFiGIVa/C9qsv8QSb7wMAeQLxs1DVbnSzbDMyFMlxY0uIn xQrfJuMlpdRjvNv0RqURM8xlCidGx2qMDg8gBwA1FSwjSH8IPZjT1SI8fSlIPVb+lJzWUAJOtCw R2cpkzPLMAS2G1/NB+3vu3YgJCACSXkR X-Received: by 2002:a05:600c:4f0e:b0:4bb:5f43:23bb with SMTP id 5b1f17b1804b1-4bb5f43261fmr8025205e9.33.1794582401803; Fri, 13 Nov 2026 07:06:41 -0800 (PST) Received: from [192.168.0.20] ([212.21.133.162]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4bb56f8d054sm40186365e9.3.2026.11.13.07.06.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Nov 2026 07:06:41 -0800 (PST) Message-ID: Date: Fri, 13 Nov 2026 17:06:39 +0200 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/6] x86/virt/tdx: Move TDH.SYS.CONFIG operations into a wrapper To: Xu Yilun , x86@kernel.org, linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Kiryl Shutsemau , Rick Edgecombe , Dave Hansen , dave.hansen@intel.com, kvm@vger.kernel.org, yilun.xu@intel.com, xiaoyao.li@intel.com, sohil.mehta@intel.com, adrian.hunter@intel.com, kishen.maloor@intel.com, tony.lindgren@linux.intel.com, peter.fang@intel.com, baolu.lu@linux.intel.com, zhenzhong.duan@intel.com, chao.gao@intel.com, artem.bityutskiy@linux.intel.com References: <20261111-tdx-module-ext-v5-0-c74f764abc3d@linux.intel.com> <20261111-tdx-module-ext-v5-1-c74f764abc3d@linux.intel.com> From: Nikolay Borisov Content-Language: en-US Autocrypt: addr=nik.borisov@suse.com; keydata= xsFNBGcrpvIBEAD5cAR5+qu30GnmPrK9veWX5RVzzbgtkk9C/EESHy9Yz0+HWgCVRoNyRQsZ 7DW7vE1KhioDLXjDmeu8/0A8u5nFMqv6d1Gt1lb7XzSAYw7uSWXLPEjFBtz9+fBJJLgbYU7G OpTKy6gRr6GaItZze+r04PGWjeyVUuHZuncTO7B2huxcwIk9tFtRX21gVSOOC96HcxSVVA7X N/LLM2EOL7kg4/yDWEhAdLQDChswhmdpHkp5g6ytj9TM8bNlq9I41hl/3cBEeAkxtb/eS5YR 88LBb/2FkcGnhxkGJPNB+4Siku7K8Mk2Y6elnkOctJcDvk29DajYbQnnW4nhfelZuLNupb1O M0912EvzOVI0dIVgR+xtosp66bYTOpX4Xb0fylED9kYGiuEAeoQZaDQ2eICDcHPiaLzh+6cc pkVTB0sXkWHUsPamtPum6/PgWLE9vGI5s+FaqBaqBYDKyvtJfLK4BdZng0Uc3ijycPs3bpbQ bOnK9LD8TYmYaeTenoNILQ7Ut54CCEXkP446skUMKrEo/HabvkykyWqWiIE/UlAYAx9+Ckho TT1d2QsmsAiYYWwjU8igXBecIbC0uRtF/cTfelNGrQwbICUT6kJjcOTpQDaVyIgRSlUMrlNZ XPVEQ6Zq3/aENA8ObhFxE5PLJPizJH6SC89BMKF3zg6SKx0qzQARAQABzSZOaWtvbGF5IEJv cmlzb3YgPG5pay5ib3Jpc292QHN1c2UuY29tPsLBkQQTAQoAOxYhBDuWB8EJLBUZCPjT3SRn XZEnyhfsBQJnK6byAhsDBQsJCAcCAiICBhUKCQgLAgQWAgMBAh4HAheAAAoJECRnXZEnyhfs XbIQAJxuUnelGdXbSbtovBNm+HF3LtT0XnZ0+DoR0DemUGuA1bZAlaOXGr5mvVbTgaoGUQIJ 3Ejx3UBEG7ZSJcfJobB34w1qHEDO0pN9orGIFT9Bic3lqhawD2r85QMcWwjsZH5FhyRx7P2o DTuUClLMO95GuHYQngBF2rHHl8QMJPVKsR18w4IWAhALpEApxa3luyV7pAAqKllfCNt7tmed uKmclf/Sz6qoP75CvEtRbfAOqYgG1Uk9A62C51iAPe35neMre3WGLsdgyMj4/15jPYi+tOUX Tc7AAWgc95LXyPJo8069MOU73htZmgH4OYy+S7f+ArXD7h8lTLT1niff2bCPi6eiAQq6b5CJ Ka4/27IiZo8tm1XjLYmoBmaCovqx5y5Xt2koibIWG3ZGD2I+qRwZ0UohKRH6kKVHGcrmCv0J YO8yIprxgoYmA7gq21BpTqw3D4+8xujn/6LgndLKmGESM1FuY3ymXgj5983eqaxicKpT9iq8 /a1j31tms4azR7+6Dt8H4SagfN6VbJ0luPzobrrNFxUgpjR4ZyQQ++G7oSRdwjfIh1wuCF6/ mDUNcb6/kA0JS9otiC3omfht47yQnvod+MxFk1lTNUu3hePJUwg1vT1te3vO5oln8lkUo9BU knlYpQ7QA2rDEKs+YWqUstr4pDtHzwQ6mo0rqP+zzsFNBGcrpvIBEADGYTFkNVttZkt6e7yA LNkv3Q39zQCt8qe7qkPdlj3CqygVXfw+h7GlcT9fuc4kd7YxFys4/Wd9icj9ZatGMwffONmi LnUotIq2N7+xvc4Xu76wv+QJpiuGEfCDB+VdZOmOzUPlmMkcJc/EDSH4qGogIYRu72uweKEq VfBI43PZIGpGJ7TjS3THX5WVI2YNSmuwqxnQF/iVqDtD2N72ObkBwIf9GnrOgxEyJ/SQq2R0 g7hd6IYk7SOKt1a8ZGCN6hXXKzmM6gHRC8fyWeTqJcK4BKSdX8PzEuYmAJjSfx4w6DoxdK5/ 9sVrNzaVgDHS0ThH/5kNkZ65KNR7K2nk45LT5Crjbg7w5/kKDY6/XiXDx7v/BOR/a+Ryo+lM MffN3XSnAex8cmIhNINl5Z8CAvDLUtItLcbDOv7hdXt6DSyb65CdyY8JwOt6CWno1tdjyDEG 5ANwVPYY878IFkOJLRTJuUd5ltybaSWjKIwjYJfIXuoyzE7OL63856MC/Os8PcLfY7vYY2LB cvKH1qOcs+an86DWX17+dkcKD/YLrpzwvRMur5+kTgVfXcC0TAl39N4YtaCKM/3ugAaVS1Mw MrbyGnGqVMqlCpjnpYREzapSk8XxbO2kYRsZQd8J9ei98OSqgPf8xM7NCULd/xaZLJUydql1 JdSREId2C15jut21aQARAQABwsF2BBgBCgAgFiEEO5YHwQksFRkI+NPdJGddkSfKF+wFAmcr pvICGwwACgkQJGddkSfKF+xuuxAA4F9iQc61wvAOAidktv4Rztn4QKy8TAyGN3M8zYf/A5Zx VcGgX4J4MhRUoPQNrzmVlrrtE2KILHxQZx5eQyPgixPXri42oG5ePEXZoLU5GFRYSPjjTYmP ypyTPN7uoWLfw4TxJqWCGRLsjnkwvyN3R4161Dty4Uhzqp1IkNhl3ifTDYEvbnmHaNvlvvna 7+9jjEBDEFYDMuO/CA8UtoVQXjy5gtOhZZkEsptfwQYc+E9U99yxGofDul7xH41VdXGpIhUj 4wjd3IbgaCiHxxj/M9eM99ybu5asvHyMo3EFPkyWxZsBlUN/riFXGspG4sT0cwOUhG2ZnExv XXhOGKs/y3VGhjZeCDWZ+0ZQHPCL3HUebLxW49wwLxvXU6sLNfYnTJxdqn58Aq4sBXW5Un0Q vfbd9VFV/bKFfvUscYk2UKPi9vgn1hY38IfmsnoS8b0uwDq75IBvup9pYFyNyPf5SutxhFfP JDjakbdjBoYDWVoaPbp5KAQ2VQRiR54lir/inyqGX+dwzPX/F4OHfB5RTiAFLJliCxniKFsM d8eHe88jWjm6/ilx4IlLl9/MdVUGjLpBi18X7ejLz3U2quYD8DBAGzCjy49wJ4Di4qQjblb2 pTXoEyM2L6E604NbDu0VDvHg7EXh1WwmijEu28c/hEB6DwtzslLpBSsJV0s1/jE= In-Reply-To: <20261111-tdx-module-ext-v5-1-c74f764abc3d@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 11.11.26 г. 5:48 ч., Xu Yilun wrote: > TDH.SYS.CONFIG is currently not wrapped in a SEAMCALL wrapper because it > is not exposed to external callers (such as KVM), also because the > level of TDX ABI details needed to perform the call is low enough to > flow well with the calling code. > > But as more configurations are being added to this SEAMCALL leaf, more > ABI details are leaked into the surrounding caller code, which decreases > the readability of the caller logic. The first case is that the Dynamic > PAMT (DPAMT) change [1] tweaks the R8 argument based on whether DPAMT is > supported by the loaded TDX module. > > A follow-up case comes as the TDX architecture has evolved the ABI to > introduce new leaf versions. The host must select the version to call > based on what new features are supported by the loaded TDX module. > > Before the version selection makes the caller logic even messier, move > the register ABI operations into a wrapper. > > The original changelog was written by hand. AI was used to help correct > grammatical errors and polish individual sentences for better > readability. > > Signed-off-by: Xu Yilun > Link: https://lore.kernel.org/all/20260904215841.303070-10-rick.p.edgecombe@intel.com/ # [1] Reviewed-by: Nikolay Borisov