From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CF9A3CBE7F for ; Wed, 18 Mar 2026 15:24:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773847486; cv=none; b=MAWQcAaGkQ0oma9wABhcZfmoLUkFKD/EX5wj7aUc5727YHg0vJkvNzbkoGiZ8g5PabC24+ENWBR8es4PS8sSGHDHstaZYW+Jg2mAnby7F+XGjSsQqXo4jWE2vs2vYbJi+hft5Psf1tcPUPkCPsoF+ZxmXf6WgleDkJD5dOyOLWs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773847486; c=relaxed/simple; bh=c/DCmR6L+58F9B58bTD30uRYZyniFjE8iAFlTLFoSio=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XbJuc1GtqAXeaQpkkVnUPPD25egV6TF2gwauYVY3mfLnldLgDZ4cIBTkDQ8a1IdxWj0tJ0ZCnjhJJ7ZxAd9Pyc4CNh/Y2MLpipNiGRL/vppTyW92DpEUyXbZuk8RvG5Vz6j5vB6tuzxEygoFd366O6P6SlHbBe5wjmPSc16hLyk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linbit.com; spf=pass smtp.mailfrom=linbit.com; dkim=pass (2048-bit key) header.d=linbit-com.20230601.gappssmtp.com header.i=@linbit-com.20230601.gappssmtp.com header.b=TZgi7HuA; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linbit.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linbit.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linbit-com.20230601.gappssmtp.com header.i=@linbit-com.20230601.gappssmtp.com header.b="TZgi7HuA" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4852afd42ceso59612285e9.2 for ; Wed, 18 Mar 2026 08:24:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linbit-com.20230601.gappssmtp.com; s=20230601; t=1773847481; x=1774452281; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Gyu5ICoUlpKJMIvNRjsizKDezce3zOQx/9IXKSYvK4Y=; b=TZgi7HuAyE3r+ISt53aKT1EuvdfNOIoImZQ6djnbUwi6zU5RTZpUblVxnxjBB5Cjbg wKAZwCGV06M8q5bPnzBECgARdgYMH85U83BpFwR7dQR0izZ186l39NxiDRejRQ3NXYRv Fubt4yASZylmUTfoBZw29f9x8n2lmgpUo0VE/hqNcjUAAhlTQf6KkdDRpqozI6oKrYBz CiNoR+DZiGGNM6VFA7V5vPBNSrF4iK6iTD3xuQA/80u+2t6AQN+G+OYCRhywTKnkevBN 8veKkZPs5ixkDHkET95TLCatxFVXIjVBdDVKKS+DPVZBdSalqBeqh5N5/1lxNEYUZv1i w20Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773847481; x=1774452281; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Gyu5ICoUlpKJMIvNRjsizKDezce3zOQx/9IXKSYvK4Y=; b=EabGJHiMCngDba3aigj2EVSODMwFCotXm7w+oN4XBZ1uLKiIn0EAgFqYF+IVow3s1K 2HW1pptl0lIJ4bNyKqXK5SXcwTq/xJwBPnhsh9YNon00r+AhQcO44h9z4aw2R/scqTaF wRaRohu5Oauj9KmWPjWlMwDBKcRJ5RtaGFblFH29/lIIxfk6YvmQTDQv6CQNcStMCbgq rjM6DtJKiDGqzqkLW45Nri+PKvROXvz/ETmiQ80upD2y2E6c3AdU4iEbsJOGlXD4ChiY 0T/KvS1q+knMKVbAhVnX8PQ6haTqyZUxkIftRpAsB12J0USocdSh3EleMI8g7otuuzon JtBA== X-Forwarded-Encrypted: i=1; AJvYcCV0vn4Hegt1xR0esSxHB49mnrpW7KsoquUSSI/JitIKZOgFuBDoAnf6d8xOSNVSQ4foLqHn0HjtznQ4Gug=@vger.kernel.org X-Gm-Message-State: AOJu0Yzsvpa2pM8fLEExVvriOLqRBUE1A9VFC6rkGfrdwXEMV2/XcOgR 1IR1y2IXsext/dH7TWDrDbapKQQTKrA9ijq3WVHmNgMSE67npGm70OE/pIkabl04yTw= X-Gm-Gg: ATEYQzyo7VYbHUyXYchrrZBOf2BEZtYyLRrEUxEHy1Ob6fGhaD6nV4Qq7ZZhXKrETBu xKo/sQYZjyZZHIQ4+91TO2/nqkTG0z/CqRk3NSvIi0ALy+J56wpWMavzbSuQilc2MRbjxQC/FD4 YDO7qnRWcAJ6nLYekr5/0DC0Temt5ugG2RWaXVsFQgm4P06yt+G2sFXt9hF4o9DxjlVMcltKuLG MkJ2lCEFN/DFu9ILhNe36iS/znGCUYOsnCXeQ1wwo3RAI6pyYNMPxBQCigRs6wmsxCNQmqBu5np QMJGulQIaLWSUYMzf+K60o3Mj/w67oXfbWcdL86aq9r7YA+MlntpzgeK2y3iqjCUNjKiHKHwazX YD9anUYYfRyFUhaoHn3v46LBnKXXlu1Pny0SNUF1F8chppXoD6Z8JAZycqO9MJvDEBuxr5t8Eyr dAtqU46avE58iEv+1l1oepnXZ4CPXiCWWJjXzF1jov80st2LQuOlJQzoJ1aM/PR2Gf8+PVNHCAn Vpve3hcplQii74= X-Received: by 2002:a05:600c:3b28:b0:485:3aa1:a7f1 with SMTP id 5b1f17b1804b1-486f441bc51mr65620445e9.7.1773847481385; Wed, 18 Mar 2026 08:24:41 -0700 (PDT) Received: from [192.168.178.55] (h082218028181.host.wavenet.at. [82.218.28.181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4856eae3396sm144310575e9.9.2026.03.18.08.24.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Mar 2026 08:24:40 -0700 (PDT) Message-ID: Date: Wed, 18 Mar 2026 16:24:39 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] drbd: fix rdma dependency To: Arnd Bergmann , Philipp Reisner , Lars Ellenberg , Jens Axboe Cc: Arnd Bergmann , "Martin K. Petersen" , Ard Biesheuvel , Eric Biggers , drbd-dev@lists.linbit.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260318104858.1868731-1-arnd@kernel.org> From: =?UTF-8?Q?Christoph_B=C3=B6hmwalder?= Content-Language: en-US In-Reply-To: <20260318104858.1868731-1-arnd@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Am 18.03.26 um 11:48 schrieb Arnd Bergmann: > From: Arnd Bergmann > > The new rdma transport module uses a trick to only build support > if infiniband/rdma is enabled. This seems to be done the wrong way > around, as it gets built if RDMA is in a loadable module, but not > if it's built-in. > > However, this fails in configurations that have infiniband support > in a loadable module but drbd built-in: > > ERROR: modpost: "rdma_bind_addr" [drivers/block/drbd/drbd_transport_rdma.ko] undefined! > ERROR: modpost: "rdma_listen" [drivers/block/drbd/drbd_transport_rdma.ko] undefined! > ERROR: modpost: "rdma_destroy_id" [drivers/block/drbd/drbd_transport_rdma.ko] undefined! > ERROR: modpost: "rdma_destroy_qp" [drivers/block/drbd/drbd_transport_rdma.ko] undefined! > ERROR: modpost: "rdma_disconnect" [drivers/block/drbd/drbd_transport_rdma.ko] undefined! > ERROR: modpost: "__rdma_create_kernel_id" [drivers/block/drbd/drbd_transport_rdma.ko] undefined! > ERROR: modpost: "rdma_resolve_route" [drivers/block/drbd/drbd_transport_rdma.ko] undefined! > ERROR: modpost: "rdma_reject" [drivers/block/drbd/drbd_transport_rdma.ko] undefined! > ERROR: modpost: "rdma_accept" [drivers/block/drbd/drbd_transport_rdma.ko] undefined! > ERROR: modpost: "rdma_create_qp" [drivers/block/drbd/drbd_transport_rdma.ko] undefined! > > Address this by moving the logic from Makefile into Kconfig and > describing the two conditions in which rdma transport can be used > in drbd. > > Fixes: 038cb6e644e4 ("drbd: add RDMA transport implementation") > Signed-off-by: Arnd Bergmann > --- > drivers/block/drbd/Kconfig | 5 +++++ > drivers/block/drbd/Makefile | 2 +- > 2 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/block/drbd/Kconfig b/drivers/block/drbd/Kconfig > index 377f0d040031..29ec6ed84251 100644 > --- a/drivers/block/drbd/Kconfig > +++ b/drivers/block/drbd/Kconfig > @@ -39,6 +39,11 @@ config BLK_DEV_DRBD > > If unsure, say N. > > +config DRBD_TRANSPORT_RDMA > + tristate > + depends on RDMA=y || (BLK_DEV_DRBD=RDMA) > + default BLK_DEV_DRBD > + > config DRBD_FAULT_INJECTION > bool "DRBD fault injection" > depends on BLK_DEV_DRBD > diff --git a/drivers/block/drbd/Makefile b/drivers/block/drbd/Makefile > index 99a1cfeed423..caf888235d53 100644 > --- a/drivers/block/drbd/Makefile > +++ b/drivers/block/drbd/Makefile > @@ -13,4 +13,4 @@ obj-$(CONFIG_BLK_DEV_DRBD) += drbd.o > > obj-$(CONFIG_BLK_DEV_DRBD) += drbd_transport_tcp.o > obj-$(CONFIG_BLK_DEV_DRBD) += drbd_transport_lb-tcp.o > -obj-$(if $(CONFIG_BLK_DEV_DRBD),$(if $(CONFIG_INFINIBAND),m)) += drbd_transport_rdma.o > +obj-$(CONFIG_DRBD_TRANSPORT_RDMA) += drbd_transport_rdma.o Seems like we raced here, I already (supposedly?) fixed this on the drbd-next branch. My fix is this Kconfig: config BLK_DEV_DRBD_RDMA tristate "DRBD RDMA transport" depends on BLK_DEV_DRBD && INFINIBAND_ADDR_TRANS help RDMA transport support for DRBD. This enables DRBD replication over RDMA-capable networks for lower latency and higher throughput. If unsure, say N. And then just this in the Makefile: obj-$(CONFIG_BLK_DEV_DRBD_RDMA) += drbd_transport_rdma.o That should be equivalent, right? Thanks, Christoph -- Christoph Böhmwalder LINBIT | Keeping the Digital World Running DRBD HA — Disaster Recovery — Software defined Storage