From: "Arnd Bergmann" <arnd@arndb.de>
To: "Frank Li" <Frank.Li@oss.nxp.com>,
"Ulf Hansson" <ulfh@kernel.org>,
"Aubin Constans" <aubin.constans@microchip.com>,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Claudiu Beznea" <claudiu.beznea@tuxon.dev>,
"Paul Cercueil" <paul@crapouillou.net>,
"Russell King" <linux@armlinux.org.uk>,
"Frank Li" <Frank.Li@nxp.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"Aaro Koskinen" <aaro.koskinen@iki.fi>,
"Andreas Färber" <afaerber@suse.de>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
"Jesper Nilsson" <jesper.nilsson@axis.com>,
"Lars Persson" <lars.persson@axis.com>,
"Johan Hovold" <johan@kernel.org>, "gordon.ge" <gordon.ge@bst.ai>,
"Vinod Koul" <vkoul@kernel.org>,
"yangzh0906@thundersoft.com" <yangzh0906@thundersoft.com>,
"Jared Kangas" <jkangas@redhat.com>,
"Brian Masney" <bmasney@redhat.com>,
"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
"Linus Walleij" <linusw@kernel.org>,
"Fan Wu" <fanwu01@zju.edu.cn>, "Rosen Penev" <rosenp@gmail.com>,
"Pengpeng Hou" <pengpeng@iscas.ac.cn>,
"Marco Crivellari" <marco.crivellari@suse.com>,
"Pedro Demarchi Gomes" <pedrodemargomes@gmail.com>,
"Zhan Xusheng" <zhanxusheng1024@gmail.com>,
"Pan Chuang" <panchuang@vivo.com>,
"Khalid Aziz" <khalid@kernel.org>,
"Ethan Nelson-Moore" <enelsonmoore@gmail.com>,
"Rakuram Eswaran" <rakuram.e96@gmail.com>,
"Takashi Sakamoto" <o-takashi@sakamocchi.jp>,
"Runyu Xiao" <runyu.xiao@seu.edu.cn>,
"Matthew Wilcox" <willy@infradead.org>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"linux-mmc @ vger . kernel . org" <linux-mmc@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>,
"moderated list:ARM/Microchip (AT91) SoC support"
<linux-arm-kernel@lists.infradead.org>,
"open list:INGENIC JZ47xx SoCs" <linux-mips@vger.kernel.org>,
"open list:ARM/FREESCALE IMX / MXC / LAYERSCAPE ARM ARCHIT..."
<imx@lists.linux.dev>, Linux-OMAP <linux-omap@vger.kernel.org>,
"moderated list:ARM/ACTIONS SEMI ARCHITECTURE"
<linux-actions@lists.infradead.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"open list:ARM/ARTPEC MACHINE SUPPORT"
<linux-arm-kernel@axis.com>
Subject: Re: [PATCH v4 1/1] mmc: use dmaengine_get_dma_device() instead of chan->device->dev
Date: Wed, 23 Sep 2026 20:57:04 +0200 [thread overview]
Message-ID: <eebb66fa-12e2-4553-8edf-d131b84a8aba@app.fastmail.com> (raw)
In-Reply-To: <20260923184612.3583132-1-Frank.Li@oss.nxp.com>
On Wed, Sep 23, 2026, at 20:45, Frank.Li@oss.nxp.com wrote:
> @@ -214,7 +214,7 @@ config MMC_SDHCI_OF_AT91
> config MMC_SDHCI_OF_ESDHC
> tristate "SDHCI OF support for the Freescale eSDHC controller"
> depends on MMC_SDHCI_PLTFM
> - depends on PPC || ARCH_MXC || ARCH_LAYERSCAPE || COMPILE_TEST
> + depends on PPC || ARCHMXC || ARCH_LAYERSCAPE || COMPILE_TEST
> select MMC_SDHCI_IO_ACCESSORS
> select FSL_GUTS
This looks like an accidental bug that should be removed from the patch.
> @@ -961,7 +961,7 @@ static void atmci_dma_cleanup(struct atmel_mci *host)
> struct mmc_data *data = host->data;
>
> if (data)
> - dma_unmap_sg(host->dma.chan->device->dev,
> + dma_unmap_sg(dmaengine_get_dma_device(host->dma.chan),
> data->sg, data->sg_len,
> mmc_get_dma_dir(data));
Since you have the exact construct in a lot of drivers, would
it make sense to take this one step further and introduce
a new set of helpers in drivers/dma/dmaengine.h, such as
unsigned int dmaengine_map_sg(struct dma_chan *chan, struct scatterlist *sg, ...);
Arnd
next prev parent reply other threads:[~2026-09-23 19:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 18:45 Frank.Li
2026-09-23 18:50 ` Frank Li
2026-09-23 18:57 ` Arnd Bergmann [this message]
2026-09-23 19:33 ` Frank Li
2026-09-23 21:40 ` Frank Li
2026-09-23 23:01 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eebb66fa-12e2-4553-8edf-d131b84a8aba@app.fastmail.com \
--to=arnd@arndb.de \
--cc=Frank.Li@nxp.com \
--cc=Frank.Li@oss.nxp.com \
--cc=aaro.koskinen@iki.fi \
--cc=afaerber@suse.de \
--cc=alexandre.belloni@bootlin.com \
--cc=aubin.constans@microchip.com \
--cc=bmasney@redhat.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=enelsonmoore@gmail.com \
--cc=fanwu01@zju.edu.cn \
--cc=festevam@gmail.com \
--cc=gordon.ge@bst.ai \
--cc=imx@lists.linux.dev \
--cc=jesper.nilsson@axis.com \
--cc=jkangas@redhat.com \
--cc=johan@kernel.org \
--cc=kernel@pengutronix.de \
--cc=khalid@kernel.org \
--cc=lars.persson@axis.com \
--cc=linusw@kernel.org \
--cc=linux-actions@lists.infradead.org \
--cc=linux-arm-kernel@axis.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mani@kernel.org \
--cc=marco.crivellari@suse.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=nicolas.ferre@microchip.com \
--cc=o-takashi@sakamocchi.jp \
--cc=panchuang@vivo.com \
--cc=paul@crapouillou.net \
--cc=pedrodemargomes@gmail.com \
--cc=pengpeng@iscas.ac.cn \
--cc=rakuram.e96@gmail.com \
--cc=rosenp@gmail.com \
--cc=runyu.xiao@seu.edu.cn \
--cc=s.hauer@pengutronix.de \
--cc=u.kleine-koenig@baylibre.com \
--cc=ulfh@kernel.org \
--cc=vkoul@kernel.org \
--cc=willy@infradead.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=yangzh0906@thundersoft.com \
--cc=zhanxusheng1024@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®