From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDBB53E868F for ; Tue, 14 Apr 2026 14:28:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776176913; cv=none; b=qpfSTkjoMa0VhFLU4LrpQDdkP6uLTRH5yc5LVVwpFtL+KA2lIp7Sv6F3lpI49XrufL1HqgCp/WqIvP+UWOTUwENThQJRB/enswZq9N6tsOvOYCDE76RJ/Hj2QGZyCHFUBLezjwWfs9+bUm6dkabdRFOJ6QXC0Bk+tkgIsrZ/9lQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776176913; c=relaxed/simple; bh=S9LGzVX1aV8DIfzInqythzN3CdNAxnj5Oi0uk/Mrr4E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=I3iESD5a3tR6LlRFpXx/qMxwXNXfzRIAVEPrEudsLcp0eds6Q9LXeqqm/cU4Iu8u3sbHdXSz91kI4BTQsbdRI6A0XkCk135+3PMvXgka9fjfnZ/NejvLKXnL9DddCcbvbcMnX62GPRPV3nCbNUTp3ul2GQbJiFpZbcSFs9WguBA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=P1kk1sNQ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=I7iz5PSV; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="P1kk1sNQ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="I7iz5PSV" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63EA45cB030012 for ; Tue, 14 Apr 2026 14:28:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= d4h/bSO/ywHvkpULu8zqbn2UT6WifoipO/Bcqnz4RFQ=; b=P1kk1sNQ1Kjd16G/ EsTz/FryVDczRexmWIYsCZFvDTV8xzXxKuijCUvH/c2tM0OwAem2iofOu2LbT6Xl m89a5ASsLX+bH9LMO03wejmc/NkqCX4cV14bCownHt/xnKcSUz1QhBG2q/EaAiWs bZOu5+k6g4pRycBJobjO4Z0tbvsWiwH4YeC7tvBqWZAy+RrSLn70zu3BMqBQhU1a AEmm4jJQDG3NC5vpprDtNLRtRR1HppC02uRRhDNfZ7QEJCgzHaFp0F+niI/HNjVw E//1EsAIzE1/ABDKO2lZobp3Q8CmvNPBSrR1BRJPprRe+50D9u4VbUITs+9qXSFR ug+l3Q== Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dhkgmgu85-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 14 Apr 2026 14:28:30 +0000 (GMT) Received: by mail-vs1-f70.google.com with SMTP id ada2fe7eead31-6055c46b2c8so306376137.0 for ; Tue, 14 Apr 2026 07:28:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776176910; x=1776781710; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=d4h/bSO/ywHvkpULu8zqbn2UT6WifoipO/Bcqnz4RFQ=; b=I7iz5PSVbwMBbC0lZbZQnyqv1cibo7bAIOD9pdpqFZqdGgx6szM04UfMjtwW/JKBfH sGOgs0HmhvJy5HVMfjyuy82VtRKbcMt1Y+SaYxvCTW8SygIcLODjLoH0D0iUZXTUGgTA Nba/51Ccmu9W7XizWvnRDn4vyMSjdfSRnlQJCFzunRLxUKUQ+MeJc+dG0NngpwfMxArU cYhSks/b0Av3Clk62AkfY4UJlooNYVf2QwVkcIataKp5TUtwF+/obP+p3/FXh9FfwEIr IrzFTSTXwr5osevAbRdykhIAc5/Ay7pJPrMqHH+pJLFVLgALVh2wr3TZrBkhU1OMbdQg TUUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776176910; x=1776781710; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=d4h/bSO/ywHvkpULu8zqbn2UT6WifoipO/Bcqnz4RFQ=; b=Dj4C2ASI5nTQYOSGhZIYJM1pLMdtBXCKqrSJ7/uvHqQIJk65o5LW5k7ZbTTutuZDZ7 V8ux1OQ8bTaHpTiINSbX5GByAYN3zdr0baWOZc/gFgrxEpE03HXIVOGHwEbm6yb9d0Pj bs9MKwV7v8yvRNikvq2GGA2XSp/Emwqpl+rlXxzVUa9sDlZ4RYf4GJj5ueJe/H5D8GOx zgdzPTlhfWhRNtFhvXzyqEACV0Jiq0Z+MslfznzEOUrfd4eq+qc4VT4xSlXCJamC4JaQ HxheBUR8LCw7wMh02rhfL/EuG02ClRXkCG+3UO8Y4AAFqCFeRZRP7yhq2v5RbOm3LYJe rtpA== X-Forwarded-Encrypted: i=1; AFNElJ8F+/2n5cUJQNi4/knO4n8JQTU7NIuGlr3/4A4gGCoacWWH3tgXT6p0wu3h9jVK70eTP9WstBEeWO2db+U=@vger.kernel.org X-Gm-Message-State: AOJu0Yxu7QqYwKjvujoZ4WW+JoX4PRwEn++sd2z7tY6mrPG9PQG9yYn3 Wz5cDTTsJzJSPzhyhjnknCBGrd1WRYsrgJ6TK8dQkUeBwZ9D5TTrMT0xXn1j/DM/RANdVnA9hYA NKKQHLo6qGHSuJTqtzXHWXixuHwkvWUq414YZVzG9n1PG0gfizY7UInvcPi7xiWcamhE= X-Gm-Gg: AeBDietcT8C/71dSxggEbsCspLPRNxdXxzbTibzlwTOKw7Pl1QYO+5fvqOIbUxUd+WU nE2ecS5FXHgprBOOCulS/28X23as07WnVjLg7IbSH+drm/1gq/PlcXemgRDOnaTzQpzNsMEFGe6 Wnp5/gyYcLao1appFnEM7CjUmsa1hT6NDoWX+62ZcR7rwL3ATAsm7yLyhAMcaSey17OJ9LOaBl8 Q1pUVNqksKHkJJOuU8b2WXRVvOhWrCFOxUKXT3bawGcWWJcconaq8qMnCejywMH9BatcP0OMwxA E57AA+vA+kd0i6Tn236W2S4OZhhDv+gGlwTbmA7y3F33EWI03ue7u9fKAex8slrHAWtaxHgxUX3 b1uSCMImiKdNeabqOyybCfKBDFNp5Ay+/+XfUjadBatnBnnKS3Lcf5WqWwBCyC5U+jxSNjh6NwK FeJffB73ssloNFOQ== X-Received: by 2002:a05:6102:31b4:b0:606:2f5:7b49 with SMTP id ada2fe7eead31-60a0169097fmr2647060137.7.1776176910067; Tue, 14 Apr 2026 07:28:30 -0700 (PDT) X-Received: by 2002:a05:6102:31b4:b0:606:2f5:7b49 with SMTP id ada2fe7eead31-60a0169097fmr2647051137.7.1776176909545; Tue, 14 Apr 2026 07:28:29 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9d6dfd76b8sm409854766b.20.2026.04.14.07.28.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Apr 2026 07:28:28 -0700 (PDT) Message-ID: Date: Tue, 14 Apr 2026 16:28:25 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/6] drm/msm/a6xx: Limit GXPD votes to recovery in A8x To: Akhil P Oommen Cc: Ajit Pandey , Imran Shaik , Jagadeesh Kona , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Taniya Das , Bjorn Andersson , Michael Turquette , Stephen Boyd , Abel Vesa , Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter References: <20260407-gfx-clk-fixes-v1-0-4bb5583a5054@oss.qualcomm.com> <20260407-gfx-clk-fixes-v1-6-4bb5583a5054@oss.qualcomm.com> <8f5ffecc-007e-4a8a-9c5e-9994e7841659@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE0MDEzNiBTYWx0ZWRfX4E7ufePCgBUV 1JXgYhWtxmnZ8D9K8U2H1OU1yoTwz+95oSVcUaENRsjAso0rWXPMJnCe6yQv3Y0obkVNNM6+3wK mUSrTYQUUJzUrVJgueiDJWYo8kKlr4JpncZjY0+YTidvvpA3b/+11YL8M1C1ylR6TLoi4biKaib 5ClHftO+00lcEvU0h90FMMpXv7QIogxR6JKTD7AY80Of/cJYBOq6g98PW4gjZjKge9E6JkUJJu6 jUgRjS769ld0Gazs3m+qfdXEnu34qBEyFMbGMKfxQS3WRtivuDXer8TUYSlzY+vGuTIpInuFsyM lrjgdoRZCQCiV4BV65bbfw6hXPmxsqml/jGaJqID5DxJgIC4rukb8bm0R22OorFLQk6dkNBWqCk QvYPE7mhQIElZaQh/6nNqZ5lgvA8gkC9zzWi9r2AqNH96gi/6XbmEcAs9gHqwZhr7tdQNm1+Nlp JCrp9LW8RCzsBTR6F7g== X-Proofpoint-ORIG-GUID: NtBM0lrkfo_YD-ITECUCEoBr5cWdB83- X-Proofpoint-GUID: NtBM0lrkfo_YD-ITECUCEoBr5cWdB83- X-Authority-Analysis: v=2.4 cv=HJLz0Itv c=1 sm=1 tr=0 ts=69de4f0e cx=c_pps a=N1BjEkVkxJi3uNfLdpvX3g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=NcxxfY7wZcMA6x9h_jEA:9 a=QEXdDO2ut3YA:10 a=crWF4MFLhNY0qMRaF8an:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-14_03,2026-04-13_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 bulkscore=0 priorityscore=1501 impostorscore=0 clxscore=1015 malwarescore=0 phishscore=0 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604140136 On 4/7/26 9:16 PM, Akhil P Oommen wrote: > On 4/7/2026 4:31 PM, Konrad Dybcio wrote: >> On 4/7/26 11:30 AM, Taniya Das wrote: >>> From: Akhil P Oommen >>> >>> In A8x GPUs, the GX GDSC is moved to a separate block called GXCLKCTL >>> which is under the GX power domain. Due to the way the support for this >>> block is implemented in its driver, pm_runtime votes result in a vote on >>> GX/GMxC/MxC rails from the APPS RSC. This is against the Adreno >>> architecture which require GMU to be the sole voter of these collapsible >>> rails on behalf of GPU, except during the GPU/GMU recovery. >>> >>> To align with this architectural requirement and to realize the power >>> benefits of the IFPC feature, remove the GXPD votes during gmu resume >>> and suspend. And during the recovery sequence, enable/disable the GXPD >>> along with the 'synced_poweroff' genpd hint to force collapse this GDSC. >>> >>> Signed-off-by: Akhil P Oommen >>> Signed-off-by: Taniya Das >>> --- >> >> Can we simply make this change unconditional on the gen, so as not to >> maintain 2 separate code paths that try to achieve mostly the same thing? > > We can skip the gdsc vote on A8x because the 'gdsc disable' callback is > dummy when the synced_poweroff hint is not set. Otherwise, gdsc may get > disabled during system resume while GMU assumes the ownership. Taniya > touched upon this point in the cover letter: > > """ > when GX GDSC is managed through the generic GenPD runtime PM > framework, it can be unintentionally disabled by the OS during system > resume (resume_noirq/complete phases) or runtime PM suspend paths. > """ Right, but if we made the GDSC.disable() a dummy on all platforms this could be done. On a second thought though, this won't work for gmu_wrapper, so we'd need two paths either way. Konrad