From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 248983E8C6F for ; Tue, 2 Jun 2026 14:15:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780409719; cv=none; b=fTz9uJXJ9xtvKmfSmaNjnncJX0PaP9rOAF3aJG+O1NDYF0A4ku3AVCU4p97wQp01Op0iIIsYbQ7Etpud48UzzzTvVC0C5QCX40T/spxQD37x2PS+ojzby6RXXWKwYUHjcYgtBxxhUrbeJA6fE9I81fxI8YGaP3dPDPkECBPS2t0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780409719; c=relaxed/simple; bh=+bRWQ7jS5XI2AqaKdYGwvaDnh/B8rKl0KZwNL3xsANQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tlfi0B+bR0JKqLsI4huhcOBb9oiaB/Gcv5+BiQaMa/UexlmV1JnrLvNS857dvpnucnSVw9cs+EC0fQCStUI7aHWqreT2c3Baknt70wacL8PiKeTLh1AiIj/iRQPHSu+1SY4XeI4vGSfMdXAkUw/HCCFOZrV6A62RX6Yj5fZKJo4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FzIndssp; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FzIndssp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 350351F00898; Tue, 2 Jun 2026 14:15:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780409717; bh=/S4uTVapdLU0sd/YpjekF5puLg0al+/sVtt11aPqiOI=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=FzIndssp7qs0XOpfNQP7xODvHhiCA4sd2B8t7A4BBMUHo13opUuKf3yzyFs8gJZ// m+7x4nzbYuCsG422mDvp5dlrstqZ4MLGaVuYRh85lykUjzJUjnNfzGtZvWybmVGAsT pfE+tWx5R1Sbgt0EuykzjFHH5+q/0i5dnbeHO1Pbo8KK9xbCLeiidFh5IFfrJ5qFq9 vp6lHUf0v0/PBQ0Igik6t7zvvkXJUdHbkx4Xt9VJZgvQsd7H5TiBkh9XbrtsjsMbAE NEzDGGLvkEyzZoY4iTp/m96DKBSsmofecLSW1Lim7NENPM0eXMQtqhrw+kZJyCDnmU OrBLiOLV/OOeA== Message-ID: Date: Tue, 2 Jun 2026 09:15:16 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V1] accel/amdxdna: Preserve user address when PASID is disabled Content-Language: en-US To: Lizhi Hou , ogabbay@kernel.org, quic_jhugo@quicinc.com, dri-devel@lists.freedesktop.org, karol.wachowski@linux.intel.com Cc: linux-kernel@vger.kernel.org, max.zhen@amd.com, sonal.santan@amd.com References: <20260602040624.2206774-1-lizhi.hou@amd.com> From: Mario Limonciello In-Reply-To: <20260602040624.2206774-1-lizhi.hou@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/1/26 23:06, Lizhi Hou wrote: > When PASID is not used, the buffer user address is set to > AMDXDNA_INVALID_ADDR. As a result, heap buffer user address validation > fails even though the original userspace address is available. > > Preserve the userspace address regardless of PASID usage so heap buffer > address validation works correctly. > > Fixes: dbc8fd7a03cb ("accel/amdxdna: Add expandable device heap support") > Signed-off-by: Lizhi Hou Reviewed-by: Mario Limonciello (AMD) > --- > drivers/accel/amdxdna/amdxdna_gem.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/accel/amdxdna/amdxdna_gem.c b/drivers/accel/amdxdna/amdxdna_gem.c > index 77e5fad08ae5..33cf5af98ceb 100644 > --- a/drivers/accel/amdxdna/amdxdna_gem.c > +++ b/drivers/accel/amdxdna/amdxdna_gem.c > @@ -349,8 +349,11 @@ static int amdxdna_hmm_register(struct amdxdna_gem_obj *abo, > u32 nr_pages; > int ret; > > - if (!amdxdna_pasid_on(abo->client)) > + if (!amdxdna_pasid_on(abo->client)) { > + /* Need to set uva for heap uva validation */ > + abo->mem.uva = addr; > return 0; > + } > > mapp = kzalloc_obj(*mapp); > if (!mapp)