From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA5FA35B142 for ; Mon, 2 Feb 2026 10:51:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770029518; cv=none; b=UbjrlIbjx0FLRrBKlISP76a+/kpVflDvZbkBxaoWPLpmCNIXZP6FRDF4d0nE0Cix1rUZ6nhHE1HmomZujOjOgO9uZq0Suc30MYCXSV5kzSvHgVsh6FpnNlVOCUjtrsIB2VfT6ncjpUopmh7koKR05WOYxyBvwU3ktWwTHr2/vBU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770029518; c=relaxed/simple; bh=Kc7RpvO2p9800NM2B8CF++WyOv9JXZrDM9tlk4xzcm4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=m8ihqflKG1HJyIh0wiStOqwcnq7ISwHU0IBK/N6d9Vm62yPWBSB/ZAce3LvMD+o/0E8uoOvOatjuNHqdl0z1pa1IgCXQyrhy8GDqsTqOJuJc+lUo9wF2oHYQFB9D7O2d7+ZHFkTUj2/d9MPGyk0T45HawQnPna3UU4QV5F64dwA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JWDmjFgW; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MV5/hSCP; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JWDmjFgW"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MV5/hSCP" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6127XPNa623842 for ; Mon, 2 Feb 2026 10:51:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= R802QrSbqggRkvhWchXNMQ2bLskXi/9f6yPPn3WgdbA=; b=JWDmjFgWXGRa/e8c jv8R55oyCF3Gq/SNgIWYtWnFgUfTwN+ISwR0c2yuixkF5aHR642aYTyPBy0V7KYW Sk/z84uofVU24FwIzHibkvz+Q7Gea0dGDjocCFEDgoluZ/C6Jxr5wbxgw12MJ0D8 MCak22gVhrfZVgVaDk9P6qVtUoeFHfN7gdVw5FXjV57UQOnfQ5FgfDOmh0Sscbag UzI2bU8zkYfTpDWN3XHez5aTxolYaMR1J8EFZvfgx9r2C88dwWQMFHFGf00cEROu XTFjKs6VMQuAJmFn125Y7i2FFYV6UBa4cugZhjWv7MYRXvnVhmvnBIh2yk1kUb8J segFOg== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c1as4w595-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 02 Feb 2026 10:51:56 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-88880bc706cso17036436d6.2 for ; Mon, 02 Feb 2026 02:51:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770029515; x=1770634315; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=R802QrSbqggRkvhWchXNMQ2bLskXi/9f6yPPn3WgdbA=; b=MV5/hSCPna9ynvZovSwIE4++37oOQSB+hWgxOALiSCZyX1Og/U/WzuyyTkXibiYX3p lD1BBQ4GOVTBs9BHVBFrMUKeR6JInCaebQq36OHf7aucMooN7PEFj3uyQVHzuFhZky9l QCB4bjopdc8HMyUm8zvZwrkPXdYQDVmGhKUKp2Qs96NB1LOp7gtkEnkmFXcwZV5kN+vI 5aWy//3lTywX2mHBbb3GzhOs2r/RWET61b2X4XPNIp8tVSFlOHQ2TbPcBh9HPqeylF/7 SmM3ilftZ8KseLTmqN3H+SLVWt1rznrorTEQn4lGtA9K8SWshy3fFTg+vy/rP7YA08IV E/gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770029515; x=1770634315; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=R802QrSbqggRkvhWchXNMQ2bLskXi/9f6yPPn3WgdbA=; b=Gmk3wNlIhqrC9Mwcu7Ks3r/B426Sy3Fj03TVwzXvkXMwNheqZjt9P41Ba/uGjMvqxF 6+uaa53BS9pzVrhnuGIs7buY1aGnEjxQS9CAUL/DI7qenu7rapCPbEbMw5XTN3I31J8G yYvHtPha8D4Wm6wnH8y9r3xx0oh+cm53ZqGq964Abd3kX9L6JFr//oNJzxX9eI6g5pl+ n7v5diJj4UU1tFCuByntHL1rylxqY0FZHRr4Ndk0Xehd1algm8BzBlV7VqqryVw9icWs 0lrPTH8imW8zLP0usrLpN5D4w787JZREViN/cgVW6UXHHFQs9cVvjzg0nsr1mjkRZW3m qp7w== X-Forwarded-Encrypted: i=1; AJvYcCUgWSNpn745Ta4OLY5FDoRJIcE9bH8EAUnYtsJ3qzy9YLdFFCF8Z0/hkUCx898dVZHDy+nPvAPAcdOsHZg=@vger.kernel.org X-Gm-Message-State: AOJu0YyYdz1KOicoD67IUFMfI1aKXlhcqReOYD51v7jpGsFgr0I4JnFi xiVi1vOv3s5QSic5zh+5jgEjFpIIPfI+3Kv0IYYLmle6l/KMILB8sadbh7T0IzfS/K6PApIAS7B 7fkvE5H/hhAIpj1WOs6mReCZu5uSt9jNIfJNsfSWBbnYd7XWae3SgEm+AElrLRF7eZWs= X-Gm-Gg: AZuq6aLORqbzGo+NJ+QKQul0pmRdIFaIbN8jGyZELAvRfQxRh6XhFNswYMaNCk9YVex xoRBrCozJ6kCUupTn+D7BynL7keMe8wcHFnu/h8WeyTy80ufKY1Ee2yt00ogp/hBulIk8AxTUHt YCHXaXrL/F0LFco/KQSGUpQnG3VjmeSfgH9TL34C0S09M5cjr1L7cUzaJ93Ptsy70kI7vruZdir e1AFGL4vwgyLKsnd8YcA12Y51bkco09uIi8++zTJsUBlIL77czGpy2QXm920CD3vmLalyEIKJ/0 vKsXNtbu7udE6HNegHQADq+hDjWnDB3suY97Y9ba/E0h0aGLlAR+s55A4AZ3lEA7dn3V5Z6naB/ +68HPDx+9v4+irJY0MQwIaVGasEPCvYLZv5srcS76FOEEtsTIZcAco/uLvFSWLmjhxDw= X-Received: by 2002:a05:620a:1998:b0:8ca:27f:3a70 with SMTP id af79cd13be357-8ca027f4ab1mr576184385a.2.1770029515006; Mon, 02 Feb 2026 02:51:55 -0800 (PST) X-Received: by 2002:a05:620a:1998:b0:8ca:27f:3a70 with SMTP id af79cd13be357-8ca027f4ab1mr576183485a.2.1770029514501; Mon, 02 Feb 2026 02:51:54 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-658b4453094sm7423905a12.14.2026.02.02.02.51.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Feb 2026 02:51:53 -0800 (PST) Message-ID: Date: Mon, 2 Feb 2026 11:51:51 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] soc: qcom: ice: Stop probe deferring once ICE isn't detected To: Sumit Garg , linux-arm-msm@vger.kernel.org, Dmitry Baryshkov Cc: andersson@kernel.org, konradybcio@kernel.org, robh+dt@kernel.org, abelvesa@kernel.org, mani@kernel.org, linux-kernel@vger.kernel.org, Sumit Garg References: <20260202082534.121042-1-sumit.garg@kernel.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260202082534.121042-1-sumit.garg@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: DyH1ZzGwCURTB_5V9mDAepQIHvzJHy1t X-Proofpoint-GUID: DyH1ZzGwCURTB_5V9mDAepQIHvzJHy1t X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjAyMDA4NyBTYWx0ZWRfX7d6afrW4uesF 9+Z0PoG1d2wAD/fGtDucOvm9JA3DmgSAwSunRl7vUV4j1cVyPLUN87+El8Kqn9M7Mf88+qiQNC8 0gXFPpqc4aoAxXECxHXR9VasvPcklbh9wz/5hLYZwg4d8KywUzCxE4u4rhyDLY2XknUVNJDlfTR A7inOACjjUMIoYWiZIkKIC7lteCBICqN+g2PGZLyDZ7/pT22lm91QyS1A7WyrEaTP6V/zxC8qB2 0MZRe2t30BOp6ZuAIARQ7pxovr8i0/x6IwDZSB8y+zPTowwQefdMxnWzD66U2Nq8lfW4hvKaM1j 7CTMmi5mjcwvatB9Hn/O9OyW30P1pW/r3DuhnVMeZX8LRMA5FNLQoxEQVDeNTY6StbGUfKQ9gqx 5mk0WTpUZ5KjI33Sg8GYpw3YLskONpE1WvfS3UeT11OO3fySp56oO++MXM/bNaZbelhE4+cw1o8 wmYH1Ib72xkGEM6VCLg== X-Authority-Analysis: v=2.4 cv=bIEb4f+Z c=1 sm=1 tr=0 ts=698081cc cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=7uNGO-3vnjYwkWKPlv4A:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-02_03,2026-01-30_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 malwarescore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 clxscore=1015 suspectscore=0 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602020087 On 2/2/26 9:25 AM, Sumit Garg wrote: > From: Sumit Garg > > ICE related SCM calls may not be supported in every TZ environment like > OP-TEE or a no-TZ environment too. So let's try to stop probe deferring > when it's known that ICE feature isn't supported. > > This problem only came to notice after the inline encryption drivers were > enabled in the arm64 defconfig by: commit 5f37788adedd ("arm64: defconfig: > Enable SCSI UFS Crypto and Block Inline encryption drivers"). > > Fixes: 2afbf43a4aec ("soc: qcom: Make the Qualcomm UFS/SDCC ICE a dedicated driver") > Signed-off-by: Sumit Garg > --- > > Changes in v2: > - Keep the probe deferring intact but stop it once it's know ICE SCM > calls aren't supported by the TZ firmware. > > drivers/soc/qcom/ice.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/drivers/soc/qcom/ice.c b/drivers/soc/qcom/ice.c > index b203bc685cad..5a630c9010ee 100644 > --- a/drivers/soc/qcom/ice.c > +++ b/drivers/soc/qcom/ice.c > @@ -559,7 +559,7 @@ static struct qcom_ice *qcom_ice_create(struct device *dev, > > if (!qcom_scm_ice_available()) { > dev_warn(dev, "ICE SCM interface not found\n"); > - return NULL; > + return ERR_PTR(-EOPNOTSUPP); > } > > engine = devm_kzalloc(dev, sizeof(*engine), GFP_KERNEL); > @@ -648,11 +648,14 @@ static struct qcom_ice *of_qcom_ice_get(struct device *dev) > } > > ice = platform_get_drvdata(pdev); > - if (!ice) { > + if (IS_ERR_OR_NULL(ice)) { > dev_err(dev, "Cannot get ice instance from %s\n", > dev_name(&pdev->dev)); > platform_device_put(pdev); > - return ERR_PTR(-EPROBE_DEFER); > + if (PTR_ERR(ice) == -EOPNOTSUPP) > + return NULL; The consumer drivers check specifically for -EOPNOTSUPP, let's just return that > + else > + return ERR_PTR(-EPROBE_DEFER); > } > > link = device_link_add(dev, &pdev->dev, DL_FLAG_AUTOREMOVE_SUPPLIER); > @@ -726,7 +729,7 @@ static int qcom_ice_probe(struct platform_device *pdev) > } > > engine = qcom_ice_create(&pdev->dev, base); > - if (IS_ERR(engine)) > + if (IS_ERR(engine) && PTR_ERR(engine) != -EOPNOTSUPP) > return PTR_ERR(engine); This essentially says "probe succeeded, device not operational", I have mixed feelings.. That said I'm not sure about the lifecycle of a platform_device, i.e. can we set the drvdata and return an error in .probe anyway? Konrad > > platform_set_drvdata(pdev, engine);