From: "Christian König" <christian.koenig@amd.com>
To: "Philipp Stanner" <phasta@kernel.org>,
"Neill Kapron" <nkapron@google.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Al Viro" <viro@zeniv.linux.org.uk>,
"Paul Cercueil" <paul@crapouillou.net>,
"Nuno Sá" <nuno.sa@analog.com>, "Sam Day" <me@samcday.com>,
"Michael Bommarito" <michael.bommarito@gmail.com>,
"Gabriel Prostitis" <prostitisgabriel@gmail.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] usb: gadget: f_fs: Remove deprecated dma_fence->ops
Date: Fri, 30 Oct 2026 10:08:38 +0100 [thread overview]
Message-ID: <eece89ab-37b7-426a-bba7-32aa1b00ef10@amd.com> (raw)
In-Reply-To: <20261029125143.1744481-2-phasta@kernel.org>
On 10/29/26 13:51, Philipp Stanner wrote:
> The dma_fence_ops function ops->release() has been deprecated because it
> prevents drivers from unloading. f_fs's implementation merely frees the
> fence. The dma_fence backend performs this deallocation automatically in
> the correct manner if ops->release() is not implemented.
>
> The backend simultaneously correctly frees struct ffs_dma_fence since
> struct dma_fence is its base class.
>
> Remove ops->release().
>
> Signed-off-by: Philipp Stanner <phasta@kernel.org>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/usb/gadget/function/f_fs.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c
> index c64a268e98a4..e8672b37e890 100644
> --- a/drivers/usb/gadget/function/f_fs.c
> +++ b/drivers/usb/gadget/function/f_fs.c
> @@ -1479,18 +1479,9 @@ static const char *ffs_dmabuf_get_timeline_name(struct dma_fence *fence)
> return "";
> }
>
> -static void ffs_dmabuf_fence_release(struct dma_fence *fence)
> -{
> - struct ffs_dma_fence *dma_fence =
> - container_of(fence, struct ffs_dma_fence, base);
> -
> - kfree(dma_fence);
> -}
> -
> static const struct dma_fence_ops ffs_dmabuf_fence_ops = {
> .get_driver_name = ffs_dmabuf_get_driver_name,
> .get_timeline_name = ffs_dmabuf_get_timeline_name,
> - .release = ffs_dmabuf_fence_release,
> };
>
> static int ffs_dma_resv_lock(struct dma_buf *dmabuf, bool nonblock)
prev parent reply other threads:[~2026-10-30 9:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 12:51 Philipp Stanner
2026-10-29 13:19 ` Paul Cercueil
2026-10-29 13:49 ` Philipp Stanner
2026-10-29 14:18 ` Paul Cercueil
2026-10-30 9:23 ` Christian König
2026-10-30 9:08 ` Christian König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eece89ab-37b7-426a-bba7-32aa1b00ef10@amd.com \
--to=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=me@samcday.com \
--cc=michael.bommarito@gmail.com \
--cc=nkapron@google.com \
--cc=nuno.sa@analog.com \
--cc=paul@crapouillou.net \
--cc=phasta@kernel.org \
--cc=prostitisgabriel@gmail.com \
--cc=sumit.semwal@linaro.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®