mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Neil Armstrong <neil.armstrong@linaro.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>
Cc: Marijn Suijten <marijn.suijten@somainline.org>,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soc: qcom: socinfo: Add SM8550-adjacent PMICs
Date: Thu, 31 Aug 2023 12:08:05 +0200	[thread overview]
Message-ID: <eecf028e-5fd9-4811-821f-35e87955ef3d@linaro.org> (raw)
In-Reply-To: <20230830-topic-pm8550abcxyz-v1-1-3c3ef3d92d51@linaro.org>

Hi,

On 30/08/2023 04:42, Konrad Dybcio wrote:
> Many of the PMICs were missing, add some of them often coupled with
> SM8550.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> Please somebody double-check, this was sorta reverse-engineered..
> ---
>   drivers/soc/qcom/socinfo.c | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
> index 497cfb720fcb..067d28924ca2 100644
> --- a/drivers/soc/qcom/socinfo.c
> +++ b/drivers/soc/qcom/socinfo.c
> @@ -117,6 +117,12 @@ static const char *const pmic_models[] = {
>   	[55] = "PM2250",
>   	[58] = "PM8450",
>   	[65] = "PM8010",
> +	[69] = "PM8550VS",
> +	[70] = "PM8550VE",
> +	[71] = "PM8550B",
> +	[72] = "PMR735D",
> +	[73] = "PM8550",
> +	[74] = "PMK8550",

I checked and those IDs are correct:

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

>   };
>   
>   struct socinfo_params {
> 
> ---
> base-commit: ae782d4e2bf53b0b642ae860794f7a39470f995a
> change-id: 20230830-topic-pm8550abcxyz-73346b3ab9a6
> 
> Best regards,


  reply	other threads:[~2023-08-31 10:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-30  2:42 Konrad Dybcio
2023-08-31 10:08 ` Neil Armstrong [this message]
2023-09-14 16:04 ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eecf028e-5fd9-4811-821f-35e87955ef3d@linaro.org \
    --to=neil.armstrong@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marijn.suijten@somainline.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®