From: <Claudiu.Beznea@microchip.com>
To: <andrew@lunn.ch>
Cc: <Nicolas.Ferre@microchip.com>, <davem@davemloft.net>,
<kuba@kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] net: macb: add support for mii on rgmii
Date: Fri, 17 Sep 2021 13:29:20 +0000 [thread overview]
Message-ID: <eedae6e6-07d3-23ec-1f15-d928f3506257@microchip.com> (raw)
In-Reply-To: <YUNAqSz3sUPqoGx6@lunn.ch>
Hi Andrew,
On 16.09.2021 16:03, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On Wed, Sep 15, 2021 at 09:47:21AM +0300, Claudiu Beznea wrote:
>> Cadence IP has option to enable MII support on RGMII interface. This
>> could be selected though bit 28 of network control register. This option
>> is not enabled on all the IP versions thus add a software capability to
>> be selected by the proper implementation of this IP.
>
> Hi Claudiu
>
> You are adding a feature without a user. That is generally not
> accepted.
That's true. For whatever reason I haven't added proper flags to
macb_config objects. I've send a new version with updates.
Thank you for your review,
Claudiu Beznea
> Could you please also extend one of the macb_config structs
> to make use of this?
>
> Thanks
> Andrew
>
prev parent reply other threads:[~2021-09-17 13:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 6:47 [PATCH 0/3] net: macb: add support for MII on RGMII interface Claudiu Beznea
2021-09-15 6:47 ` [PATCH 1/3] net: macb: add description for SRTSM Claudiu Beznea
2021-09-15 7:55 ` Nicolas.Ferre
2021-09-15 6:47 ` [PATCH 2/3] net: macb: align for OSSMODE offset Claudiu Beznea
2021-09-15 7:44 ` Nicolas.Ferre
2021-09-15 6:47 ` [PATCH 3/3] net: macb: add support for mii on rgmii Claudiu Beznea
2021-09-15 7:45 ` Nicolas.Ferre
2021-09-16 13:03 ` Andrew Lunn
2021-09-17 13:29 ` Claudiu.Beznea [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eedae6e6-07d3-23ec-1f15-d928f3506257@microchip.com \
--to=claudiu.beznea@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®