From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56A98ECAAD3 for ; Fri, 9 Sep 2022 11:39:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231336AbiIILi6 (ORCPT ); Fri, 9 Sep 2022 07:38:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231186AbiIILif (ORCPT ); Fri, 9 Sep 2022 07:38:35 -0400 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4FFE413D78D for ; Fri, 9 Sep 2022 04:38:19 -0700 (PDT) Received: by mail-wm1-x32f.google.com with SMTP id j26so1150233wms.0 for ; Fri, 09 Sep 2022 04:38:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=isovalent-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=HvNKBTw0L/lYKmZR35x7IEnP1bjDVpSzTqXAf0c4eyQ=; b=hmTnARBjoVStgQoPxT+j+rNvvQExGkJUi8pElnu3loRhAvKdMMUnJGmzWir30PUFdv qjpL2owE2PEG+kjT91XR1f47XCYDqVQuKNotrojQ64KoZuMEULKs1iE1G/yV6zV35RA2 9sRfFk/1Igbk6vL1pxVzIcoXDho55Mhc6HEU6Sx2Vj1JJeDdUXOsaa59A2vo6HZj5vbq EczrmMLkIqcDxMpgpKyinY+pR/yjG7s+LMBO8fahuge8LD0DZERNkXqmULXwR3FMQoRr VBmsFut3XZwiySh18vSk6VGcSrohbjasBSS1+DJqwpRYOXnx6ACSiZfxo74k1EKLCJWW iyvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=HvNKBTw0L/lYKmZR35x7IEnP1bjDVpSzTqXAf0c4eyQ=; b=eARnuXbsoBB/T7iCbliaC2BxHZLFAwGEWdgZyJpAvY4Q5uqL6UtuYoVA/hcSvju5IX hQDhrGvSvIWrrDZtEUC4YlYP1zVHXNEIwCnAzw7ZNPcRJLCDpF3pYxQ6hZ1ba1DNNnNZ 7xonC5iULOTQgIazxCqQxNpcumq8CGDT+8ieb1Bv4u9t6O69IzrrozcWR95Et5tobhWs ibDPxVIm/o7m636E3ClnuFC34pvmX3gYKZo80X/YViN6E9yd98q1sTDvkHQuDe1UdbSu +vq34oRpWbtqbPCKuud7uhE04JMnyRamzDgwRA1AYGUM5ISycWlhS6cofrBFIm0d5TrZ TkKA== X-Gm-Message-State: ACgBeo0I7ksCef8mxJ5FSrNK9DyWQDdqHQ05QLFCM7kTp+G66IN95D1m 0wHaqKmsnifcSkMfyWSGFyK2iQ== X-Google-Smtp-Source: AA6agR6ewvI4AXAvJtuQJzJV59HWk2gIoDBJ36WJdwkW12wvrg1/2LHRVT+8GbeMODjwSeXSCWlyLA== X-Received: by 2002:a05:600c:1497:b0:3a5:f608:d765 with SMTP id c23-20020a05600c149700b003a5f608d765mr4946577wmh.19.1662723497872; Fri, 09 Sep 2022 04:38:17 -0700 (PDT) Received: from [192.168.178.32] ([51.155.200.13]) by smtp.gmail.com with ESMTPSA id j12-20020a05600c190c00b003b332a7bf15sm550688wmq.7.2022.09.09.04.38.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Sep 2022 04:38:17 -0700 (PDT) Message-ID: Date: Fri, 9 Sep 2022 12:38:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [bpf-next v3 2/2] bpftool: Update doc (add auto_attach to prog load) Content-Language: en-GB To: Wang Yufen , ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, song@kernel.org, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com, haoluo@google.com, jolsa@kernel.org, davem@davemloft.net, kuba@kernel.org, hawk@kernel.org, nathan@kernel.org, ndesaulniers@google.com, trix@redhat.com Cc: bpf@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, llvm@lists.linux.dev References: <1662704233-8805-1-git-send-email-wangyufen@huawei.com> From: Quentin Monnet In-Reply-To: <1662704233-8805-1-git-send-email-wangyufen@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/09/2022 07:17, Wang Yufen wrote: > Add auto_attach optional to prog load|loadall for supporting > one-step load-attach-pin_link. > > Signed-off-by: Wang Yufen > --- > tools/bpf/bpftool/Documentation/bpftool-prog.rst | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/tools/bpf/bpftool/Documentation/bpftool-prog.rst b/tools/bpf/bpftool/Documentation/bpftool-prog.rst > index eb1b2a2..c640ad3 100644 > --- a/tools/bpf/bpftool/Documentation/bpftool-prog.rst > +++ b/tools/bpf/bpftool/Documentation/bpftool-prog.rst > @@ -31,7 +31,8 @@ PROG COMMANDS > | **bpftool** **prog dump xlated** *PROG* [{**file** *FILE* | **opcodes** | **visual** | **linum**}] > | **bpftool** **prog dump jited** *PROG* [{**file** *FILE* | **opcodes** | **linum**}] > | **bpftool** **prog pin** *PROG* *FILE* > -| **bpftool** **prog** { **load** | **loadall** } *OBJ* *PATH* [**type** *TYPE*] [**map** {**idx** *IDX* | **name** *NAME*} *MAP*] [**dev** *NAME*] [**pinmaps** *MAP_DIR*] > +| **bpftool** **prog** { **load** | **loadall** } *OBJ* *PATH* [**type** *TYPE*] [**map** {**idx** *IDX* | **name** *NAME*} *MAP*] \ > +| [**dev** *NAME*] [**pinmaps** *MAP_DIR*] [**auto_attach**] Nit: Let's keep this on one line. Not necessary the best in the RST, but I prefer to leave it to man to wrap the line on the generated page. > | **bpftool** **prog attach** *PROG* *ATTACH_TYPE* [*MAP*] > | **bpftool** **prog detach** *PROG* *ATTACH_TYPE* [*MAP*] > | **bpftool** **prog tracelog** > @@ -131,7 +132,7 @@ DESCRIPTION > contain a dot character ('.'), which is reserved for future > extensions of *bpffs*. > > - **bpftool prog { load | loadall }** *OBJ* *PATH* [**type** *TYPE*] [**map** {**idx** *IDX* | **name** *NAME*} *MAP*] [**dev** *NAME*] [**pinmaps** *MAP_DIR*] > + **bpftool prog { load | loadall }** *OBJ* *PATH* [**type** *TYPE*] [**map** {**idx** *IDX* | **name** *NAME*} *MAP*] [**dev** *NAME*] [**pinmaps** *MAP_DIR*] [**auto_attach**] > Load bpf program(s) from binary *OBJ* and pin as *PATH*. > **bpftool prog load** pins only the first program from the > *OBJ* as *PATH*. **bpftool prog loadall** pins all programs > @@ -149,6 +150,8 @@ DESCRIPTION > given networking device (offload). > Optional **pinmaps** argument can be provided to pin all > maps under *MAP_DIR* directory. > + If **auto_attach** is specified program will be attached > + before pin. I would like more precisions here, please. In particular, can you add that 1) in that case, only the link (representing the program attached to its hook) is pinned, not the program as such, so the path won't show in "bpftool prog show -f" (I think), and 2) this only works when bpftool (libbpf) is able to infer all necessary information from the object file, in particular, it's not supported for all program types. Probably worth adding an empty line before the description for auto_attach to have it in a dedicated paragraph. > > Note: *PATH* must be located in *bpffs* mount. It must not > contain a dot character ('.'), which is reserved for future Can you also update the bash completion, please? Just the following: diff --git a/tools/bpf/bpftool/bash-completion/bpftool b/tools/bpf/bpftool/bash-completion/bpftool index dc1641e3670e..3f6f4f9c3e80 100644 --- a/tools/bpf/bpftool/bash-completion/bpftool +++ b/tools/bpf/bpftool/bash-completion/bpftool @@ -505,6 +505,7 @@ _bpftool() _bpftool_once_attr 'type' _bpftool_once_attr 'dev' _bpftool_once_attr 'pinmaps' + _bpftool_once_attr 'auto_attach' return 0 ;; esac