From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0C98D2BEFF0 for ; Fri, 4 Jul 2025 09:18:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751620705; cv=none; b=WyKrOJgIQOOo8/Y4R/Wca7KIE6cpP2Pfx78f0aABzN52a820/3YEkfi2S6HdTxWDeBYSmIH4wqifYfYzR+7viVn5gxmEvCEz/EHGvD4TWdhH4KQC33coqtQdV8M+tqUVIBmfCFweFUCUmGs1XNi7zMZdAzkjF6BZUOROom2oVQU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751620705; c=relaxed/simple; bh=dB0r3a07xx9bKthBeyrSvhIMlIDb3U7+94gSoy/0OQk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qhD9yAsqlUIe3xZErehOr6DX11NpnVlqtYRCWb9P3RiecjGgyM8nRbbqcyOdYZm2MrhsV8noVzkf4SpYSYccFpaUzBQfwZkZ/MhTFuKc3t+wNBk5ZC6G7/W4MNcCZ5pQkaguHTTWGjiFr9JPAnzohz6x2IHhquGDy/R4lRhP8LY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7C745152B; Fri, 4 Jul 2025 02:18:09 -0700 (PDT) Received: from [10.1.39.21] (e122027.cambridge.arm.com [10.1.39.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5059A3F6A8; Fri, 4 Jul 2025 02:18:21 -0700 (PDT) Message-ID: Date: Fri, 4 Jul 2025 10:18:19 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 19/80] drm/panfrost: Remove redundant pm_runtime_mark_last_busy() calls To: Sakari Ailus , Boris Brezillon , Rob Herring , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20250704075225.3212486-1-sakari.ailus@linux.intel.com> <20250704075411.3218059-1-sakari.ailus@linux.intel.com> From: Steven Price Content-Language: en-GB In-Reply-To: <20250704075411.3218059-1-sakari.ailus@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 04/07/2025 08:54, Sakari Ailus wrote: > pm_runtime_put_autosuspend(), pm_runtime_put_sync_autosuspend(), > pm_runtime_autosuspend() and pm_request_autosuspend() now include a call > to pm_runtime_mark_last_busy(). Remove the now-reduntant explicit call to > pm_runtime_mark_last_busy(). > > Signed-off-by: Sakari Ailus Reviewed-by: Steven Price But this can't be merged via drm-misc until the PM changes have hit Linus' tree and been backmerged to drm-misc-next. Thanks, Steve > --- > The cover letter of the set can be found here > . > > In brief, this patch depends on PM runtime patches adding marking the last > busy timestamp in autosuspend related functions. The patches are here, on > rc2: > > git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \ > pm-runtime-6.17-rc1 > > drivers/gpu/drm/panfrost/panfrost_perfcnt.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/panfrost/panfrost_perfcnt.c b/drivers/gpu/drm/panfrost/panfrost_perfcnt.c > index 563f16bae543..0dd62e8b2fa7 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_perfcnt.c > +++ b/drivers/gpu/drm/panfrost/panfrost_perfcnt.c > @@ -203,7 +203,6 @@ static int panfrost_perfcnt_disable_locked(struct panfrost_device *pfdev, > panfrost_mmu_as_put(pfdev, perfcnt->mapping->mmu); > panfrost_gem_mapping_put(perfcnt->mapping); > perfcnt->mapping = NULL; > - pm_runtime_mark_last_busy(pfdev->dev); > pm_runtime_put_autosuspend(pfdev->dev); > > return 0; > @@ -279,7 +278,6 @@ void panfrost_perfcnt_close(struct drm_file *file_priv) > if (perfcnt->user == pfile) > panfrost_perfcnt_disable_locked(pfdev, file_priv); > mutex_unlock(&perfcnt->lock); > - pm_runtime_mark_last_busy(pfdev->dev); > pm_runtime_put_autosuspend(pfdev->dev); > } >