From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94D1E3E63BD for ; Tue, 25 Aug 2026 10:15:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787652944; cv=none; b=DwjOcMtur13TdLbzqiaEviTi4MZC2Qdc++cPnReJJGAQeKB9q8wJkDvPHTnZo9smXw9Z5bjfjhDJ2Le7D6qpwCSgnZPzkqmo5q0q1RiVn2f2UIQQTT10TPtRncJMo37jUwQqT8NjqeDItq+ySjscaxlVxNERqDKi5+tkgyDO4qc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787652944; c=relaxed/simple; bh=uj69b6K/3X/AlbMsky2fdzUfT94fwWCpCE5MCZPbtDA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oy9NWe7dIvy/K1g5SlS6oU6JqP52oVL1+lEW8srdnqHRPGxBpVT4ytN31XHIZrzU7CqqCXijFVXnKmDSsAs6hxJdi6LGKUpklHJ7k7MYPbVgQmgwafuZwFal2TXuEqgG6oCE/cD3IPk9xfQGMMYXeHWXwyZJ+Xe8E0mKl5fegR0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dmtqvjgP; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=JZ9azhIH; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dmtqvjgP"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="JZ9azhIH" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67P88FIs771541 for ; Tue, 25 Aug 2026 10:15:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 7POdjrXeXOe8rEz7+WixrKTIdekxp+VUit6nV/G0GJY=; b=dmtqvjgP2GwJiZxT Cr5Rfus9Omk/g3StzhBqqhJfsEh/cPd/8Hvpcwn98O+OLDmxnaKi2AvVczGrByzL i6SNUIqcDTqfX/vDpuglEhwOhi4ryCN/MoLyvklE27COfVYDtnsfYhcGSqKOh9lv nn4zg4xOy8uAf80lAc1Lv5BT69ZmD5TVO75nKMy1B+0lQFxi04Qp17dFxpjMeNOn qxRliH4hM7kCb/nD+URsZ3tzgaVNaaYTNdPbSH9fpeKFzccSU/CT9S4TzvVyOgHD jy8Tsm0jxfVdRq2mGa/Dd3vrs3zB8Y7bOFMpBjP+79uoblD3o3kfz1w4TAbq57Kv Anre3Q== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g93nascuw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 25 Aug 2026 10:15:42 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51e9d892f0dso10905011cf.2 for ; Tue, 25 Aug 2026 03:15:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787652942; x=1788257742; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=7POdjrXeXOe8rEz7+WixrKTIdekxp+VUit6nV/G0GJY=; b=JZ9azhIHgpLw+iD15JHFDUb4ajlYcTlb7YZkOgZUXSfjvb6Tez2lo32ebEYvUEwPNk HBtyJGrGIazZCd70GP/1QQWNG1DrgBpQo5PNE80+LiYBG1JoF/t8EqJ7TDgWbbTcdBVE lBoGKf8dcTo9wwSXGtMWAExiaeR7Bt6DULafBLMf5w+l3lKJylfepLrf8ka29uqUBRGT ccuN2cojyJ2sd+a1RhtfdxdZQ/w6mX2YH/ouIDy0qYD3RCoVBmMszj4crz8TTli7Lo1O 0FMLYB+454SCEQzwwuL948x7UssL4DkG1RqrxcGAmKEb5Nd4+VTa6yiEgSHVuWoAAlTi g/9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787652942; x=1788257742; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=7POdjrXeXOe8rEz7+WixrKTIdekxp+VUit6nV/G0GJY=; b=mkJNBszYVNpVKdC+hiu/VTap7bINv3VmrX9ToW0S/ZlR58rSSKuCuftXEYA0X+/28k M9ZXnrbrIDlfmecfQeA/5UBZ8V+AWwaqzf6CpQAPMEu/kkDLJu5UYfpW0fYkV9HLojkz OkVwQwsojj7kBhvOB2c6UvzrR6m6QTJYTx6fhQ1B1LtpPU3JiPB1P6+yJZBVKdF1pLGD PoUM81xMKJoKf6UFNouZbcXGoOvSeU2C6x7176pQRhDSKeyvLGI8+6v6p2lDc1D93WkS KBcnA106LDc31rzzGci0EVcRG1R696TSkyZp//wDhmzgutHe0sMfmRnBUM/hW/SEdvfl LFxg== X-Forwarded-Encrypted: i=1; AHgh+RpbGq8uShTZHtkh6hM7sa4jDk1+g2z6zBan8T1m77yX7dso2u78fhan6Z1oH5hpsFoCcnXi0ZoKFYhwsBY=@vger.kernel.org X-Gm-Message-State: AFuF++l8cFC7aPhj4e1Xi+stK5qFxPQgSdIxdSBNWUUICk/MoZxaqcKc I8q8VFNvY4KyN6oTlWlg3cDgHKUXKuJEEfNcAT0XxM5U1mY861u6L7GwfZdM3p4018LOQQ/+pR7 ZUWQnWOXPbR23r0l2bayk6nhvWShxbzkb772hjFzjZAeCxoJ8dvOSIwaCk6fPB6ZO4/E= X-Gm-Gg: AR+sD13fJNdMFFSV3C1kCgt08HPRQGNh/6xuTbMTcrhpPI54JYj1G7VsUJzV6f9T5/Y Ov3Cou5LDIaMTWfn8KTa4pOIrA8oX6byNM8OC6anSLf6os17AUJWz42M5HdObfb7sL3YPgrecvY TOFyrJ+VQ/gOr6QpDVPqQGpR8WOgQX01IOIRnNvZ4QQZ+CX8yh5Oz+9rEreshovJlzFBozVKS5z AWXFGpeMz7WizganM0zu3d9GxrOwc1hgvp6dPBQ70uCTPKevjm9W8LSYfmO4awJhgbITGG0bOgF bRv9RLUHVLnUyfqWMwuVI2Af2QaIR3Blv3d07aVtpB8E8F1ihlCfKBbJwzKyUSyZ6v1/040xNU4 EZc68Lot7JhOBy4W67ByyFGVj X-Received: by 2002:a05:622a:1102:b0:51c:10e9:ec47 with SMTP id d75a77b69052e-52df5a21154mr244029821cf.5.1787652941965; Tue, 25 Aug 2026 03:15:41 -0700 (PDT) X-Received: by 2002:a05:622a:1102:b0:51c:10e9:ec47 with SMTP id d75a77b69052e-52df5a21154mr244029421cf.5.1787652941444; Tue, 25 Aug 2026 03:15:41 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c249606b431sm1397241266b.1.2026.08.25.03.15.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Aug 2026 03:15:40 -0700 (PDT) Message-ID: Date: Tue, 25 Aug 2026 12:15:38 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] firmware: qcom: scm: Introduce new locking mechanism for SCM driver To: Albert Esteve , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Ninad Naik , Murali Nalajala , Venkatakrishnaiah Pari , Jian Shu , Guru Das Srinagesh References: <20260824-port-scm-patches-v1-0-1dfd69374402@redhat.com> <20260824-port-scm-patches-v1-1-1dfd69374402@redhat.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260824-port-scm-patches-v1-1-1dfd69374402@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwODI1MDA4NiBTYWx0ZWRfX9LHG3BpFZEVs uotkmQ1joZNs8YEu1IwINpSFDNxmwe47NPLGdYxzJ0cA/2ER/I77peFZwK2n+HerBlkJt2Yjl8J dcRcgA98S99muDycG1qMXs5vks9cRkI= X-Proofpoint-ORIG-GUID: bO2oh5RcImWxcN3h5II3q47HAcIHZGHK X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI1MDA4NiBTYWx0ZWRfX93xMlD861EJ9 vK08UkpfcUgL4i/+uhr+6FoLl3gNfokqR7dgBOpKOsedTqEdOQY/J39lSoilZABn0YKtR280tng UJvUfuWrw5JziZ3gIFW6RbFDaC4M/LKDUtit/U5+QmyjHlRemGVJW0T45bQuGcYK5dbCvYupp9M 6X2X+typUIxmm4Xw4I4ohbc+9VGVG2SS0mMc0Kh3tgVXL1SXc0TH8GFpnj4j2bjbv2qqzFX+v2S eXTJ4Ulo0aeItOs6cGYa+jQoH5OEdxVol7Dl+TipyjLrCjGfN4qVBVXIPf1A28K0yjlXku3/z75 YL6Tw7LvpNknXy/ip3UnBRHBqu3GIn3koCtegZz6j+vOGFZ5wqblmjP7MPjjf4eH9KmbKUkO3Yf 3a5hinPeFfWm7MD8axPyPw9Ec6O0gnxhGsWqaLxz2tld0p4SS7ysfJO0wpUqZbzVdG5Wd0wEf0I lOA8hgtGLGY6jy2NK+w== X-Proofpoint-GUID: bO2oh5RcImWxcN3h5II3q47HAcIHZGHK X-Authority-Analysis: v=2.4 cv=W74IkxWk c=1 sm=1 tr=0 ts=6a8d6b4e cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=COk6AnOGAAAA:8 a=9NaPMQSaEhmwODzW0qsA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-25_02,2026-08-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 priorityscore=1501 impostorscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 bulkscore=0 phishscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608250086 On 8/24/26 1:35 PM, Albert Esteve wrote: > From: Ninad Naik > > With the existing global mutex lock, there is a possibility that it > could resulty into a deadlock when SMCInvoke and smc call go to > firmware in the same order and both wait on same WAITQ in firmware. I think the commit message should be extended to better explain how that may happen (because presumably it did in the real world) A Fixes tag may also be applicable here Konrad