From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753236AbdK2JMn (ORCPT ); Wed, 29 Nov 2017 04:12:43 -0500 Received: from mail.kapsi.fi ([91.232.154.25]:41443 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751546AbdK2JMj (ORCPT ); Wed, 29 Nov 2017 04:12:39 -0500 Subject: Re: [PATCH] drm/tegra: gem: Use PTR_ERR_OR_ZERO() To: Vasyl Gomonovych , thierry.reding@gmail.com, airlied@linux.ie, jonathanh@nvidia.com, dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org References: <1511907502-11528-1-git-send-email-gomonovych@gmail.com> Cc: linux-kernel@vger.kernel.org From: Mikko Perttunen Message-ID: Date: Wed, 29 Nov 2017 11:12:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1511907502-11528-1-git-send-email-gomonovych@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 62.209.167.43 X-SA-Exim-Mail-From: cyndis@kapsi.fi X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29.11.2017 00:18, Vasyl Gomonovych wrote: > Fix ptr_ret.cocci warnings: > drivers/gpu/drm/tegra/gem.c:420:1-3: WARNING: PTR_ERR_OR_ZERO can be used > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > Generated by: scripts/coccinelle/api/ptr_ret.cocci > > Signed-off-by: Vasyl Gomonovych > --- > drivers/gpu/drm/tegra/gem.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/tegra/gem.c b/drivers/gpu/drm/tegra/gem.c > index ab1e53d434e8..a40148cd0957 100644 > --- a/drivers/gpu/drm/tegra/gem.c > +++ b/drivers/gpu/drm/tegra/gem.c > @@ -417,10 +417,8 @@ int tegra_bo_dumb_create(struct drm_file *file, struct drm_device *drm, > > bo = tegra_bo_create_with_handle(file, drm, args->size, 0, > &args->handle); > - if (IS_ERR(bo)) > - return PTR_ERR(bo); > > - return 0; > + return PTR_ERR_OR_ZERO(bo); This is semantically less clear - the current code clearly has error and success paths while the changed code doesn't. Same for the other patch. Cheers, Mikko > } > > static int tegra_bo_fault(struct vm_fault *vmf) >