From: Krzysztof Kozlowski <krzk@kernel.org>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: "Olivier Louvignes" <olivier@mgcrea.io>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Paul Cercueil" <paul@crapouillou.net>,
"Joshua Crofts" <crofts@kernel.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/2] dt-bindings: iio: adc: Add the Ingenic X1600 ADC
Date: Fri, 6 Nov 2026 09:23:32 +0100 [thread overview]
Message-ID: <eeec310a-a271-4e56-8958-a03318f07e82@kernel.org> (raw)
In-Reply-To: <05798D24-C5A7-41BD-8FDF-F7075F2F0D01@goldelico.com>
On 06/11/2026 09:18, H. Nikolaus Schaller wrote:
>>
>> Again, please drop inaccurate tag from this patch.
>
> Ah, on third thought I start to understand...
>
> Because you look at *this* patch in isolation while I looked at the whole
> series.
I did not comment under the driver patch, nor under the cover letter. I
placed my comment in specific context - this patch touching the
bindings, because you cannot test bindings on a device.
>
> Yes, you are right - the dt-bindings is not directly tested (indirectly it
> was because I copied the example from this patch into my device tree and
> it worked). Then, the ADC driver was tested (but not the hardware).
>
> So this tag should not simply be dropped but moved to the driver code.
Yes, please. Thank you for testing, it is important and should be
credited, just accordingly.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-11-06 8:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 21:32 [PATCH v5 0/2] " Olivier Louvignes
2026-11-05 21:32 ` [PATCH v5 1/2] dt-bindings: " Olivier Louvignes
2026-11-06 7:05 ` Krzysztof Kozlowski
2026-11-06 8:05 ` H. Nikolaus Schaller
2026-11-06 8:11 ` Krzysztof Kozlowski
2026-11-06 8:18 ` H. Nikolaus Schaller
2026-11-06 8:23 ` Krzysztof Kozlowski [this message]
2026-11-06 9:59 ` Olivier Louvignes
2026-11-06 10:05 ` Krzysztof Kozlowski
2026-11-05 21:32 ` [PATCH v5 2/2] iio: adc: Add a driver for " Olivier Louvignes
2026-11-06 8:08 ` [PATCH v5 0/2] iio: adc: Add " H. Nikolaus Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eeec310a-a271-4e56-8958-a03318f07e82@kernel.org \
--to=krzk@kernel.org \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=crofts@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=hns@goldelico.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=olivier@mgcrea.io \
--cc=paul@crapouillou.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®