From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6CCE466B44 for ; Tue, 18 Aug 2026 11:59:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787054386; cv=none; b=VbQ05nn4aVVe10oE9+ojwf7RMoynI5YmZ4qKHCKM114NYxADwwEfqmnIvwufJxZrEVB8SEJjt8PYQccWcP9pCFeKiUq8GFCmqoFHc6rd4mqsB7Xb99fkCGAYB6IlNxKMfiFM98o/1UNaqQtplCcogXPwJ1JP+iCasJJ6jptxsyk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787054386; c=relaxed/simple; bh=qNHziLb57Bey3x9iNOwGfk8XQT2SYeQO1O0R4qYBQ5k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UlNk/rLh7q1/Z2zKgZNvcD7pGLDRMfLlfvBECLgTqlEc2EUMRpy9pukg5r8pItLw49Ji7Zt2NK6W+O8adGfjTBE9ZRS9O337ibVQAshwxhWa37mWMnWh+bSARIX0UVcaZ5VgSnCXdQ+1KERClfCHoYRLN4xuTeEkUFTrhLI3G+8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kWCt78pz; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cSAf1Iyt; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kWCt78pz"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cSAf1Iyt" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67IABans1336388 for ; Tue, 18 Aug 2026 11:59:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= OppMlgDZ2oFz73F6XSfRcoFpxG34E2g2la3nu5hF/kk=; b=kWCt78pz9fmtZShQ OC7Xu00E9soxM2umLaV9T6PutwQvtNXktN8/4a95ao7m9X0YHUQQ+eowSeydXW7S uhZunvVrKZzhJtwEdaeONdj1OtDGjWMMpH+F8ZwM2La7gt0xTWsLAVVMHBgaP92q nld6CGfwu7gcMMjFo4JPGga5mINmZFQv/eSqM0qvWNyXBOw4axebvWCmMZoC7Tjl PX9SsdxhmPWpvGMXP0M8QN5yd/QDDbBEPq9NBOyTMuWO8tN/gf0ze9wBx9Do36iO NAma1E/H0WXtM7N0g0LsV0sqaI+ZLE/09zLShnWjwv8I5Haf0ym3eQH0G/EgFS15 3SSPkw== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g4fvp1we4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 18 Aug 2026 11:59:43 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51c21be5bb4so1201181cf.0 for ; Tue, 18 Aug 2026 04:59:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787054383; x=1787659183; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=OppMlgDZ2oFz73F6XSfRcoFpxG34E2g2la3nu5hF/kk=; b=cSAf1IytSZIG1VWhiBrOVaw5hlGH0nkdh8AIvcdKuqHVg3hzfAsdT+u4h+EM2I+bgL AV2K/9HsEvyycQhhpGD4DbYjE946kUwVOq3isaoy93w3il+4F1f1GFDbbDOduv2hVH6O KyGroaiYlvjA/leSsnvCoALF2PfUqVr6AFbgF/HlxkEjjfp5A7T6ydR4cWOyW8y+km5Z 3hkiO6peR87k/vD0xF6/UIYlmYTEsTyKrWHpJzbKp/LK5nliDSQiii2glSprinA7gJBC IZJhql2nOnCK0WCakLuoyHpgKmE5PWLv4Ym8BA4cinAlhZoiLTRGIyrJlqGqg+D/Zn5D 0bkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787054383; x=1787659183; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=OppMlgDZ2oFz73F6XSfRcoFpxG34E2g2la3nu5hF/kk=; b=lM3SwOixursdHrn4gtst3FhG8PzOvXwnIyR7xdUthy8Ew1J/ZRWOZC7j85luOFfBJJ Bt88ftn6yeciPRDKkGihF8sHIavfhvaJ9L9g5C4yBTzVmywqgsMjTXgvOWx9KH8bfqZq MCRZprrQAD6aLvOKJZ7uxidQDAoJfCB7n+wovWLfYlMe63+Ie8zout89FF4iNESwi0/j Ruiotzl796N8exvvW0a6r0u2nETSb38gIeewqmi2DJ1OwdistCISO0hUZm/KGX13AFaK /W0k04oVINJMhZX6bSKrmr15qjrq2IQRzFg1nr7kzCw3ThXGIUA7nSgc/wWp4DoRdR3d ZwQg== X-Forwarded-Encrypted: i=1; AHgh+Rodc9baXhfJdqaDcWRJfVKWkKG3zqkj+twOqmo0FM/OS86l7LM9JX7o5NoJhfywUEHBSkJXOHYwTr1Zzes=@vger.kernel.org X-Gm-Message-State: AOJu0Yy9cslFEWO4cE7Yeu2sK92S8afDYSIUTC2APflPmot2sgeqYn3R GhQwjUBUfurSlaXjC6gSnuIaoHJPGD1A/XbfMRtm1BH21D3nZYFf2l+u+gA2MWgyraGoUB6EU0a m9ZK8FQ9z+fqluskCOuRrlqjQyD9mNVH+EErg0EOFZVj87BwaqLMh+/XQWDJlblwNdLA= X-Gm-Gg: AR+sD133sfYui6t1zckLvogJVLt+8QJ6g8EtYzpwS9Rffm/YclCZ7qYYSD9l/6fy1A7 PunsW7RdsV5uDMqo3cDI4MpAMuX0zLxW5W+htDKXXJVL0KRfCZWJ3Wdt6z/kee2ALPEJIycrwux LWy0b1a1Kz26MP9+fqfWYK52xgxQWe3fo84xKBXusqWZRd7hiLMwUXXMbJiWTx5U0BbtE7BJWNl vBd186lTonc/+WLrXkHUZA1sad0J5nkRbgMcEYeLVTn42sx7OX/FnjwH+MGVN/lT10UNsJ2dEnN rkJ5CNf7QSq17KDESTEDCcIMLxQd6O2uvS92g1yMpaDflSWWmlHNGmj30TRmb9XRF0sPFZnBxKP 97Yqi7oP+w/F2oy1iQ8G1BFrm X-Received: by 2002:a05:622a:118f:b0:528:1ea6:eaee with SMTP id d75a77b69052e-52d852b4f2bmr219969011cf.1.1787054382789; Tue, 18 Aug 2026 04:59:42 -0700 (PDT) X-Received: by 2002:a05:622a:118f:b0:528:1ea6:eaee with SMTP id d75a77b69052e-52d852b4f2bmr219968691cf.1.1787054382179; Tue, 18 Aug 2026 04:59:42 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a3d859b274sm1656312a12.25.2026.08.18.04.59.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Aug 2026 04:59:41 -0700 (PDT) Message-ID: Date: Tue, 18 Aug 2026 13:59:38 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/5] i2c: qcom-cci: Support per-mode CCI clock rates To: Loic Poulain , Robert Foss , Andi Shyti , Wolfram Sang , Dmitry Baryshkov , Luca Weiss Cc: linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, vladimir.zapolskiy@linaro.org, konradybcio@kernel.org, stephan.gerhold@linaro.org References: <20260801-cci-clk-fix-v4-0-e1d80da54e01@oss.qualcomm.com> <20260801-cci-clk-fix-v4-2-e1d80da54e01@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260801-cci-clk-fix-v4-2-e1d80da54e01@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: ezDusOsGhZyt-4rajk3ZnoW4Z2Qdqed_ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE4MDA4OCBTYWx0ZWRfXzNGyMWmBtfCV fzpnBn6Mo+o0TBJ8JYKqdZwUnc/MNDsC3jFPCXwsa+H4FDU2/DDanxdLfx50uUkLo2+yXRTLQJD Op6KRq71PyzB+d2xbyPcp+mdkmsXw3+0bS2h8SJKc5wz8Zgz194EUaUBOfbwCvtUUuPUSKShOCI AELSjfP8u3qL9o4wB09snAEP/5ao72aSyv9kfpnxrf4kYJWb3x9ms2zjR+j+c6FYsAD0ZzIfj+6 YxjB9x5R8+ZAbuQwEtVcsuMsABUBZhH6fJo0ccpD0A+b4/GihFSnH4Mt16tcF1b2XRlXN336Q30 +pF5r1auE3Yl8q/xCwCr2TB1PAKNmL4+H7pkomJTTm7tjLuyJxJpecHPsSHQfou5On21Fhe6GlQ b1AwkxFcCXVG1p+e6GqH+ZIybrTRUAat2xT7n7rsEB56n5dto/xuz4LnbV+eX6b64hFvZ8gaD3q jKhJRCQjSHEn3salXEw== X-Authority-Analysis: v=2.4 cv=K/IS2SWI c=1 sm=1 tr=0 ts=6a84492f cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=fb-0gDls0OKrqtmrxo0A:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwODE4MDA4OCBTYWx0ZWRfX+Sxw3yBg5dh3 0wFOsbKsmORdIY8mS1dRe/UbTfkKx1HvKFG+x5bOUakUp4lrcQ1jlVVY2xw5JZwixY0OiLUjyc9 igAkwebB4Pw7pNxiuGbNZAKT0Z9Oe2s= X-Proofpoint-GUID: ezDusOsGhZyt-4rajk3ZnoW4Z2Qdqed_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-18_01,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 priorityscore=1501 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608180088 On 8/1/26 10:10 PM, Loic Poulain wrote: > The CCI hw_params timing values (thigh, tlow, etc.) are expressed in > clock ticks and are only valid at the specific CCI clock rate they were > calibrated for. Different I2C modes may be calibrated for different > rates, and the single CCI clock is shared by all masters. > > Turn the timing table into a two-dimensional [rate][mode] matrix so a > given rate can carry timing sets for each mode, and select the entry > matching the currently running clock rate at init time. The existing > per-variant values are moved under their calibrated rate (19.2 MHz for > v1/v1.5, 37.5 MHz for v2), no timing values are changed. > > At this stage the driver only validates the running rate against the > table, the timings are only valid at the exact rate they were calibrated > for, so if the current rate has no matching entry for a master's mode, > fail initialization rather than program incorrect timings. A following > patch actively enforces the required rate so this becomes a safety net. > > Suggested-by: Vladimir Zapolskiy > Signed-off-by: Loic Poulain > --- Reviewed-by: Konrad Dybcio Konrad