From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751495AbdFFS0P (ORCPT ); Tue, 6 Jun 2017 14:26:15 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:36698 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751239AbdFFS0O (ORCPT ); Tue, 6 Jun 2017 14:26:14 -0400 Subject: Re: [PATCH v5 1/9] scatterlist: add sg_zeroout_area() helper To: Johannes Thumshirn , Christoph Hellwig , Keith Busch Cc: Hannes Reinecke , maxg@mellanox.com, Linux NVMe Mailinglist , Linux Kernel Mailinglist References: <20170606143617.32143-1-jthumshirn@suse.de> <20170606143617.32143-2-jthumshirn@suse.de> From: Sagi Grimberg Message-ID: Date: Tue, 6 Jun 2017 21:26:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170606143617.32143-2-jthumshirn@suse.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > + while ((offset < buflen) && sg_miter_next(&miter)) { > + unsigned int len; > + > + len = min(miter.length, buflen - offset); > + memset(miter.addr, '\0', len); Why '\0' and not 0?