mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Beleswar Prasad Padhi <b-padhi@ti.com>
To: Francesco Dolcini <francesco@dolcini.it>, Andrew Davis <afd@ti.com>
Cc: Hari Nagalla <hnagalla@ti.com>, <jassisinghbrar@gmail.com>,
	<linux-kernel@vger.kernel.org>, <hiagofranco@gmail.com>,
	<u-kumar1@ti.com>
Subject: Re: [RFC PATCH] mailbox: omap-mailbox: Flush out pending msgs before entering suspend
Date: Thu, 30 Oct 2025 14:42:26 +0530	[thread overview]
Message-ID: <eef22cd5-c474-4144-af95-e306b701975d@ti.com> (raw)
In-Reply-To: <20251030085912.GA19297@francesco-nb>


On 30/10/25 14:29, Francesco Dolcini wrote:
> On Fri, Oct 24, 2025 at 09:08:09AM -0500, Andrew Davis wrote:
>> On 10/23/25 11:48 PM, Beleswar Prasad Padhi wrote:
>>> Hi Hari,
>>>
>>> On 23/10/25 22:48, Hari Nagalla wrote:
>>>> On 10/22/25 23:38, Beleswar Prasad Padhi wrote:
>>> Hmm, this was how it was until 2016 when commit
>>> 9f0cee984a25 ("mailbox/omap: check for any unread
>>> messages during suspend") was added. Do you
>>> suggest reverting 9f0cee984a25? Hope it doesn't
>>> break any existing usecases for OMAP platforms.
>> Checking for unread messages during suspend is still correct,
>> what we then do when we find them is the open question. We can:
>>
>>  * Not suspend (current situation)
>>  * Suspend anyway, deleting them but with a warning
> I would propose that we improve the current patch and just add a
> dev_warn when there are unread messages.


For systems which have FIFOs firewalled, this flushing
will result in exception. So we can't go with this.

>
> Andrew?
>
>>  * Save and restore them
> As of now our platforms (Toradex) are broken because of the changes in
> this series https://lore.kernel.org/all/20250908142826.1828676-1-b-padhi@ti.com/
> (now in mainline), and I would love to get it fixed sooner than later.


I've been working on this, and will send a DT patch
today to limit the num-fifos for each cluster.

Thanks,
Beleswar


      reply	other threads:[~2025-10-30  9:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-22 10:20 Beleswar Padhi
2025-10-22 13:45 ` Hiago De Franco
2025-10-22 16:07 ` Andrew Davis
2025-10-23  4:38   ` Beleswar Prasad Padhi
2025-10-23 17:18     ` Hari Nagalla
2025-10-24  4:48       ` Beleswar Prasad Padhi
2025-10-24 14:08         ` Andrew Davis
2025-10-30  8:59           ` Francesco Dolcini
2025-10-30  9:12             ` Beleswar Prasad Padhi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eef22cd5-c474-4144-af95-e306b701975d@ti.com \
    --to=b-padhi@ti.com \
    --cc=afd@ti.com \
    --cc=francesco@dolcini.it \
    --cc=hiagofranco@gmail.com \
    --cc=hnagalla@ti.com \
    --cc=jassisinghbrar@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=u-kumar1@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®