From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753174AbcHONAQ (ORCPT ); Mon, 15 Aug 2016 09:00:16 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:50538 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752796AbcHONAO (ORCPT ); Mon, 15 Aug 2016 09:00:14 -0400 Subject: Re: [PACTH v2 0/3] Implement /proc//totmaps To: Michal Hocko References: <1471039462-16771-1-git-send-email-robert.foss@collabora.com> <20160814090430.GB9248@dhcp22.suse.cz> Cc: corbet@lwn.net, akpm@linux-foundation.org, vbabka@suse.cz, koct9i@gmail.com, hughd@google.com, n-horiguchi@ah.jp.nec.com, minchan@kernel.org, john.stultz@linaro.org, ross.zwisler@linux.intel.com, jmarchan@redhat.com, hannes@cmpxchg.org, keescook@chromium.org, viro@zeniv.linux.org.uk, gorcunov@openvz.org, plaguedbypenguins@gmail.com, rientjes@google.com, eric.engestrom@imgtec.com, jdanis@google.com, calvinowens@fb.com, adobriyan@gmail.com, jann@thejh.net, sonnyrao@chromium.org, kirill.shutemov@linux.intel.com, ldufour@linux.vnet.ibm.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Ben Zhang , Bryan Freed , Filipe Brandenburger , Mateusz Guzik From: Robert Foss Message-ID: Date: Mon, 15 Aug 2016 09:00:04 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160814090430.GB9248@dhcp22.suse.cz> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016-08-14 05:04 AM, Michal Hocko wrote: > On Fri 12-08-16 18:04:19, robert.foss@collabora.com wrote: >> From: Robert Foss >> >> This series implements /proc/PID/totmaps, a tool for retrieving summarized >> information about the mappings of a process. > > The changelog is absolutely missing the usecase. Why do we need this? > Why existing interfaces are not sufficient? You are absolutely right, more info information is in 1/3. But the gist of it is that it provides a faster and more convenient way of accessing the information in /proc/PID/smaps. > >> Changes since v1: >> - Removed IS_ERR check from get_task_mm() function >> - Changed comment format >> - Moved proc_totmaps_operations declaration inside internal.h >> - Switched to using do_maps_open() in totmaps_open() function, >> which provides privilege checking >> - Error handling reworked for totmaps_open() function >> - Switched to stack allocated struct mem_size_stats mss_sum in >> totmaps_proc_show() function >> - Removed get_task_mm() in totmaps_proc_show() since priv->mm >> already is available >> - Added support to proc_map_release() fork priv==NULL, to allow >> function to be used for all failure cases >> - Added proc_totmaps_op and for it helper functions >> - Added documention in separate patch >> - Removed totmaps_release() since it was just a wrapper for >> proc_map_release() >> >> >> Robert Foss (3): >> mm, proc: Implement /proc//totmaps >> Documentation/filesystems: Fixed typo >> Documentation/filesystems: Added /proc/PID/totmaps documentation >> >> Documentation/filesystems/proc.txt | 23 ++++++- >> fs/proc/base.c | 1 + >> fs/proc/internal.h | 3 + >> fs/proc/task_mmu.c | 134 +++++++++++++++++++++++++++++++++++++ >> 4 files changed, 160 insertions(+), 1 deletion(-) >> >> -- >> 2.7.4 >> >