From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755113AbdKCIJw (ORCPT ); Fri, 3 Nov 2017 04:09:52 -0400 Received: from mout.web.de ([212.227.15.14]:54628 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752538AbdKCIJs (ORCPT ); Fri, 3 Nov 2017 04:09:48 -0400 To: devel@driverdev.osuosl.org, linux-iio@vger.kernel.org, Greg Kroah-Hartman , Hartmut Knaack , Jonathan Cameron , Lars-Peter Clausen , Michael Hennerich , Peter Meerwald-Stadler Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] staging: iio: ad7152: Improve unlocking of a mutex in ad7152_start_calib() Message-ID: Date: Fri, 3 Nov 2017 09:09:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:eLKzdMUhLuEMlzqdcgX7XLIAXc6OgAUqp6n2mAVWhsXT5a8nn2L Js5LlgH5dd52VwMW2BzFdxEUer+ZxHxj07LHrCEODLcVyVfgUPBVdOnTE7WU49lsfHW1Hle wjvI9sHHe8RxLcYGQf66ZiPQssrqCMeGR0jUZ/uFsgizIOP5CWTEZJQ+70yfbWgQcRyGfJQ mUzfMr6Pp60U/mSjWG3zw== X-UI-Out-Filterresults: notjunk:1;V01:K0:fIZVEWdPhvk=:0n0tkDqAUofT0Uj9IHzToi czZ61vq8DWIOy5qqPe8o4auNaU2WuL1mKmsYovse01hBJsknJrKSmudLZJ7doXXMGetBYJMnD 0mpm4AvmBC0lRI4duQtnSWlC8CdlTbpck4ixrgc9rFhOl7t3s/VLE0Z1RXAQaOjMKhnP3BbET T6isy/g1pzaEqQM3NeHvO0nZ/kMyZth6VjAZ7j4LJ1qYlG/wGfghDIsWaBTVcGol/nKA+L/aJ 9yEZjEqAFFJj6xKxysnRrqAARN4epB2RcP0xI419nFI4o5cJvoAvcIEg+BVg6FbaAUUi7sgYz aYpRTPAZOb5e9cezvMYNMJ2CuWEpJI4OGsk1zc86RQifLYh8ylw78QsPC5l/yqodWZ0qxaxAq 3YTHakO5R8G1A9WlFW/XqAeE9LDz9SGbThrYvwGo4vtz0qwidbLNQinb2iHQyw0gmrBWzMpVM dJCi7+qHgEtfkc99wJdmz5h/ZTSTAbdTvOqW/4ad4b94gvNTd8MJi1V7X93Cb+gBuhZUmVbQA tHUnIUbmbqfOto60oJ468fPXan9+K+8cco2+nSlP/aU4tIJlREr8e+wGmfuEGFMNe2t/+aN8M q23KNkv+Vduz5Ao3dsNvIL8uucGYRJqSrXA5uYpSlrTFcPxRmASPSHgxyfce2gTsuP2axoBRj /iKYGUmQ6DdRRqvO1ZCVil2/1PTrbHeH0SeqbjbVUI/P9e3RuMkSM0zQxNux8ies/8JAAXbCQ GEtE+TJJwiho/j0fEs4S/3fg8lkTlw2c/qFYe3bZGujRNJj4t1FIqrPHPYMXN0k9CwdVLwkvk vDW17D7/Ljc01L4Rjr6HhgoFtTLp8MtqvgQFsFk/XxpEMBTU0s= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 3 Nov 2017 09:00:25 +0100 * Add a jump target so that a call of the function "mutex_unlock" is stored only twice in this function implementation. * Replace two calls by goto statements. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/staging/iio/cdc/ad7152.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/staging/iio/cdc/ad7152.c b/drivers/staging/iio/cdc/ad7152.c index 61377ca444de..59d1b35f6a4e 100644 --- a/drivers/staging/iio/cdc/ad7152.c +++ b/drivers/staging/iio/cdc/ad7152.c @@ -118,22 +118,23 @@ static inline ssize_t ad7152_start_calib(struct device *dev, mutex_lock(&chip->state_lock); ret = i2c_smbus_write_byte_data(chip->client, AD7152_REG_CFG, regval); - if (ret < 0) { - mutex_unlock(&chip->state_lock); - return ret; - } + if (ret < 0) + goto unlock; do { mdelay(20); ret = i2c_smbus_read_byte_data(chip->client, AD7152_REG_CFG); - if (ret < 0) { - mutex_unlock(&chip->state_lock); - return ret; - } + if (ret < 0) + goto unlock; + } while ((ret == regval) && timeout--); mutex_unlock(&chip->state_lock); return len; + +unlock: + mutex_unlock(&chip->state_lock); + return ret; } static ssize_t ad7152_start_offset_calib(struct device *dev, -- 2.15.0