mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guru Das Srinagesh <gurus@codeaurora.org>
To: linux-pwm@vger.kernel.org
Cc: "Thierry Reding" <thierry.reding@gmail.com>,
	"Uwe Kleine-König" <uwe@kleine-koenig.org>,
	"Subbaraman Narayanamurthy" <subbaram@codeaurora.org>,
	linux-kernel@vger.kernel.org,
	"Guru Das Srinagesh" <gurus@codeaurora.org>,
	"Jani Nikula" <jani.nikula@linux.intel.com>,
	"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
	"David Airlie" <airlied@linux.ie>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Chris Wilson" <chris@chris-wilson.co.uk>,
	"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: [PATCH v7 02/13] drm/i915: Use 64-bit division macros for period and duty cycle
Date: Mon,  9 Mar 2020 12:35:05 -0700	[thread overview]
Message-ID: <eef99b87cd71e8442b944d547d73079b900d24d8.1583782035.git.gurus@codeaurora.org> (raw)
In-Reply-To: <cover.1583782035.git.gurus@codeaurora.org>
In-Reply-To: <cover.1583782035.git.gurus@codeaurora.org>

Because period and duty cycle are defined in the PWM framework structs
as ints with units of nanoseconds, the maximum time duration that can be
set is limited to ~2.147 seconds. Redefining them as u64 values will
enable larger time durations to be set.

As a first step, prepare drivers to handle the switch to u64 period and
duty_cycle by replacing division operations involving pwm period and duty cycle
with their 64-bit equivalents as appropriate. The actual switch to u64 period
and duty_cycle follows as a separate patch.

Where the dividend is 64-bit but the divisor is 32-bit, use *_ULL
macros:
- DIV_ROUND_UP_ULL
- DIV_ROUND_CLOSEST_ULL
- div_u64

Where the divisor is 64-bit (dividend may be 32-bit or 64-bit), use
DIV64_* macros:
- DIV64_U64_ROUND_CLOSEST
- div64_u64

Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org

Signed-off-by: Guru Das Srinagesh <gurus@codeaurora.org>
---
 drivers/gpu/drm/i915/display/intel_panel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_panel.c b/drivers/gpu/drm/i915/display/intel_panel.c
index bc14e9c..843cac1 100644
--- a/drivers/gpu/drm/i915/display/intel_panel.c
+++ b/drivers/gpu/drm/i915/display/intel_panel.c
@@ -1868,7 +1868,7 @@ static int pwm_setup_backlight(struct intel_connector *connector,
 
 	panel->backlight.min = 0; /* 0% */
 	panel->backlight.max = 100; /* 100% */
-	panel->backlight.level = DIV_ROUND_UP(
+	panel->backlight.level = DIV_ROUND_UP_ULL(
 				 pwm_get_duty_cycle(panel->backlight.pwm) * 100,
 				 CRC_PMIC_PWM_PERIOD_NS);
 	panel->backlight.enabled = panel->backlight.level != 0;
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project


  parent reply	other threads:[~2020-03-09 19:36 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-09 19:35 [PATCH v7 00/13] Convert period and duty cycle to u64 Guru Das Srinagesh
2020-03-09 19:35 ` [PATCH v7 01/13] clk: pwm: Use 64-bit division macros for period and duty cycle Guru Das Srinagesh
2020-03-09 19:35 ` Guru Das Srinagesh [this message]
2020-03-09 19:35 ` [PATCH v7 03/13] hwmon: pwm-fan: " Guru Das Srinagesh
2020-03-09 21:48   ` Guenter Roeck
2020-03-10 12:08     ` Uwe Kleine-König
2020-03-10 15:05       ` Guenter Roeck
2020-03-10 22:24         ` Guru Das Srinagesh
2020-03-10 22:57           ` Guenter Roeck
2020-03-09 19:35 ` [PATCH v7 04/13] ir-rx51: " Guru Das Srinagesh
2020-03-09 19:35 ` [PATCH v7 05/13] pwm: clps711x: " Guru Das Srinagesh
2020-03-09 19:35 ` [PATCH v7 06/13] pwm: pwm-imx-tpm: " Guru Das Srinagesh
2020-03-09 19:35 ` [PATCH v7 07/13] pwm: imx27: " Guru Das Srinagesh
2020-03-09 19:35 ` [PATCH v7 08/13] pwm: sifive: " Guru Das Srinagesh
2020-03-26 16:37   ` Palmer Dabbelt
2020-03-09 19:35 ` [PATCH v7 09/13] pwm: sti: " Guru Das Srinagesh
2020-03-09 19:35 ` [PATCH v7 10/13] pwm: stm32-lp: Use %llu format specifier for period Guru Das Srinagesh
2020-03-09 19:35 ` [PATCH v7 11/13] pwm: sun4i: Use 64-bit division macros for period and duty cycle Guru Das Srinagesh
2020-03-09 19:35 ` [PATCH v7 12/13] backlight: pwm_bl: " Guru Das Srinagesh
2020-03-10 14:34   ` Daniel Thompson
2020-03-10 18:12     ` Guru Das Srinagesh
2020-03-09 19:35 ` [PATCH v7 13/13] pwm: core: Convert period and duty cycle to u64 Guru Das Srinagesh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eef99b87cd71e8442b944d547d73079b900d24d8.1583782035.git.gurus@codeaurora.org \
    --to=gurus@codeaurora.org \
    --cc=airlied@linux.ie \
    --cc=chris@chris-wilson.co.uk \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=subbaram@codeaurora.org \
    --cc=thierry.reding@gmail.com \
    --cc=uwe@kleine-koenig.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®