From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753160AbcG3PhR (ORCPT ); Sat, 30 Jul 2016 11:37:17 -0400 Received: from mx3.mailbox.org ([80.241.60.216]:41692 "EHLO mx3.mailbox.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751055AbcG3PhM (ORCPT ); Sat, 30 Jul 2016 11:37:12 -0400 X-Greylist: delayed 429 seconds by postgrey-1.27 at vger.kernel.org; Sat, 30 Jul 2016 11:37:12 EDT Subject: Re: [PATCH 33/33] Staging: android: ion: ion.c: Compression of lines for To: Nadim almas , labbott@redhat.com References: <1469877168-7864-1-git-send-email-nadim.902@gmail.com> Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org From: =?UTF-8?Q?Markus_B=c3=b6hme?= Message-ID: Date: Sat, 30 Jul 2016 17:26:08 +0200 MIME-Version: 1.0 In-Reply-To: <1469877168-7864-1-git-send-email-nadim.902@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/30/2016 01:12 PM, Nadim almas wrote: > This patch compresses two lines in to a single line in file rtw_android.c > if immediate return statement is found. It also removes variable > bytes_written as it is no longer needed. This commit message is wrong. Neither are you editing rtw_android.c, nor are you doing anything to a variable named bytes_written. Additionally, the short description in your first line/subject seems to be missing a word or two at the end. > > It is done using script Coccinelle. And coccinelle uses following semantic > patch for this compression function: > > > @@ > expression e, ret; > @@ > > -ret = > +return > e; > -return ret; > > Signed-off-by: Nadim Almas > --- > drivers/staging/android/ion/ion.c | 8 +++----- > 1 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c > index 52345df..271395b 100644 > --- a/drivers/staging/android/ion/ion.c > +++ b/drivers/staging/android/ion/ion.c > @@ -391,9 +391,7 @@ static int ion_handle_put_nolock(struct ion_handle *handle) > { > - int ret; > > - ret = kref_put(&handle->ref, ion_handle_destroy); > - > - return ret; > + return kref_put(&handle->ref, ion_handle_destroy); > } > > static int ion_handle_put(struct ion_handle *handle) > @@ -597,8 +595,8 @@ int ion_phys(struct ion_client *client, struct ion_handle *handle, > return -ENODEV; > } > mutex_unlock(&client->lock); > - ret = buffer->heap->ops->phys(buffer->heap, buffer, addr, len); > - return ret; > + return buffer->heap->ops->phys(buffer->heap, buffer, addr, len); > } > EXPORT_SYMBOL(ion_phys); What Joe told you about compile-testing, warnings and unused variables still applies.