From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: Mihai-Valentin DUMITRU <mihai.dumitru2201@gmail.com>,
perex@perex.cz, tiwai@suse.com, heiko@sntech.de
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
broonie@kernel.org,
Mihai-Valentin DUMITRU <mihai.dumitru2201@stud.acs.upb.ro>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ASoC: rockchip: i2s: Remove unnecessary 'out of memory' message
Date: Sun, 26 Feb 2017 17:04:16 +0900 [thread overview]
Message-ID: <ef03f4f4-ad76-8441-87b1-fe637f53977e@sakamocchi.jp> (raw)
In-Reply-To: <20170225101834.28232-1-mihai.dumitru2201@stud.acs.upb.ro>
On Feb 25 2017 19:18, Mihai-Valentin DUMITRU wrote:
> This was reported by checkpatch.pl
>
> Signed-off-by: Mihai-Valentin DUMITRU <mihai.dumitru2201@gmail.com>
> ---
> sound/soc/rockchip/rockchip_i2s.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/soc/rockchip/rockchip_i2s.c
> index 974915cb4c4f..d02a1045fc0b 100644
> --- a/sound/soc/rockchip/rockchip_i2s.c
> +++ b/sound/soc/rockchip/rockchip_i2s.c
> @@ -551,10 +551,8 @@ static int rockchip_i2s_probe(struct platform_device *pdev)
> int val;
>
> i2s = devm_kzalloc(&pdev->dev, sizeof(*i2s), GFP_KERNEL);
> - if (!i2s) {
> - dev_err(&pdev->dev, "Can't allocate rk_i2s_dev\n");
> + if (!i2s)
The line for dev_warn() should be kept.
> return -ENOMEM;
> - }
>
> i2s->dev = &pdev->dev;
Regards
Takashi Sakamoto
next prev parent reply other threads:[~2017-02-26 8:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-25 10:18 Mihai-Valentin DUMITRU
2017-02-26 8:04 ` Takashi Sakamoto [this message]
2017-08-14 16:42 ` Applied "ASoC: rockchip: Delete an error message for a failed memory allocation in rockchip_i2s_probe()" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef03f4f4-ad76-8441-87b1-fe637f53977e@sakamocchi.jp \
--to=o-takashi@sakamocchi.jp \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=heiko@sntech.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mihai.dumitru2201@gmail.com \
--cc=mihai.dumitru2201@stud.acs.upb.ro \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®