From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDBECC7619A for ; Wed, 5 Apr 2023 10:54:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237535AbjDEKyH (ORCPT ); Wed, 5 Apr 2023 06:54:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237236AbjDEKyC (ORCPT ); Wed, 5 Apr 2023 06:54:02 -0400 Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2E311985 for ; Wed, 5 Apr 2023 03:53:54 -0700 (PDT) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20230405105352euoutp02dffafab1c41a12592d23207b9844e5c0~TBH_aEgLE2159821598euoutp02p for ; Wed, 5 Apr 2023 10:53:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20230405105352euoutp02dffafab1c41a12592d23207b9844e5c0~TBH_aEgLE2159821598euoutp02p DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1680692032; bh=/MHeQbL4d+SkeYdVmEUECRJ+Dg+GsC8Vhkosh+DvSX8=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=pKtAbrEs5Go0GRV0/fhQhILZnYpgbBGd0A07THHx8XfX0f6Zmrv9MeHs/eSeBpi7E AMGCYkwqF3/GT88RKpktXxvLA8DBX0bueDYC2reE7iNevXkP/Z7IQbIJxZvVyHS3KP X4uFWv6hILq006e5meSAq4B+jwAtSozdog36+G0o= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20230405105351eucas1p277f3a73fa64d5d2e4b7003452e76d320~TBH99rfgL3124231242eucas1p2B; Wed, 5 Apr 2023 10:53:51 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 49.15.09966.F335D246; Wed, 5 Apr 2023 11:53:51 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20230405105350eucas1p12b84b5c9445471ecde13b089725bd57c~TBH9Y5l5K3055630556eucas1p1x; Wed, 5 Apr 2023 10:53:50 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20230405105350eusmtrp215911ef612d7794f1fc19243c10cf275~TBH9YEjjM2945429454eusmtrp2F; Wed, 5 Apr 2023 10:53:50 +0000 (GMT) X-AuditID: cbfec7f4-d39ff700000026ee-54-642d533f46f4 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id B0.9D.08862.E335D246; Wed, 5 Apr 2023 11:53:50 +0100 (BST) Received: from [106.210.134.192] (unknown [106.210.134.192]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20230405105349eusmtip25d9acc9f797dfe1371a0dbd25202313d~TBH8Nedw31004810048eusmtip2X; Wed, 5 Apr 2023 10:53:49 +0000 (GMT) Message-ID: Date: Wed, 5 Apr 2023 12:53:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH net 1/1] net: stmmac: check fwnode for phy device before scanning for phy Content-Language: en-US To: Shahab Vahedi , Michael Sit Wei Hong , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Ong Boon Leong , "netdev@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux@armlinux.org.uk" , "hkallweit1@gmail.com" , "andrew@lunn.ch" , Martin Blumenstingl Cc: Looi Hong Aun , Voon Weifeng , Lai Peter Jun Ann , Zulkifli Muhammad Husaini , Tan Tee Min , "hock.leong.kweh@intel.com" , Vineet Gupta , "linux-snps-arc@lists.infradead.org" From: Marek Szyprowski In-Reply-To: Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02SfVDTdRzH/f6eNpajnzx+QS+5pZ3CAdJhfe8kskL7oXdehz1h3rkd+zlI hrY5FM+Th4bS0njGOUDntCZeG7lgbRhwDGIuE0SKSxJMHbeYgejIA0zI8aPiv/f78/m+Pk/3 5eNBl6hIflbOflaRI8kWUQLC2j3dE/v69ljpuq6GFWh6tAag3iEHjtyNBgrV9aoJNNJ9l4cM D7Qk+vG4C0M/q40EGv57gkTXrV+QyHJvgET9LXUUKr5lwpBmwE0iR3UrQN0GF4FOPzWR6EyR HUN9V67hqFsfhh5f/ROgufvNABWdsgBU+VcnhebUBQQq9Jpw9GWXlrdxOdM/0IczTQ03MWak tJnH2HVDPEZvUTEjZZU85tz3oxhjufgZxXx7Pp+x23wY86DtF4rpaEtgRqZan4HtPsD4LC+8 8/wOQZKUzc7KZRXxyWJBpsF6A99XwTt44oqVLACjpAbw+ZBOhGcbUzVAwA+iLwD4yOajODMJ oGfuKc4ZH4AT5TOYBgTME4ahGpJLGAEcb5hYQB4CqFN3Y/66QjoZGj35foCgV0GjZob0ayG9 DLpOuQm/DqWl8LJrhOfXwfQuWF47h/s1TofDQfcZzF8zhP6BB1traucNThtwWHxpep6m6ASo GdNQfh1Ab4TO3nqCo1fC78bq5ueGdKsA+oZLCW7uFOitaQScDoZeZxOP0yvgnJ1rB+ljAOqf 3F4wZQAWeAYXiA3wVs8M5d8Np9fCxpZ4LvwG/O3k8MIpA+GvY8u4IQJhhfUkzoWFsORoEPf6 Jahzmv9r23H9Bl4GRLpFh9EtOoBu0Tq6//vqAXERhLMqpVzGKl/OYQ/EKSVypSpHFpexV24B z3711VnnpA0YvQ/jHADjAweAfFwUIlytiZYGCaWSvEOsYu8uhSqbVTrAcj4hChfGvObKCKJl kv3sHpbdxyr+zWL8gMgCrKDlaHpUwlLsw68T1wdvrqp+NHv4zRJHe9K7EVM73xZtOIJy/+iP WPKxZuvvdw47zt8v9cW686saIkalisKMY/K7plXrvDFDnsLAA1pz2OTnauNO+kRmVtTZ1Bdt xwVLTeLZ9IiYNSmVJjxberPs8Xt68er2eOtPfWatd7eh79UlJk/0+tq2D0pCCjfNMPLYNOrJ He0Wcapg03jaQFlForjYtOebcnlvkfnTNbJtku2RW8fet3d2bNtBXf6qOf8tRagqDzOzuztA 1fih6vItgWvPnU5PlK00365L+UR3xD4VlUwd/ChvcKKevtbpILvuJV14Lje7vicsPdQZatMa X0lrQiJCmSlJiMYVSsk/gYrYuEQEAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrCKsWRmVeSWpSXmKPExsVy+t/xe7p2wbopBnMmG1n8fDmN0eL83UPM Fk/WL2KzmHO+hcXi6bFH7BaL3s9gtTjVc5LJ4krLchaLe38+sFpc2NbHarHp8TVWi8u75rBZ tN5Zy2TRde0Jq8WhqXsZLY4tOsliMe/vWlaL+U07mSwunjjLbHFsgZjFt9NvGC3+v97KaNE0 cxOjxeSvh9ks/rc0sFg0vlrLbLH0yAx2B2mPy9cuMntsWXmTyeNp/1Z2j52z7rJ7LNhU6vF0 wmR2j8V7XjJ5bFrVyeaxeUm9x84dn5k83u+7yuZxcJ+hx9Mfe4Ea939m9Pi8SS6AP0rPpii/ tCRVISO/uMRWKdrQwkjP0NJCz8jEUs/Q2DzWyshUSd/OJiU1J7MstUjfLkEvY9G2S8wFk9gr ek9sY21gfMnaxcjJISFgIrHo7jQgm4tDSGApo8SBhdvYIRIyEienNUAVCUv8udbFBlH0nlHi 5L4ZzF2MHBy8AnYSy5/Xg9SwCKhILO/6BVbPKyAocXLmExYQW1QgRWLXhKVMILawQLzExNn/ mUFsZgFxiVtP5jOBzBQROM0uMf38UXYQh1lgGbPE8rdvGSG2nWeUuNg+gQ2khU3AUKLrbReY zSngIHH8/FwWiFFmEl1buxghbHmJ7W/nME9gFJqF5JJZSDbOQtIyC0nLAkaWVYwiqaXFuem5 xYZ6xYm5xaV56XrJ+bmbGIHJaduxn5t3MM579VHvECMTB+MhRgkOZiURXtUurRQh3pTEyqrU ovz4otKc1OJDjKbA4JjILCWanA9Mj3kl8YZmBqaGJmaWBqaWZsZK4ryeBR2JQgLpiSWp2amp BalFMH1MHJxSDUyLqv0DOFzW734hJRZh8L0jwrv4wuw3a46tffnsfWGtYd/dWXv6rtYuOiiv b7rOdI6z9DO90ugnbT8W3XucHuCvOM3lt/KxlqpXsgc7VdZrB6R377lj/7pkq+V2gUyTia2X m6fqljxlV/+zaXXFMfNAv+W7lu2fW71ohoKJ2IHN1ysc0i8fmz1rM2PXbjGjJ15dPD2+3BeY Wc4Y3pDh9g78ddPg2k69yPcJZ1yz3ztcrUmy3GJ82Ce60yBD/te6F4a7wxclzEl4zmcqeWCy a+Ls3nLtukXbuLW6vqWkHpvqpSa0mmFujeDqsLIPbue3MJ/7Mvdx3+X9Ro3qYvF6TpqGlX25 h7xXeKiHVGlsnafEUpyRaKjFXFScCACraanX1wMAAA== X-CMS-MailID: 20230405105350eucas1p12b84b5c9445471ecde13b089725bd57c X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20230405100807eucas1p158f0f542e55873249ce4c861df8da7e8 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20230405100807eucas1p158f0f542e55873249ce4c861df8da7e8 References: <20230405093945.3549491-1-michael.wei.hong.sit@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05.04.2023 12:07, Shahab Vahedi wrote: > On 4/5/23 11:39, Michael Sit Wei Hong wrote: >> Some DT devices already have phy device configured in the DT/ACPI. >> Current implementation scans for a phy unconditionally even though >> there is a phy listed in the DT/ACPI and already attached. >> >> We should check the fwnode if there is any phy device listed in >> fwnode and decide whether to scan for a phy to attach to.y >> >> Reported-by: Martin Blumenstingl >> Fixes: fe2cfbc96803 ("net: stmmac: check if MAC needs to attach to a PHY") >> Signed-off-by: Michael Sit Wei Hong >> --- > Works fine on ARC HSDK board. > Tested-by: Shahab Vahedi Tested-by: Marek Szyprowski Works fine on Khadas VIM3, Odroid-C4 and Odroid-M1. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland