From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CD9322F166 for ; Mon, 13 Jan 2025 12:41:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736772115; cv=none; b=asGS2DEXCvlc2RP0f6qHCVa0sDEjMdzNejx2LhAT01y0M3NgorsHecEccZebkfB0lHn/GfvM+rBSitbnBdjV+YAiO4wPf6l9yQKbZz0fYIJpf/kcMAWMGUafnakahCy0Z6Cdr0IAZLiRvXxz5Q/ANRUqARQTHz7E/N8D1QjApEQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736772115; c=relaxed/simple; bh=0regcGnIiOmQotfiGELt5jiaeJOWuIi22iTIBQAFX6Q=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=CEeQAFz//TY0AzPuwa9MqC6xsS2zNOwpQQziJ+1pkC6Df7JLSp497LQrEZW29d+zCCkq9Ay9tuHeXJdkneoE1VgmfP0lW/uizYb1m9G++LHFv9Ywm8PORN/Qz+nN7ICeCtWBRP2yFcw2EVEANoIfdCG5A/k61SUIDZAsWnDbOrc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=mthwYCH9; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="mthwYCH9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1736772111; bh=0regcGnIiOmQotfiGELt5jiaeJOWuIi22iTIBQAFX6Q=; h=Date:Subject:To:References:From:In-Reply-To:From; b=mthwYCH9BDqTa6lcFAbSQZQ5FP4QTeiwXGOOyLe4ArVITbuDL3fwwtoqazrU/Bua+ eLrUqtGBEpWkZ5aLMe9QTqzYPfPERMqReB8+3TWGf4qfyHZ2GRHXumzZf0mX1Q5xME lkxPMEk2fkWAivWK+gTqIi2MhAi42cp4f1jgxxGEyEu1dqWa/E6SqGXhN8wHhSU+HQ QMuH0zunkGC6MzfphecAFRloluvs9QHnqQ4zWrnQKasDVkW5dPp2UPdPYqcwkZbkHC TeOIIutCrSBcBR4HDYvHQ1+BBQtXxY/RdJv96c+5dpJqwJ+O121X1EHhAlWVzHvUfL i1tIwT+Y8sGug== Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by bali.collaboradmins.com (Postfix) with ESMTPSA id EC05217E09AF; Mon, 13 Jan 2025 13:41:50 +0100 (CET) Message-ID: Date: Mon, 13 Jan 2025 13:41:50 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] drm/mediatek/hdmi: Simplify with dev_err_probe To: Krzysztof Kozlowski , Chun-Kuang Hu , Philipp Zabel , David Airlie , Simona Vetter , Matthias Brugger , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20250112134708.46100-1-krzysztof.kozlowski@linaro.org> <20250112134708.46100-2-krzysztof.kozlowski@linaro.org> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: <20250112134708.46100-2-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Il 12/01/25 14:47, Krzysztof Kozlowski ha scritto: > Use dev_err_probe() to make error code and deferred probe handling > simpler. > That's already done in [1] so you can drop this commit. [1]: https://lore.kernel.org/r/20250108112744.64686-1-angelogioacchino.delregno@collabora.com Cheers, Angelo > Signed-off-by: Krzysztof Kozlowski > --- > drivers/gpu/drm/mediatek/mtk_hdmi.c | 22 +++++++--------------- > 1 file changed, 7 insertions(+), 15 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c > index 4b0eb7dc25d8..22935fdc5afe 100644 > --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c > +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c > @@ -1429,19 +1429,13 @@ static int mtk_hdmi_dt_parse_pdata(struct mtk_hdmi *hdmi, > int ret; > > ret = mtk_hdmi_get_all_clk(hdmi, np); > - if (ret) { > - if (ret != -EPROBE_DEFER) > - dev_err(dev, "Failed to get clocks: %d\n", ret); > - > - return ret; > - } > + if (ret) > + return dev_err_probe(dev, ret, "Failed to get clocks\n"); > > /* The CEC module handles HDMI hotplug detection */ > cec_np = of_get_compatible_child(np->parent, "mediatek,mt8173-cec"); > - if (!cec_np) { > - dev_err(dev, "Failed to find CEC node\n"); > - return -EINVAL; > - } > + if (!cec_np) > + return dev_err_probe(dev, -EINVAL, "Failed to find CEC node\n"); > > cec_pdev = of_find_device_by_node(cec_np); > if (!cec_pdev) { > @@ -1492,10 +1486,9 @@ static int mtk_hdmi_dt_parse_pdata(struct mtk_hdmi *hdmi, > > i2c_np = of_parse_phandle(remote, "ddc-i2c-bus", 0); > if (!i2c_np) { > - dev_err(dev, "Failed to find ddc-i2c-bus node in %pOF\n", > - remote); > + ret = dev_err_probe(dev, -EINVAL, "Failed to find ddc-i2c-bus node in %pOF\n", > + remote); > of_node_put(remote); > - ret = -EINVAL; > goto put_device; > } > of_node_put(remote); > @@ -1503,8 +1496,7 @@ static int mtk_hdmi_dt_parse_pdata(struct mtk_hdmi *hdmi, > hdmi->ddc_adpt = of_find_i2c_adapter_by_node(i2c_np); > of_node_put(i2c_np); > if (!hdmi->ddc_adpt) { > - dev_err(dev, "Failed to get ddc i2c adapter by node\n"); > - ret = -EINVAL; > + ret = dev_err_probe(dev, -EINVAL, "Failed to get ddc i2c adapter by node\n"); > goto put_device; > } >