From: Joe Perches <joe@perches.com>
To: Prakhar Sinha <prakharsinha2808@gmail.com>,
gregkh@linuxfoundation.org, kim.jamie.bradley@gmail.com
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rts5208: Fixed checkpath warning.
Date: Fri, 30 Aug 2019 03:03:56 -0700 [thread overview]
Message-ID: <ef0c0782216006d187954e5b80f412bf4b8e6392.camel@perches.com> (raw)
In-Reply-To: <20190830071144.GA29987@MeraComputer>
On Fri, 2019-08-30 at 12:41 +0530, Prakhar Sinha wrote:
> This patch solves the following checkpatch.pl's message in drivers/staging/rts5208/rtsx_transport.c:397.
> WARNING: line over 80 characters
> + option = RTSX_SG_VALID | RTSX_SG_END | RTSX_SG_TRANS_DATA;
[]
> diff --git a/drivers/staging/rts5208/rtsx_transport.c b/drivers/staging/rts5208/rtsx_transport.c
[]
> @@ -394,7 +394,8 @@ static int rtsx_transfer_sglist_adma_partial(struct rtsx_chip *chip, u8 card,
> *index = *index + 1;
> }
> if ((i == (sg_cnt - 1)) || !resid)
> - option = RTSX_SG_VALID | RTSX_SG_END | RTSX_SG_TRANS_DATA;
> + option = RTSX_SG_VALID | RTSX_SG_END |
> + RTSX_SG_TRANS_DATA;
> else
> option = RTSX_SG_VALID | RTSX_SG_TRANS_DATA;
probably more readable as:
option = RTXS_SG_VALID | RTSX_SG_TRANS_DATA;
if (i == sg_cnt - 1 || !resid)
option |= RTXS_SG_END;
The compiler should produce the same object code.
Add parentheses in the if to suit, but they are not
necessary.
prev parent reply other threads:[~2019-08-30 10:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 7:11 Prakhar Sinha
2019-08-30 10:03 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef0c0782216006d187954e5b80f412bf4b8e6392.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kim.jamie.bradley@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=prakharsinha2808@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®