From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6D0DC433F5 for ; Fri, 6 May 2022 11:39:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1391413AbiEFLnV (ORCPT ); Fri, 6 May 2022 07:43:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232024AbiEFLnQ (ORCPT ); Fri, 6 May 2022 07:43:16 -0400 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C84965DE6B for ; Fri, 6 May 2022 04:39:32 -0700 (PDT) X-UUID: 5cf4482705974597a43805780b255883-20220506 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.4,REQID:637941b4-cb86-4741-bcbd-b1ead3e81090,OB:0,LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:45,FILE:0,RULE:Release_Ham,ACT ION:release,TS:45 X-CID-INFO: VERSION:1.1.4,REQID:637941b4-cb86-4741-bcbd-b1ead3e81090,OB:0,LOB: 0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:45,FILE:0,RULE:Release_Ham,ACTIO N:release,TS:45 X-CID-META: VersionHash:faefae9,CLOUDID:806b7816-2e53-443e-b81a-655c13977218,C OID:IGNORED,Recheck:0,SF:28|17|19|48,TC:nil,Content:0,EDM:-3,File:nil,QS:0 ,BEC:nil X-UUID: 5cf4482705974597a43805780b255883-20220506 Received: from mtkcas10.mediatek.inc [(172.21.101.39)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1297254437; Fri, 06 May 2022 19:39:25 +0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.15; Fri, 6 May 2022 19:39:24 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 6 May 2022 19:39:24 +0800 Message-ID: Subject: Re: [RESEND PATCH v7 1/1] firmware: mediatek: add adsp ipc protocol interface From: Tinghan Shen To: Greg Kroah-Hartman CC: Matthias Brugger , Javier Martinez Canillas , Thomas Zimmermann , Sudeep Holla , Bjorn Andersson , Borislav Petkov , Michal Suchanek , "Cristian Marussi" , Etienne Carriere , Arnd Bergmann , Daniel Vetter , Simon Trimmer , "John Stultz" , Pierre-Louis Bossart , AngeloGioacchino Del Regno , Allen-KH Cheng , YC Hung , Tzung-Bi Shih , Curtis Malainey , Mark Brown , , , , , Date: Fri, 6 May 2022 19:39:24 +0800 In-Reply-To: References: <20220505053048.13804-1-tinghan.shen@mediatek.com> <20220505053048.13804-2-tinghan.shen@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Greg, On Thu, 2022-05-05 at 23:11 +0200, Greg Kroah-Hartman wrote: > On Thu, May 05, 2022 at 01:30:48PM +0800, Tinghan Shen wrote: > > From: TingHan Shen > > > > Some of mediatek processors contain > > the Tensilica HiFix DSP for audio processing. > > > > The communication between Host CPU and DSP firmware is > > taking place using a shared memory area for message passing. > > > > ADSP IPC protocol offers (send/recv) interfaces using > > mediatek-mailbox APIs. > > > > We use two mbox channels to implement a request-reply protocol. > > > > Signed-off-by: Allen-KH Cheng > > Signed-off-by: TingHan Shen > > Reviewed-by: Pierre-Louis Bossart > > Reviewed-by: Curtis Malainey > > Reviewed-by: Tzung-Bi Shih > > Reviewed-by: YC Hung > > Reviewed-by: AngeloGioacchino Del Regno > > --- > > drivers/firmware/Kconfig | 1 + > > drivers/firmware/Makefile | 1 + > > drivers/firmware/mediatek/Kconfig | 9 + > > drivers/firmware/mediatek/Makefile | 2 + > > drivers/firmware/mediatek/mtk-adsp-ipc.c | 161 ++++++++++++++++++ > > .../linux/firmware/mediatek/mtk-adsp-ipc.h | 65 +++++++ > > 6 files changed, 239 insertions(+) > > create mode 100644 drivers/firmware/mediatek/Kconfig > > create mode 100644 drivers/firmware/mediatek/Makefile > > create mode 100644 drivers/firmware/mediatek/mtk-adsp-ipc.c > > create mode 100644 include/linux/firmware/mediatek/mtk-adsp-ipc.h > > > > diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig > > index d65964996e8d..c4d149b28944 100644 > > --- a/drivers/firmware/Kconfig > > +++ b/drivers/firmware/Kconfig > > @@ -300,6 +300,7 @@ source "drivers/firmware/cirrus/Kconfig" > > source "drivers/firmware/google/Kconfig" > > source "drivers/firmware/efi/Kconfig" > > source "drivers/firmware/imx/Kconfig" > > +source "drivers/firmware/mediatek/Kconfig" > > source "drivers/firmware/meson/Kconfig" > > source "drivers/firmware/psci/Kconfig" > > source "drivers/firmware/smccc/Kconfig" > > diff --git a/drivers/firmware/Makefile b/drivers/firmware/Makefile > > index 4e58cb474a68..88fbdc110100 100644 > > --- a/drivers/firmware/Makefile > > +++ b/drivers/firmware/Makefile > > @@ -34,6 +34,7 @@ obj-$(CONFIG_GOOGLE_FIRMWARE) += google/ > > obj-$(CONFIG_EFI) += efi/ > > obj-$(CONFIG_UEFI_CPER) += efi/ > > obj-y += imx/ > > +obj-y += mediatek/ > > obj-y += psci/ > > obj-y += smccc/ > > obj-y += tegra/ > > diff --git a/drivers/firmware/mediatek/Kconfig b/drivers/firmware/mediatek/Kconfig > > new file mode 100644 > > index 000000000000..6d1e580b967b > > --- /dev/null > > +++ b/drivers/firmware/mediatek/Kconfig > > @@ -0,0 +1,9 @@ > > +# SPDX-License-Identifier: GPL-2.0-only > > +config MTK_ADSP_IPC > > + tristate "MTK ADSP IPC Protocol driver" > > + depends on MTK_ADSP_MBOX > > + help > > + Say yes here to add support for the MediaTek ADSP IPC > > + between host AP (Linux) and the firmware running on ADSP. > > + ADSP exists on some mtk processors. > > + Client might use shared memory to exchange information with ADSP side. > > diff --git a/drivers/firmware/mediatek/Makefile b/drivers/firmware/mediatek/Makefile > > new file mode 100644 > > index 000000000000..4e840b65650d > > --- /dev/null > > +++ b/drivers/firmware/mediatek/Makefile > > @@ -0,0 +1,2 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > +obj-$(CONFIG_MTK_ADSP_IPC) += mtk-adsp-ipc.o > > diff --git a/drivers/firmware/mediatek/mtk-adsp-ipc.c b/drivers/firmware/mediatek/mtk-adsp-ipc.c > > new file mode 100644 > > index 000000000000..87cee61dbf32 > > --- /dev/null > > +++ b/drivers/firmware/mediatek/mtk-adsp-ipc.c > > @@ -0,0 +1,161 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Copyright (c) 2022 MediaTek Corporation. All rights reserved. > > + * Author: Allen-KH Cheng > > + */ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +/* > > + * mtk_adsp_ipc_send - send ipc cmd to MTK ADSP > > + * > > + * @ipc: ADSP IPC handle > > + * @idx: index of the mailbox channel > > + * @msg: IPC cmd (reply or request) > > + * > > + * Returns zero for success from mbox_send_message > > + * negative value for error > > + */ > > +int mtk_adsp_ipc_send(struct mtk_adsp_ipc *ipc, unsigned int idx, uint32_t msg) > > +{ > > + struct mtk_adsp_chan *adsp_chan; > > + int ret; > > + > > + if (idx >= MTK_ADSP_MBOX_NUM) > > + return -EINVAL; > > + > > + adsp_chan = &ipc->chans[idx]; > > + ret = mbox_send_message(adsp_chan->ch, &msg); > > + if (ret < 0) > > + return ret; > > + > > + /* > > + * mbox_send_message returns non-negative value on success, > > + * return zero for success > > + */ > > + return 0; > > You already said this up in the function comments, no need to duplicate > it again. > > > +} > > +EXPORT_SYMBOL(mtk_adsp_ipc_send); > > EXPORT_SYMBOL_GPL()? I have to ask, sorry. > > thanks, > > greg k-h I'll update these parts in next version. Thank you! Best regards, TingHan