From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752848AbcHLMqi (ORCPT ); Fri, 12 Aug 2016 08:46:38 -0400 Received: from arroyo.ext.ti.com ([198.47.19.12]:47588 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752355AbcHLMqh (ORCPT ); Fri, 12 Aug 2016 08:46:37 -0400 Subject: Re: [PATCH] smartreflex: Neaten logging To: Joe Perches , Kevin Hilman References: <8dd34715bc267a29cade4ceec193ca1066f18db4.1470986036.git.joe@perches.com> CC: , From: Nishanth Menon Message-ID: Date: Fri, 12 Aug 2016 07:46:30 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <8dd34715bc267a29cade4ceec193ca1066f18db4.1470986036.git.joe@perches.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/12/2016 02:14 AM, Joe Perches wrote: > Use a more common logging style. > > Miscellanea: > > o Use pr_warn > o Coalesce formats adding missing spaces > o Argument alignment > o Remove unnecessary OOM messages as k.alloc does stack dumps > > Signed-off-by: Joe Perches Acked-by: Nishanth Menon Kevin, would you be able to pick this up? -- Regards, Nishanth Menon